)]}'
{"glance/db/__init__.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"722e81a2cb14616ad37e4c38b3686d5c853f8fb1","unresolved":true,"context_lines":[{"line_number":182,"context_line":"        if (image_values[\u0027size\u0027] is not None"},{"line_number":183,"context_line":"           and image_values[\u0027size\u0027] \u003e CONF.image_size_cap):"},{"line_number":184,"context_line":"            raise exception.ImageSizeLimitExceeded"},{"line_number":185,"context_line":"        try:"},{"line_number":186,"context_line":"            new_values \u003d self.db_api.image_update(self.context,"},{"line_number":187,"context_line":"                                                  image.image_id,"},{"line_number":188,"context_line":"                                                  image_values,"},{"line_number":189,"context_line":"                                                  purge_props\u003dTrue,"},{"line_number":190,"context_line":"                                                  from_state\u003dfrom_state,"},{"line_number":191,"context_line":"                                                  atomic_props\u003d("},{"line_number":192,"context_line":"                                                      IMAGE_ATOMIC_PROPS))"},{"line_number":193,"context_line":"        except exception.ImageNotFound:"},{"line_number":194,"context_line":"            msg \u003d _(\"No image found with ID %s\") % image.image_id"},{"line_number":195,"context_line":"            raise exception.ImageNotFound(msg)"},{"line_number":196,"context_line":"        self.db_api.image_tag_set_all(self.context, image.image_id,"},{"line_number":197,"context_line":"                                      image.tags)"},{"line_number":198,"context_line":"        image.updated_at \u003d new_values[\u0027updated_at\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"d39a3058_4df0eadb","line":195,"range":{"start_line":185,"start_character":8,"end_line":195,"end_character":46},"updated":"2021-07-16 13:44:56.000000000","message":"I don\u0027t see any advantage of catching and raising same exception again as well.\nIMO better we should remove this try, except block as well.","commit_id":"efc9e7cd6adc7c39cec691af85a5d2a781b7d6c0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"049d6a9fdb0dc50c96dbad0f7c6b1325aef6146a","unresolved":true,"context_lines":[{"line_number":182,"context_line":"        if (image_values[\u0027size\u0027] is not None"},{"line_number":183,"context_line":"           and image_values[\u0027size\u0027] \u003e CONF.image_size_cap):"},{"line_number":184,"context_line":"            raise exception.ImageSizeLimitExceeded"},{"line_number":185,"context_line":"        try:"},{"line_number":186,"context_line":"            new_values \u003d self.db_api.image_update(self.context,"},{"line_number":187,"context_line":"                                                  image.image_id,"},{"line_number":188,"context_line":"                                                  image_values,"},{"line_number":189,"context_line":"                                                  purge_props\u003dTrue,"},{"line_number":190,"context_line":"                                                  from_state\u003dfrom_state,"},{"line_number":191,"context_line":"                                                  atomic_props\u003d("},{"line_number":192,"context_line":"                                                      IMAGE_ATOMIC_PROPS))"},{"line_number":193,"context_line":"        except exception.ImageNotFound:"},{"line_number":194,"context_line":"            msg \u003d _(\"No image found with ID %s\") % image.image_id"},{"line_number":195,"context_line":"            raise exception.ImageNotFound(msg)"},{"line_number":196,"context_line":"        self.db_api.image_tag_set_all(self.context, image.image_id,"},{"line_number":197,"context_line":"                                      image.tags)"},{"line_number":198,"context_line":"        image.updated_at \u003d new_values[\u0027updated_at\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"c088edd4_0577c0b3","line":195,"range":{"start_line":185,"start_character":8,"end_line":195,"end_character":46},"in_reply_to":"d39a3058_4df0eadb","updated":"2021-07-16 13:53:59.000000000","message":"Yeah, I think this resolves to:\n\nhttp://github.com/openstack/glance/blob/2b62197f91cf52566d7acbce6edf68c2e7477a17/glance/db/sqlalchemy/api.py#L282-L284\n\nSo no point in keeping this. I dunno why it was catching NotFound here before, as it could have just caught Forbidden and let NotFound bubble up by itself.","commit_id":"efc9e7cd6adc7c39cec691af85a5d2a781b7d6c0"}],"glance/db/simple/api.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"143cbe3c3227b3d44aeba198dcfcb2a614ae37f2","unresolved":true,"context_lines":[{"line_number":804,"context_line":"    try:"},{"line_number":805,"context_line":"        image \u003d DATA[\u0027images\u0027][image_id]"},{"line_number":806,"context_line":"    except KeyError:"},{"line_number":807,"context_line":"        raise exception.ImageNotFound(image_id)"},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"    location_data \u003d image_values.pop(\u0027locations\u0027, None)"},{"line_number":810,"context_line":"    if location_data is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"37b7e8fe_7b924504","line":807,"range":{"start_line":807,"start_character":0,"end_line":807,"end_character":47},"updated":"2021-07-19 15:43:18.000000000","message":"So I get the change in glance/db/__init__.py, but why do we need to start passing image ID here?","commit_id":"7175bb7daa070ac86bab232e8433f4c9100a0ccd"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ddd51b190fb79d0785470bee9d628b6cfd09fb7c","unresolved":true,"context_lines":[{"line_number":804,"context_line":"    try:"},{"line_number":805,"context_line":"        image \u003d DATA[\u0027images\u0027][image_id]"},{"line_number":806,"context_line":"    except KeyError:"},{"line_number":807,"context_line":"        raise exception.ImageNotFound(image_id)"},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"    location_data \u003d image_values.pop(\u0027locations\u0027, None)"},{"line_number":810,"context_line":"    if location_data is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7df68c89_d6d3716a","line":807,"range":{"start_line":807,"start_character":0,"end_line":807,"end_character":47},"in_reply_to":"37b7e8fe_7b924504","updated":"2021-07-19 15:48:55.000000000","message":"You can see the failure in the previous logs, there is one test which actually test log message and as our unit tests are using simple db and here we are not passing image_id to exception it was failing while matching something like\n\nImage \u0027abcd\u0027 not found vs Image %(image_id)s not found.","commit_id":"7175bb7daa070ac86bab232e8433f4c9100a0ccd"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"a62c0521afcacb85421712578ac2512339cad86f","unresolved":true,"context_lines":[{"line_number":804,"context_line":"    try:"},{"line_number":805,"context_line":"        image \u003d DATA[\u0027images\u0027][image_id]"},{"line_number":806,"context_line":"    except KeyError:"},{"line_number":807,"context_line":"        raise exception.ImageNotFound(image_id)"},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"    location_data \u003d image_values.pop(\u0027locations\u0027, None)"},{"line_number":810,"context_line":"    if location_data is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"0d4b25d7_2af1f6fa","line":807,"range":{"start_line":807,"start_character":0,"end_line":807,"end_character":47},"in_reply_to":"7df68c89_d6d3716a","updated":"2021-07-28 18:46:30.000000000","message":"OK,thanks.","commit_id":"7175bb7daa070ac86bab232e8433f4c9100a0ccd"}]}