)]}'
{"glance/api/v2/metadef_properties.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"01493571057265b93f005e6752debf659a9f971e","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    def index(self, req, namespace):"},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            ns_repo \u003d self.gateway.get_metadef_namespace_repo(req.context)"},{"line_number":67,"context_line":"            namespace_obj \u003d ns_repo.get(namespace)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"            filters \u003d dict()"},{"line_number":70,"context_line":"            filters[\u0027namespace\u0027] \u003d namespace"}],"source_content_type":"text/x-python","patch_set":4,"id":"0d9c34e9_107df98a","line":67,"range":{"start_line":67,"start_character":12,"end_line":67,"end_character":50},"updated":"2021-07-12 10:00:24.000000000","message":"Need to add 403 \u003e\u003e\u003e 404 related warning","commit_id":"82ff58b02fdd220a47fac65483830fe792e1350f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"01493571057265b93f005e6752debf659a9f971e","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    def show(self, req, namespace, property_name, filters\u003dNone):"},{"line_number":89,"context_line":"        try:"},{"line_number":90,"context_line":"            ns_repo \u003d self.gateway.get_metadef_namespace_repo(req.context)"},{"line_number":91,"context_line":"            namespace_obj \u003d ns_repo.get(namespace)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            if filters and filters[\u0027resource_type\u0027]:"},{"line_number":94,"context_line":"                rs_repo \u003d self.gateway.get_metadef_resource_type_repo("}],"source_content_type":"text/x-python","patch_set":4,"id":"7d7aeeaa_b39b737e","line":91,"range":{"start_line":91,"start_character":12,"end_line":91,"end_character":47},"updated":"2021-07-12 10:00:24.000000000","message":"ditto","commit_id":"82ff58b02fdd220a47fac65483830fe792e1350f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"01493571057265b93f005e6752debf659a9f971e","unresolved":true,"context_lines":[{"line_number":123,"context_line":"    def create(self, req, namespace, property_type):"},{"line_number":124,"context_line":"        prop_factory \u003d self.gateway.get_metadef_property_factory(req.context)"},{"line_number":125,"context_line":"        prop_repo \u003d self.gateway.get_metadef_property_repo(req.context)"},{"line_number":126,"context_line":"        try:"},{"line_number":127,"context_line":"            new_property_type \u003d prop_factory.new_namespace_property("},{"line_number":128,"context_line":"                namespace\u003dnamespace, **self._to_dict(property_type))"},{"line_number":129,"context_line":"            prop_repo.add(new_property_type)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fab24bcb_e15f3f87","line":126,"updated":"2021-07-12 10:00:24.000000000","message":"I think like update and delete you can add check for namespace here as well.","commit_id":"82ff58b02fdd220a47fac65483830fe792e1350f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"01493571057265b93f005e6752debf659a9f971e","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        prop_repo \u003d self.gateway.get_metadef_property_repo(req.context)"},{"line_number":149,"context_line":"        try:"},{"line_number":150,"context_line":"            ns_repo \u003d self.gateway.get_metadef_namespace_repo(req.context)"},{"line_number":151,"context_line":"            namespace_obj \u003d ns_repo.get(namespace)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"            db_property_type \u003d prop_repo.get(namespace_obj, property_name)"},{"line_number":154,"context_line":"            db_property_type._old_name \u003d db_property_type.name"}],"source_content_type":"text/x-python","patch_set":4,"id":"f9997d47_e773ed9e","line":151,"range":{"start_line":151,"start_character":11,"end_line":151,"end_character":50},"updated":"2021-07-12 10:00:24.000000000","message":"ditto","commit_id":"82ff58b02fdd220a47fac65483830fe792e1350f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"01493571057265b93f005e6752debf659a9f971e","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        prop_repo \u003d self.gateway.get_metadef_property_repo(req.context)"},{"line_number":177,"context_line":"        try:"},{"line_number":178,"context_line":"            ns_repo \u003d self.gateway.get_metadef_namespace_repo(req.context)"},{"line_number":179,"context_line":"            namespace_obj \u003d ns_repo.get(namespace)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            property_type \u003d prop_repo.get(namespace_obj, property_name)"},{"line_number":182,"context_line":"            property_type.delete()"}],"source_content_type":"text/x-python","patch_set":4,"id":"a6772b98_6096f1b9","line":179,"range":{"start_line":179,"start_character":12,"end_line":179,"end_character":50},"updated":"2021-07-12 10:00:24.000000000","message":"ditto","commit_id":"82ff58b02fdd220a47fac65483830fe792e1350f"}],"glance/api/v2/metadef_tags.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"01493571057265b93f005e6752debf659a9f971e","unresolved":true,"context_lines":[{"line_number":109,"context_line":"              sort_key\u003d\u0027created_at\u0027, sort_dir\u003d\u0027desc\u0027, filters\u003dNone):"},{"line_number":110,"context_line":"        try:"},{"line_number":111,"context_line":"            ns_repo \u003d self.gateway.get_metadef_namespace_repo(req.context)"},{"line_number":112,"context_line":"            namespace_obj \u003d ns_repo.get(namespace)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            filters \u003d filters or dict()"},{"line_number":115,"context_line":"            filters[\u0027namespace\u0027] \u003d namespace"}],"source_content_type":"text/x-python","patch_set":4,"id":"b75ef228_21dfd267","line":112,"range":{"start_line":112,"start_character":12,"end_line":112,"end_character":50},"updated":"2021-07-12 10:00:24.000000000","message":"ditto","commit_id":"82ff58b02fdd220a47fac65483830fe792e1350f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"01493571057265b93f005e6752debf659a9f971e","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        meta_tag_repo \u003d self.gateway.get_metadef_tag_repo(req.context)"},{"line_number":145,"context_line":"        try:"},{"line_number":146,"context_line":"            ns_repo \u003d self.gateway.get_metadef_namespace_repo(req.context)"},{"line_number":147,"context_line":"            namespace_obj \u003d ns_repo.get(namespace)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"            metadef_tag \u003d meta_tag_repo.get(namespace_obj, tag_name)"},{"line_number":150,"context_line":"            return MetadefTag.to_wsme_model(metadef_tag)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1081eeb7_3c7fa3cf","line":147,"range":{"start_line":147,"start_character":12,"end_line":147,"end_character":50},"updated":"2021-07-12 10:00:24.000000000","message":"ditto","commit_id":"82ff58b02fdd220a47fac65483830fe792e1350f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"01493571057265b93f005e6752debf659a9f971e","unresolved":true,"context_lines":[{"line_number":191,"context_line":"        meta_repo \u003d self.gateway.get_metadef_tag_repo(req.context)"},{"line_number":192,"context_line":"        try:"},{"line_number":193,"context_line":"            ns_repo \u003d self.gateway.get_metadef_namespace_repo(req.context)"},{"line_number":194,"context_line":"            namespace_obj \u003d ns_repo.get(namespace)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"            metadef_tag \u003d meta_repo.get(namespace_obj, tag_name)"},{"line_number":197,"context_line":"            metadef_tag.delete()"}],"source_content_type":"text/x-python","patch_set":4,"id":"07f79450_ff1d5f27","line":194,"range":{"start_line":194,"start_character":12,"end_line":194,"end_character":42},"updated":"2021-07-12 10:00:24.000000000","message":"ditto\n\nAlso similar to delete and update you can add this check for create call as well.","commit_id":"82ff58b02fdd220a47fac65483830fe792e1350f"}],"glance/tests/functional/v2/test_metadef_properties.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"56f411ba507de720b2db93a79fc8a9e3d8fab183","unresolved":true,"context_lines":[{"line_number":242,"context_line":"                    \"type\": \"integer\","},{"line_number":243,"context_line":"                    \"title\": \"property\","},{"line_number":244,"context_line":"                    \"description\": \"property description\","},{"line_number":245,"context_line":"                    \"default\": 100,"},{"line_number":246,"context_line":"                    \"minimum\": 100,"},{"line_number":247,"context_line":"                    \"maximum\": 30000369,"},{"line_number":248,"context_line":"                    \"readonly\": False,"},{"line_number":249,"context_line":"                })"},{"line_number":250,"context_line":"            path \u003d self._url(\u0027/v2/metadefs/namespaces/%s/properties\u0027 %"},{"line_number":251,"context_line":"                             namespace[\u0027namespace\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"335663aa_b8428fc1","line":248,"range":{"start_line":245,"start_character":0,"end_line":248,"end_character":38},"updated":"2021-07-23 09:06:15.000000000","message":"I think you can remove these as well.","commit_id":"7ed318c3f768e2654779d8fe6ad7db1c68d988f9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"56f411ba507de720b2db93a79fc8a9e3d8fab183","unresolved":true,"context_lines":[{"line_number":339,"context_line":"                \"type\": \"string\","},{"line_number":340,"context_line":"                \"title\": \"string property\","},{"line_number":341,"context_line":"                \"description\": \"desc-UPDATED\","},{"line_number":342,"context_line":"                \"operators\": [\"\u003cor\u003e\"],"},{"line_number":343,"context_line":"                \"default\": \"value-UPDATED\","},{"line_number":344,"context_line":"                \"minLength\": 5,"},{"line_number":345,"context_line":"                \"maxLength\": 10,"},{"line_number":346,"context_line":"                \"readonly\": True,"},{"line_number":347,"context_line":"            }"},{"line_number":348,"context_line":"            path \u003d self._url(\u0027/v2/metadefs/namespaces/%s/properties/%s\u0027 %"},{"line_number":349,"context_line":"                             (prop[\u0027namespace\u0027][\u0027namespace\u0027],"}],"source_content_type":"text/x-python","patch_set":14,"id":"4c60b141_b0aca6b1","line":346,"range":{"start_line":342,"start_character":0,"end_line":346,"end_character":33},"updated":"2021-07-23 09:06:15.000000000","message":"ditto, update description only and check for that in results.","commit_id":"7ed318c3f768e2654779d8fe6ad7db1c68d988f9"}],"glance/tests/functional/v2/test_metadef_tags.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"56f411ba507de720b2db93a79fc8a9e3d8fab183","unresolved":true,"context_lines":[{"line_number":295,"context_line":"                }))"},{"line_number":296,"context_line":"            self.assertEqual(http.FORBIDDEN, response.status_code)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        # Delete all metadef tags"},{"line_number":299,"context_line":"        for tag in total_tags:"},{"line_number":300,"context_line":"            path \u003d self._url(\u0027/v2/metadefs/namespaces/%s/tags/%s\u0027 %"},{"line_number":301,"context_line":"                             (tag[\u0027namespace\u0027][\u0027namespace\u0027],"},{"line_number":302,"context_line":"                              tag[\u0027tag\u0027][\u0027name\u0027]))"},{"line_number":303,"context_line":"            response \u003d requests.delete(path, headers\u003dself._headers())"},{"line_number":304,"context_line":"            self.assertEqual(http.NO_CONTENT, response.status_code)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"            # Deleted tags should not be exist"},{"line_number":307,"context_line":"            response \u003d requests.get(path, headers\u003dself._headers())"},{"line_number":308,"context_line":"            self.assertEqual(http.NOT_FOUND, response.status_code)"}],"source_content_type":"text/x-python","patch_set":14,"id":"651383b3_bf54ea45","line":308,"range":{"start_line":298,"start_character":8,"end_line":308,"end_character":66},"updated":"2021-07-23 09:06:15.000000000","message":"There are two different APIs to delete tags\n\n/v2/metadefs/namespaces/{namespace_name}/tags\n\n/v2/metadefs/namespaces/{namespace_name}/tags/{tag_name}\nYou are testing this one, we need to test above one as well.","commit_id":"7ed318c3f768e2654779d8fe6ad7db1c68d988f9"}]}