)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"98b8aec7b32e1f45736ea2696f0437d40402762e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u0027community\u0027 images needs to be treated as public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The file acls on community images needs to be treated as if the"},{"line_number":10,"context_line":"image was public."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I79683c81233b35f2399119128a63d33d69c50eeb"},{"line_number":13,"context_line":"Closes-bug: #1885928"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ef56c76b_9c1a89a9","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":17},"updated":"2021-07-15 17:24:44.000000000","message":"Any specific reason behind so?","commit_id":"b3fc120881ca0ee6d2e8d950bbdcda34a5a3bedb"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6e365aa7bf215871dfe9743b0c851915f40af12a","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u0027community\u0027 images needs to be treated as public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The file acls on community images needs to be treated as if the"},{"line_number":10,"context_line":"image was public."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I79683c81233b35f2399119128a63d33d69c50eeb"},{"line_number":13,"context_line":"Closes-bug: #1885928"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8aac5912_02bd4a7e","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":17},"in_reply_to":"ef56c76b_9c1a89a9","updated":"2021-07-16 10:59:03.000000000","message":"The image data should be available to everyone just like with public images. We just don\u0027t list them by default. Now for example Swift (with multitenant) does not allow downloading the image as the permissions are set to owner only.","commit_id":"b3fc120881ca0ee6d2e8d950bbdcda34a5a3bedb"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"83d0499523daf00234f4888dfe32dfbc6cd107b3","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u0027community\u0027 images needs to be treated as public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Even the \u0027community\u0027 images re not listed by default their"},{"line_number":10,"context_line":"behaviour is like public images otherwise. This means that"},{"line_number":11,"context_line":"the image data needs to be available for everyone and thus"},{"line_number":12,"context_line":"the acls for the file/object should be like public too."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e51a024e_8b9a066e","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":8},"updated":"2021-08-31 14:46:58.000000000","message":"I think you want \"though\" in front of this? \"Even though the community images are not listed by defauly, their behavior is like public images otherwise.\"","commit_id":"177d8586b9d2b1b7f7203beb7a4963824cb754ed"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"83d0499523daf00234f4888dfe32dfbc6cd107b3","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u0027community\u0027 images needs to be treated as public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Even the \u0027community\u0027 images re not listed by default their"},{"line_number":10,"context_line":"behaviour is like public images otherwise. This means that"},{"line_number":11,"context_line":"the image data needs to be available for everyone and thus"},{"line_number":12,"context_line":"the acls for the file/object should be like public too."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1fd188cb_99c162b9","line":9,"range":{"start_line":9,"start_character":28,"end_line":9,"end_character":30},"updated":"2021-08-31 14:46:58.000000000","message":"are","commit_id":"177d8586b9d2b1b7f7203beb7a4963824cb754ed"}],"glance/location.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"98b8aec7b32e1f45736ea2696f0437d40402762e","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        self.db_api \u003d glance.db.get_api()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _set_acls(self, image):"},{"line_number":54,"context_line":"        public \u003d image.visibility in [\u0027public\u0027, \u0027community\u0027]"},{"line_number":55,"context_line":"        member_ids \u003d []"},{"line_number":56,"context_line":"        if image.locations and not public:"},{"line_number":57,"context_line":"            member_repo \u003d _get_member_repo_for_store(image,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e9d1048e_c4df89bb","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":60},"updated":"2021-07-15 17:24:44.000000000","message":"I think we need to improve our tempest scenario coverage for each types of visibility we support to avoid these kind of issues in future.","commit_id":"b3fc120881ca0ee6d2e8d950bbdcda34a5a3bedb"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6e365aa7bf215871dfe9743b0c851915f40af12a","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        self.db_api \u003d glance.db.get_api()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _set_acls(self, image):"},{"line_number":54,"context_line":"        public \u003d image.visibility in [\u0027public\u0027, \u0027community\u0027]"},{"line_number":55,"context_line":"        member_ids \u003d []"},{"line_number":56,"context_line":"        if image.locations and not public:"},{"line_number":57,"context_line":"            member_repo \u003d _get_member_repo_for_store(image,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9edf55bf_14e8d508","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":60},"in_reply_to":"e9d1048e_c4df89bb","updated":"2021-07-16 10:59:03.000000000","message":"Yah, I have no idea if we have community image tests in tempest at all and if we do, we clearly don\u0027t run \u0027em against Swift multitenant environment.","commit_id":"b3fc120881ca0ee6d2e8d950bbdcda34a5a3bedb"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"07da4db5013d71635c044f6b766803b40aee1274","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        self.db_api \u003d glance.db.get_api()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _set_acls(self, image):"},{"line_number":54,"context_line":"        public \u003d image.visibility in [\u0027public\u0027, \u0027community\u0027]"},{"line_number":55,"context_line":"        member_ids \u003d []"},{"line_number":56,"context_line":"        if image.locations and not public:"},{"line_number":57,"context_line":"            member_repo \u003d _get_member_repo_for_store(image,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e385e191_78b5e254","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":60},"updated":"2021-08-16 15:31:17.000000000","message":"This method is covering shared image case, whenever image is shared with new project we need to update the read_tenants using set_acls method, same goes with remove as well, whenever image sharing is removed for any project.\n\nIt\u0027s good to have a test to cover this scenario, but I am ok to do it as a follow up.","commit_id":"177d8586b9d2b1b7f7203beb7a4963824cb754ed"}]}