)]}'
{"glance/tests/functional/v2/test_tasks_api_policy.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"cbd773c7b460c7a33cf77d5716d277df0d1132ce","unresolved":true,"context_lines":[{"line_number":50,"context_line":"class TestTasksPolicy(functional.SynchronousAPIBase):"},{"line_number":51,"context_line":"    def setUp(self):"},{"line_number":52,"context_line":"        super(TestTasksPolicy, self).setUp()"},{"line_number":53,"context_line":"        self.policy \u003d policy.Enforcer()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def set_policy_rules(self, rules):"},{"line_number":56,"context_line":"        self.policy.set_rules("}],"source_content_type":"text/x-python","patch_set":10,"id":"d65986e3_506862a8","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":39},"updated":"2021-08-19 14:37:47.000000000","message":"self.policy \u003d policy.Enforcer(suppress_deprecation_warnings\u003dTrue)","commit_id":"d68be499fa4352132ee5649baeacdd55fc0d8578"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b89a5ce3b35a8d2e43db3a63e1b43e5e455e598e","unresolved":true,"context_lines":[{"line_number":98,"context_line":"        # First make sure  get tasks works with default policy"},{"line_number":99,"context_line":"        tasks \u003d self.load_data()"},{"line_number":100,"context_line":"        path \u003d \u0027/v2/tasks\u0027"},{"line_number":101,"context_line":"        resp \u003d self.api_get(path)"},{"line_number":102,"context_line":"        output \u003d jsonutils.loads(resp.text)"},{"line_number":103,"context_line":"        self.assertEqual(len(tasks), len(output[\u0027tasks\u0027]))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Now disable tasks_api_access permissions and make sure any other"}],"source_content_type":"text/x-python","patch_set":13,"id":"3baf3710_385550b0","line":102,"range":{"start_line":101,"start_character":0,"end_line":102,"end_character":43},"updated":"2021-08-23 14:24:14.000000000","message":"nit:\n\n output \u003d self.api_get(path).json","commit_id":"23b653c10c2858a4820036554f8382ae73f1f39e"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f5f20f98b1e5d853bfa04d07837c031c69dc51ee","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # First make sure  get tasks works with default policy"},{"line_number":99,"context_line":"        tasks \u003d self.load_data()"},{"line_number":100,"context_line":"        path \u003d \u0027/v2/tasks\u0027"},{"line_number":101,"context_line":"        resp \u003d self.api_get(path)"},{"line_number":102,"context_line":"        output \u003d jsonutils.loads(resp.text)"},{"line_number":103,"context_line":"        self.assertEqual(len(tasks), len(output[\u0027tasks\u0027]))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Now disable tasks_api_access permissions and make sure any other"}],"source_content_type":"text/x-python","patch_set":13,"id":"7dbbb799_7a4ae8a3","line":102,"range":{"start_line":101,"start_character":0,"end_line":102,"end_character":43},"in_reply_to":"3baf3710_385550b0","updated":"2021-08-23 15:56:36.000000000","message":"Ack","commit_id":"23b653c10c2858a4820036554f8382ae73f1f39e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b89a5ce3b35a8d2e43db3a63e1b43e5e455e598e","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        tasks \u003d self.load_data()"},{"line_number":115,"context_line":"        path \u003d \u0027/v2/tasks/%s\u0027 % tasks[0]"},{"line_number":116,"context_line":"        resp \u003d self.api_get(path)"},{"line_number":117,"context_line":"        task \u003d jsonutils.loads(resp.text)"},{"line_number":118,"context_line":"        self.assertEqual(\u0027import\u0027, task[\u0027type\u0027])"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # Now disable tasks_api_access permissions and make sure any other"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a72dd6b_096f293c","line":117,"updated":"2021-08-23 14:24:14.000000000","message":"Same.","commit_id":"23b653c10c2858a4820036554f8382ae73f1f39e"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f5f20f98b1e5d853bfa04d07837c031c69dc51ee","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        tasks \u003d self.load_data()"},{"line_number":115,"context_line":"        path \u003d \u0027/v2/tasks/%s\u0027 % tasks[0]"},{"line_number":116,"context_line":"        resp \u003d self.api_get(path)"},{"line_number":117,"context_line":"        task \u003d jsonutils.loads(resp.text)"},{"line_number":118,"context_line":"        self.assertEqual(\u0027import\u0027, task[\u0027type\u0027])"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # Now disable tasks_api_access permissions and make sure any other"}],"source_content_type":"text/x-python","patch_set":13,"id":"04dae838_f72ef556","line":117,"in_reply_to":"3a72dd6b_096f293c","updated":"2021-08-23 15:56:36.000000000","message":"Ack","commit_id":"23b653c10c2858a4820036554f8382ae73f1f39e"}],"glance/tests/unit/v2/test_tasks_resource.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b89a5ce3b35a8d2e43db3a63e1b43e5e455e598e","unresolved":true,"context_lines":[{"line_number":489,"context_line":"        request \u003d unit_test_utils.get_fake_request()"},{"line_number":490,"context_line":"        self.assertRaises(webob.exc.HTTPForbidden, self.controller.get,"},{"line_number":491,"context_line":"                          request, task_id\u003dUUID2)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def test_access_get_unauthorized(self):"},{"line_number":494,"context_line":"        rules \u003d {\"tasks_api_access\": False,"},{"line_number":495,"context_line":"                 \"get_task\": True}"}],"source_content_type":"text/x-python","patch_set":13,"id":"75e40e7e_089a21ad","side":"PARENT","line":492,"updated":"2021-08-23 14:24:14.000000000","message":"If we\u0027re going to leave the rest here, should we not just change these to use tasks_api_access\u003dFalse? Is there some other thing that makes that hard?","commit_id":"364871333cd8b37eca42cf96041ab6cac1886ef5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ae4f50eb1b2afee939a301059a047d029a53dfa8","unresolved":true,"context_lines":[{"line_number":489,"context_line":"        request \u003d unit_test_utils.get_fake_request()"},{"line_number":490,"context_line":"        self.assertRaises(webob.exc.HTTPForbidden, self.controller.get,"},{"line_number":491,"context_line":"                          request, task_id\u003dUUID2)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def test_access_get_unauthorized(self):"},{"line_number":494,"context_line":"        rules \u003d {\"tasks_api_access\": False,"},{"line_number":495,"context_line":"                 \"get_task\": True}"}],"source_content_type":"text/x-python","patch_set":13,"id":"9d2f6a54_09905dc7","side":"PARENT","line":492,"in_reply_to":"741353c0_6f202a08","updated":"2021-08-23 17:11:07.000000000","message":"But! But! .. Okay, yeah sorry ;)","commit_id":"364871333cd8b37eca42cf96041ab6cac1886ef5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f5f20f98b1e5d853bfa04d07837c031c69dc51ee","unresolved":true,"context_lines":[{"line_number":489,"context_line":"        request \u003d unit_test_utils.get_fake_request()"},{"line_number":490,"context_line":"        self.assertRaises(webob.exc.HTTPForbidden, self.controller.get,"},{"line_number":491,"context_line":"                          request, task_id\u003dUUID2)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def test_access_get_unauthorized(self):"},{"line_number":494,"context_line":"        rules \u003d {\"tasks_api_access\": False,"},{"line_number":495,"context_line":"                 \"get_task\": True}"}],"source_content_type":"text/x-python","patch_set":13,"id":"741353c0_6f202a08","side":"PARENT","line":492,"in_reply_to":"75e40e7e_089a21ad","updated":"2021-08-23 15:56:36.000000000","message":"test_get_unauthorized with task_api_access:False is tested at line #493\ntest_index_unauthorized and test_create_task_unauthorized with task_api_access:False is tested at line #549 and #571 in same file.","commit_id":"364871333cd8b37eca42cf96041ab6cac1886ef5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"90da7b80952262f9b50a5b7f91389294f09693b8","unresolved":true,"context_lines":[{"line_number":489,"context_line":"        request \u003d unit_test_utils.get_fake_request()"},{"line_number":490,"context_line":"        self.assertRaises(webob.exc.HTTPForbidden, self.controller.get,"},{"line_number":491,"context_line":"                          request, task_id\u003dUUID2)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def test_access_get_unauthorized(self):"},{"line_number":494,"context_line":"        rules \u003d {\"tasks_api_access\": False,"},{"line_number":495,"context_line":"                 \"get_task\": True}"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff17aeaf_dfb07640","side":"PARENT","line":492,"in_reply_to":"9d2f6a54_09905dc7","updated":"2021-08-23 17:24:55.000000000","message":"No offense, now I see what are you suggesting here, added to ToDo list, will submit a separate patch to remove this class as other tests are of no use.","commit_id":"364871333cd8b37eca42cf96041ab6cac1886ef5"}]}
