)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"1b7de261862533abe4f9f9d0e4d524c214a40a6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e116a214_386f58ce","updated":"2021-11-04 15:52:38.000000000","message":"\u003e We can endup in this situation when nova tries to PATCH an image by\nadding a location (nova is not populating the metadata).\n\nCan\u0027t Nova populate the metadata itself?\n\n\nOtherwise, as stated by Dan, we really want to see some tests here.","commit_id":"39654d32abc9a90702ca23d809761aa873fb903f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"f87e59ff3035536d0856bf24f1f76f1d4952f719","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b47e7f58_33b7ea2d","updated":"2022-01-18 18:13:50.000000000","message":"This makes sense to do, just couple of concerns inline.","commit_id":"39654d32abc9a90702ca23d809761aa873fb903f"}],"glance/location.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"f87e59ff3035536d0856bf24f1f76f1d4952f719","unresolved":true,"context_lines":[{"line_number":131,"context_line":"def _check_image_location(context, store_api, store_utils, location):"},{"line_number":132,"context_line":"    backend \u003d None"},{"line_number":133,"context_line":"    if CONF.enabled_backends:"},{"line_number":134,"context_line":"        backend \u003d location[\u0027metadata\u0027].get(\u0027store\u0027)"},{"line_number":135,"context_line":"        # NOTE(amorin): if backend is not in metadata (e.g. request coming"},{"line_number":136,"context_line":"        # from nova), then try to figure it out from URL"},{"line_number":137,"context_line":"        if not backend:"},{"line_number":138,"context_line":"            backend \u003d store_utils._get_store_id_from_uri(location[\u0027url\u0027])"},{"line_number":139,"context_line":"            location[\u0027metadata\u0027][\u0027backend\u0027] \u003d backend"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    _check_location_uri(context, store_api, store_utils, location[\u0027url\u0027],"},{"line_number":142,"context_line":"                        backend\u003dbackend)"}],"source_content_type":"text/x-python","patch_set":1,"id":"922a0ca2_30f734f6","line":139,"range":{"start_line":134,"start_character":8,"end_line":139,"end_character":53},"updated":"2022-01-18 18:13:50.000000000","message":"we have .get(\u0027store\u0027) but at the end this would write it to the \u0027backend\u0027 key of the \u0027metadata\u0027. Something seems off here.\n\nAlso this is validation function. We probably should find better place to set the metadata before the validations are called. Using the _get_store_id_from_uri is likely the right thing to do (it being ^_* likely not justified)","commit_id":"39654d32abc9a90702ca23d809761aa873fb903f"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"0529288482e0925b23b7874df819cadbaf1cb571","unresolved":true,"context_lines":[{"line_number":131,"context_line":"def _check_image_location(context, store_api, store_utils, location):"},{"line_number":132,"context_line":"    backend \u003d None"},{"line_number":133,"context_line":"    if CONF.enabled_backends:"},{"line_number":134,"context_line":"        backend \u003d location[\u0027metadata\u0027].get(\u0027store\u0027)"},{"line_number":135,"context_line":"        # NOTE(amorin): if backend is not in metadata (e.g. request coming"},{"line_number":136,"context_line":"        # from nova), then try to figure it out from URL"},{"line_number":137,"context_line":"        if not backend:"},{"line_number":138,"context_line":"            backend \u003d store_utils._get_store_id_from_uri(location[\u0027url\u0027])"},{"line_number":139,"context_line":"            location[\u0027metadata\u0027][\u0027backend\u0027] \u003d backend"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    _check_location_uri(context, store_api, store_utils, location[\u0027url\u0027],"},{"line_number":142,"context_line":"                        backend\u003dbackend)"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd80584a_3378a7aa","line":139,"range":{"start_line":134,"start_character":8,"end_line":139,"end_character":53},"in_reply_to":"922a0ca2_30f734f6","updated":"2022-01-20 13:01:53.000000000","message":"Damn, you are right about this store/backend.\nSo I will need to double check this again (we are running stein, with backend, not store).","commit_id":"39654d32abc9a90702ca23d809761aa873fb903f"}]}