)]}'
{"glance/tests/functional/db/migrations/test_ocata_expand01.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"0cd9e0a057a559cafea3a00dca4f91dfa378c9a4","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        self.assertTrue(images.c.visibility.nullable)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # tests visibility set to None for existing images"},{"line_number":65,"context_line":"        with engine.connect() as conn:"},{"line_number":66,"context_line":"            rows \u003d conn.execute("},{"line_number":67,"context_line":"                images.select().where("},{"line_number":68,"context_line":"                    images.c.id.like(\u0027%_before_expand\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e3842854_63ec38fc","line":65,"range":{"start_line":65,"start_character":33,"end_line":65,"end_character":38},"updated":"2021-08-16 12:04:10.000000000","message":"Is there a specific reason why this does not need the conn.begin()?","commit_id":"9e002a77f2131d3594a2a4029a147beaf37f5b17"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ba1a3cc759969aac67d03a93285406125da1f597","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.assertTrue(images.c.visibility.nullable)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # tests visibility set to None for existing images"},{"line_number":65,"context_line":"        with engine.connect() as conn:"},{"line_number":66,"context_line":"            rows \u003d conn.execute("},{"line_number":67,"context_line":"                images.select().where("},{"line_number":68,"context_line":"                    images.c.id.like(\u0027%_before_expand\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"65d1ecba_35915552","line":65,"range":{"start_line":65,"start_character":33,"end_line":65,"end_character":38},"in_reply_to":"e3842854_63ec38fc","updated":"2021-08-16 13:59:27.000000000","message":"The above operations create new rows, which means they need an explicit transaction. This isn\u0027t necessary when we\u0027re simply reading from the database.","commit_id":"9e002a77f2131d3594a2a4029a147beaf37f5b17"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"0cd9e0a057a559cafea3a00dca4f91dfa378c9a4","unresolved":true,"context_lines":[{"line_number":119,"context_line":"            conn.execute(images.insert().values(shared_temp))"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # test visibility is set appropriately by the trigger for new images"},{"line_number":122,"context_line":"        with engine.connect() as conn:"},{"line_number":123,"context_line":"            rows \u003d conn.execute("},{"line_number":124,"context_line":"                images.select().where("},{"line_number":125,"context_line":"                    images.c.id.like(\u0027%_new_to_old\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f97e2a7a_cfea66cf","line":122,"range":{"start_line":122,"start_character":33,"end_line":122,"end_character":37},"updated":"2021-08-16 12:04:10.000000000","message":"ditto","commit_id":"9e002a77f2131d3594a2a4029a147beaf37f5b17"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bad86f615451ad830b47bf8e7c0f919e237f7529","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            conn.execute(images.insert().values(shared_temp))"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # test visibility is set appropriately by the trigger for new images"},{"line_number":122,"context_line":"        with engine.connect() as conn:"},{"line_number":123,"context_line":"            rows \u003d conn.execute("},{"line_number":124,"context_line":"                images.select().where("},{"line_number":125,"context_line":"                    images.c.id.like(\u0027%_new_to_old\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b726b47c_91529b1e","line":122,"range":{"start_line":122,"start_character":33,"end_line":122,"end_character":37},"in_reply_to":"f97e2a7a_cfea66cf","updated":"2021-08-16 13:59:58.000000000","message":"As above","commit_id":"9e002a77f2131d3594a2a4029a147beaf37f5b17"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"0cd9e0a057a559cafea3a00dca4f91dfa378c9a4","unresolved":true,"context_lines":[{"line_number":166,"context_line":"            conn.execute(images.insert().values(shared_temp))"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        # tests visibility is set appropriately by the trigger for new images"},{"line_number":169,"context_line":"        with engine.connect() as conn:"},{"line_number":170,"context_line":"            rows \u003d conn.execute("},{"line_number":171,"context_line":"                images.select().where("},{"line_number":172,"context_line":"                    images.c.id.like(\u0027%_old_to_new\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e6b47041_5d516053","line":169,"range":{"start_line":169,"start_character":33,"end_line":169,"end_character":37},"updated":"2021-08-16 12:04:10.000000000","message":"ditto","commit_id":"9e002a77f2131d3594a2a4029a147beaf37f5b17"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bad86f615451ad830b47bf8e7c0f919e237f7529","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            conn.execute(images.insert().values(shared_temp))"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        # tests visibility is set appropriately by the trigger for new images"},{"line_number":169,"context_line":"        with engine.connect() as conn:"},{"line_number":170,"context_line":"            rows \u003d conn.execute("},{"line_number":171,"context_line":"                images.select().where("},{"line_number":172,"context_line":"                    images.c.id.like(\u0027%_old_to_new\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"739dba36_50e68e0e","line":169,"range":{"start_line":169,"start_character":33,"end_line":169,"end_character":37},"in_reply_to":"e6b47041_5d516053","updated":"2021-08-16 13:59:58.000000000","message":"Here too","commit_id":"9e002a77f2131d3594a2a4029a147beaf37f5b17"}]}
