)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"945df807b6a42ff268601b9ebb0a98c8865af199","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b799b6bd_46711835","updated":"2021-12-13 08:19:11.000000000","message":"Commit message mentions 3 APIs but in code it has only two API policies modified.\nAlso keystone is not dependency for this work!","commit_id":"a995efce3acee81749cb6476f6e0603cdd9f7a0b"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"9f51c8a93dae56be615be99627d31abcc2ca2257","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d363a1f5_ca68f6a0","in_reply_to":"b799b6bd_46711835","updated":"2021-12-13 10:40:12.000000000","message":"Yeah, I just had modified the check string in base.py instead of adding new for modify_member, but in new patch set I have added the new one and moved the older one under deprecated rule.","commit_id":"a995efce3acee81749cb6476f6e0603cdd9f7a0b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"343d5eb1d6ed8f7244b265125941e95a345e9624","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"091f6194_13a3918a","updated":"2023-03-30 06:18:42.000000000","message":"Putting -2 so that this can be highlighted. Once we get satisfactory answers I will change the vote.","commit_id":"55a2297bea9cf57b355a4e988ea56325afc8de9b"}],"glance/policies/image.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"343d5eb1d6ed8f7244b265125941e95a345e9624","unresolved":true,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":192,"context_line":"        name\u003d\"add_member\","},{"line_number":193,"context_line":"        check_str\u003dbase.ADMIN_OR_PROJECT_MANAGER,"},{"line_number":194,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":195,"context_line":"        description\u003d\u0027Create image member\u0027,"},{"line_number":196,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":2,"id":"fb241736_cd3568fb","line":193,"range":{"start_line":193,"start_character":23,"end_line":193,"end_character":47},"updated":"2023-03-30 06:18:42.000000000","message":"I don\u0027t think we can change the default policy without notifying operators or following deprecation policies (2 cycles timeline). Previous occasion we did it (changed from open to all to admin or project member) because we had hardcoded checks in our auth layer to prevent some misuses and hence we didn\u0027t break backward compatibility, but this time we can not do it directly.","commit_id":"55a2297bea9cf57b355a4e988ea56325afc8de9b"}]}
