)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"73d0a2a6e17ad78095ea764d9606a2a9ed8da938","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"17875870_eb5557a5","updated":"2022-01-26 20:11:54.000000000","message":"Nitpicking a bit :) ","commit_id":"ff2a90a24fac13885afab49b96751b0300f826f3"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"acd59b3e39754d67416d5e00d730d4d1c11bbd16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b656b23b_03211a59","updated":"2022-02-02 19:57:13.000000000","message":"Turning my -1 into a +2 after talking to stephenfin","commit_id":"9679ffc46349134082f31b2d67214a567f7e8f32"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"dfa528484137b89731f0943c9b9cfd0af884fd16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"45d9fb2d_494db55b","updated":"2022-02-03 05:00:20.000000000","message":"recheck","commit_id":"9679ffc46349134082f31b2d67214a567f7e8f32"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"774c94266fb871fc8c177417431990975061c9f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c8387805_993e6a63","updated":"2022-01-28 10:32:28.000000000","message":"recheck","commit_id":"9679ffc46349134082f31b2d67214a567f7e8f32"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"77e71365d40c8720b8ddf4390263db163dda9197","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ed15ef5e_7caadd3f","updated":"2022-02-03 06:30:57.000000000","message":"recheck functional test_reload failure","commit_id":"9679ffc46349134082f31b2d67214a567f7e8f32"}],"glance/tests/functional/test_api.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"73d0a2a6e17ad78095ea764d9606a2a9ed8da938","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Version-independent api tests\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import http.client as http_client"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import httplib2"},{"line_number":21,"context_line":"from oslo_serialization import jsonutils"}],"source_content_type":"text/x-python","patch_set":2,"id":"7bf5bbfc_c8c7b401","line":18,"updated":"2022-01-26 20:11:54.000000000","message":"I understand that using an alias helps keeping the patch small, but I\u0027m afraid using \"http_client\" is going to be confusing since everyone is going to use \"http.client\" from the stdlib. Young devs are going to be confused by the underscore, and older^Wexperienced devs will wonder whether we still support Py2. Shouldn\u0027t we s/http_client/http.client/ in this file as well as in glance/tests/functional/test_cache_middleware.py and glance/tests/functional/test_client_exceptions.py?","commit_id":"ff2a90a24fac13885afab49b96751b0300f826f3"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"acd59b3e39754d67416d5e00d730d4d1c11bbd16","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Version-independent api tests\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import http.client as http_client"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import httplib2"},{"line_number":21,"context_line":"from oslo_serialization import jsonutils"}],"source_content_type":"text/x-python","patch_set":2,"id":"31fb889e_0ad88d79","line":18,"in_reply_to":"2af8272f_91af74bf","updated":"2022-02-02 19:57:13.000000000","message":"Oh yeah that makes sense. OK let\u0027s keep this patch as is in order to keep the diff as small as possible :)","commit_id":"ff2a90a24fac13885afab49b96751b0300f826f3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"899aded38746b8ed401c453364eebd3d705fafbf","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Version-independent api tests\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import http.client as http_client"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import httplib2"},{"line_number":21,"context_line":"from oslo_serialization import jsonutils"}],"source_content_type":"text/x-python","patch_set":2,"id":"2af8272f_91af74bf","line":18,"in_reply_to":"7bf5bbfc_c8c7b401","updated":"2022-01-27 11:15:38.000000000","message":"I couldn\u0027t agree more. _However_, there are variables called \u0027http\u0027 in multiple files (including this one) which result in us shadowing the import. I could rename those but that will make this patch even bigger /o\\ wdyt?","commit_id":"ff2a90a24fac13885afab49b96751b0300f826f3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"899aded38746b8ed401c453364eebd3d705fafbf","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # Verify version choices returned."},{"line_number":36,"context_line":"        path \u003d \u0027http://%s:%d\u0027 % (\u0027127.0.0.1\u0027, self.api_port)"},{"line_number":37,"context_line":"        http \u003d httplib2.Http()"},{"line_number":38,"context_line":"        response, content_json \u003d http.request(path, \u0027GET\u0027)"},{"line_number":39,"context_line":"        self.assertEqual(http_client.MULTIPLE_CHOICES, response.status)"},{"line_number":40,"context_line":"        content \u003d jsonutils.loads(content_json.decode())"}],"source_content_type":"text/x-python","patch_set":2,"id":"a655cfc9_29960150","line":37,"updated":"2022-01-27 11:15:38.000000000","message":"e.g. here","commit_id":"ff2a90a24fac13885afab49b96751b0300f826f3"}]}