)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"19d5c44bf28723d7e6a01d8c1ed09d876c477fe8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fa4868e_8065dd42","updated":"2022-01-28 18:15:35.000000000","message":"Correction: the new ironic patch is https://review.opendev.org/c/openstack/ironic/+/826930","commit_id":"c158e0f5674922a364be8b68201e8ed4f3f9d8c2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"26c2e3b9e8a7d692b93f9731d1fd8afc049f21a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0b003540_5f36acdc","updated":"2022-03-08 13:47:22.000000000","message":"LGTM.  The \u0027img_\u0027 prefix makes sense for img_type (and there are a few other img_* properties consumed by nova, and also the image signature verification code uses it, so it\u0027s not a new namespace). The \u0027rootfs_uuid\u0027 has been around for a while and is just now being documented; I don\u0027t see any objection to that one either.\n\nAt some point you might want to consider adding metadefs for these properties (which can make them discoverable and allow you to specify enums for their values).","commit_id":"c158e0f5674922a364be8b68201e8ed4f3f9d8c2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dd236060486c6b934fb852b68f7690b3cd2fdc8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"41ccc03d_e60e1176","updated":"2022-03-09 15:22:38.000000000","message":"We discussed this a bit in IRC. As noted, I really don\u0027t like the language here and I think it\u0027s less applicable to other situations for re-use than it could be. However, this language has been used in ironic for a long time and as such, it\u0027s being documented here.","commit_id":"c158e0f5674922a364be8b68201e8ed4f3f9d8c2"}],"doc/source/admin/useful-image-properties.rst":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"15df6d5efdc235bd4873fdd7873a05d7d67e2fba","unresolved":true,"context_lines":[{"line_number":168,"context_line":"  One of:"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"  - ``whole-disk`` - an image with a partition table embedded."},{"line_number":171,"context_line":"  - ``partition`` - an image with only the root partition without a partition"},{"line_number":172,"context_line":"    table."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"  .. note::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"01df6634_764f135e","line":171,"range":{"start_line":171,"start_character":6,"end_line":171,"end_character":15},"updated":"2022-03-09 15:03:35.000000000","message":"Shouldn\u0027t this be \"filesystem\"? A partition only makes sense as a divisible part of something larger (IMHO). A file with a filesystem in it isn\u0027t a \"partition\", so I\u0027m not sure why glance should act like the only destination for something like this.\n\nI guess for that matter, it seems like you could make this really just the layout, so \"mbr\", \"gpt\", or \"bare\" (which also references container_format)?","commit_id":"c158e0f5674922a364be8b68201e8ed4f3f9d8c2"}]}