)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3ecafce3342bbad2180c2f7f57c5849b17b532ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e76108e1_5a5e2853","updated":"2022-03-01 15:41:39.000000000","message":"@Dan: response inline","commit_id":"20ddece5b64a8d2f091a8ca737f2f2efda5dfab6"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"31973979ae77545e37521944dda298255eb51149","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f55da3cc_d15e5939","updated":"2022-03-01 14:53:59.000000000","message":"Agreed that embedding the sys.executable in *generated* config is not what we want, but that\u0027s just a side-effect of how we generate our configs. For runtime, we actually *do* want sys.executable as the default and it\u0027s not \"too early\", it\u0027s just \"wrong if you have generated the config with a weird value\". So it\u0027d be ideal if we had some way of overriding it for config generation, but I\u0027m not sure that exists.\n\nIf we must have an invalid default for this parameter, then I guess we need a utility method for get_python_interpreter() which returns \"CONF.wsgi.python_interpreter or sys.executable\" but that\u0027s kinda unfortunate.\n\nEither way, setting this to None helps nobody I think, as it will just break wsgi users until they set that to something which is a breaking config change for people with this already deployed.\n","commit_id":"20ddece5b64a8d2f091a8ca737f2f2efda5dfab6"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a2c5b2a7c4c15741eda0a7fe7c8ee1a020767650","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"91a5d21b_bfb3e5e7","updated":"2022-03-01 16:28:20.000000000","message":"This doesn\u0027t work, as shown by the job. We can\u0027t just pass None there, we have to either default it ourselves at runtime, or avoid passing the kwarg altogether.","commit_id":"20ddece5b64a8d2f091a8ca737f2f2efda5dfab6"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"9883786736cfe81e48822fad1a677621863b1dc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"195dde57_20bbeb7c","updated":"2022-03-01 16:05:19.000000000","message":"recheck","commit_id":"20ddece5b64a8d2f091a8ca737f2f2efda5dfab6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"db372ed3960069dc2026bed862153577dc5a8f4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ac6dffc_b3fce14b","updated":"2022-03-01 16:05:14.000000000","message":"recheck nova-ceph-multistore - failed during setup, tempest could not find a valid image","commit_id":"20ddece5b64a8d2f091a8ca737f2f2efda5dfab6"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a210a308769c4214d7ee14850f97df98252266ef","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de1e295b_a9f507a1","in_reply_to":"119b3561_71d00799","updated":"2022-03-01 15:53:37.000000000","message":"Ack, sorry it took a while for me to reload this context from swap:\n\nIn a real wsgi environment, our sys.executable is something like /usr/bin/uwsgi, which does not work for our usage. So we need to override that to something real. To make it not changed for regular environments, we used sys.executable as the default, but perhaps without the thinking that None would also trigger that in the lower layers. Re-reading the help text, it says exactly that :P\n\nSo given that, any people running wsgi now would have to have it overridden to something legit, and others would be taking the default, which will be the same as None after this change.","commit_id":"20ddece5b64a8d2f091a8ca737f2f2efda5dfab6"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"f5e119b0340d90d000590fe7afef7e6e1eb29d48","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2702cbbc_be552487","in_reply_to":"119b3561_71d00799","updated":"2022-03-01 15:54:16.000000000","message":"I agree with Brian here. it does get resolved correctly later if none and changing the default will also not break anyone who is already setting it to custom value. What it does \u0027though is lessen confusion on any situation where the configs are not generated in the same environment as the service is executed.","commit_id":"20ddece5b64a8d2f091a8ca737f2f2efda5dfab6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3ecafce3342bbad2180c2f7f57c5849b17b532ea","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"119b3561_71d00799","in_reply_to":"f55da3cc_d15e5939","updated":"2022-03-01 15:41:39.000000000","message":"For runtime, we actually *are* getting sys.executable as the default if we make this None:\n\nhttps://opendev.org/openstack/oslo.concurrency/src/commit/95b9334cfab6849fbe47e2b118e5355af3675dba/oslo_concurrency/processutils.py#L332\n\nSo I still think we need to make this None-unless-you-have-a-good-reason-to-change-it.","commit_id":"20ddece5b64a8d2f091a8ca737f2f2efda5dfab6"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"0454c72a2e8f4b23fabf76a1cb6c49d320299e6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d5021ea_53a3af81","updated":"2022-03-01 22:19:52.000000000","message":"I\u0027m going to Ninja this in for RC1.","commit_id":"daa602baa900530fbd0a49ad67e7e1b5e0ae9343"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"082061f1bf0a4f858a6b05ef97744b80e7d9a0fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5e0b90d6_4f7f30dc","updated":"2022-03-01 16:54:16.000000000","message":"Thanks Dan, took a while to understand what was wrong with it, but you\u0027re indeed correct here.","commit_id":"daa602baa900530fbd0a49ad67e7e1b5e0ae9343"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"eba12412cb061f0df98ed24a14dd087a53a7d761","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f4eb40ee_595707a6","updated":"2022-03-01 19:49:06.000000000","message":"Thanks, Dan.  Agree with the changes.","commit_id":"daa602baa900530fbd0a49ad67e7e1b5e0ae9343"}]}