)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"eef4af81fb3567955bb39483c4aa251d46de2b27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"403115f1_eb499089","updated":"2022-08-11 21:05:26.000000000","message":"Looks fine.  Question inline about one of the tests (not really related to your change; I\u0027d +2 this except that I want to make sure you read the question).  Feel free to +A this yourself after you\u0027ve read it.","commit_id":"1019cc1f5c7258b9126ef50558f7c41d627db2dd"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4aff9399618d723c291fe268d852ab4d170c42fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1c57cbdd_8c08235c","updated":"2023-02-09 14:15:15.000000000","message":"Ninja approving it,thank you Cyril!","commit_id":"399438cd044f52915e202650db407eccd3e26c95"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9db4232f5bf16c0a453c90e8422e700dd64e16eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5bdb1d35_ccc986c6","updated":"2023-01-16 14:11:58.000000000","message":"We either need to remove this constant check job or this patch https://review.opendev.org/c/openstack/glance/+/861752 to fix this","commit_id":"399438cd044f52915e202650db407eccd3e26c95"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8fe1249557525a178ba51d9fa42ae181eee2c1c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a02e54ed_b2b39acf","updated":"2023-02-15 06:49:52.000000000","message":"recheck error while shelving the instance in nova-ceph-multistore job","commit_id":"399438cd044f52915e202650db407eccd3e26c95"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c5c1dca063f1fb5acdc65ae37d814b6f09bba163","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"947db927_fadf1bb0","updated":"2023-02-15 04:44:45.000000000","message":"recheck grenade failure","commit_id":"399438cd044f52915e202650db407eccd3e26c95"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b59a2ffec4d19b1909fb631d9d2b6afa0e33799c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cce890e6_5f3d7089","updated":"2023-02-15 08:40:41.000000000","message":"recheck nova-multistore failure","commit_id":"399438cd044f52915e202650db407eccd3e26c95"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"556cd0c948d73d5be693d6843794eb43941c1906","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1d6fc3d1_2a158991","updated":"2023-02-16 07:31:45.000000000","message":"recheck this lad keeps refusing to merge 😄","commit_id":"399438cd044f52915e202650db407eccd3e26c95"}],"glance/tests/unit/common/test_utils.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"eef4af81fb3567955bb39483c4aa251d46de2b27","unresolved":true,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_cooperative_reader_of_iterator_stop_iteration_err(self):"},{"line_number":225,"context_line":"        \"\"\"Ensure cooperative reader supports iterator backends too\"\"\""},{"line_number":226,"context_line":"        reader \u003d utils.CooperativeReader([x * 3 for x in \u0027\u0027])"},{"line_number":227,"context_line":"        chunks \u003d []"},{"line_number":228,"context_line":"        while True:"},{"line_number":229,"context_line":"            chunks.append(reader.read(3))"}],"source_content_type":"text/x-python","patch_set":1,"id":"130f4eb7_edf56102","line":226,"range":{"start_line":226,"start_character":41,"end_line":226,"end_character":60},"updated":"2022-08-11 21:05:26.000000000","message":"You have correctly rewritten the expression to eliminate \u0027l\u0027, but my question is why is this here in the first place?  It\u0027s equivalent to [] (and if you replace the expression with [], the test does indeed pass).  It makes me wonder if the test is really testing what the author intended.","commit_id":"1019cc1f5c7258b9126ef50558f7c41d627db2dd"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"ade1afb296006f620070f05088bee1b8aa2f9fe1","unresolved":true,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_cooperative_reader_of_iterator_stop_iteration_err(self):"},{"line_number":225,"context_line":"        \"\"\"Ensure cooperative reader supports iterator backends too\"\"\""},{"line_number":226,"context_line":"        reader \u003d utils.CooperativeReader([x * 3 for x in \u0027\u0027])"},{"line_number":227,"context_line":"        chunks \u003d []"},{"line_number":228,"context_line":"        while True:"},{"line_number":229,"context_line":"            chunks.append(reader.read(3))"}],"source_content_type":"text/x-python","patch_set":1,"id":"c22c0c1c_2eea9d69","line":226,"range":{"start_line":226,"start_character":41,"end_line":226,"end_character":60},"in_reply_to":"130f4eb7_edf56102","updated":"2022-09-14 23:32:56.000000000","message":"Yes, this is quite weird. I think the idea was to make sure the class works when initialized with an \"iterator backend\", but I think there are other tests that check this.\n\nI think we should\n1) Merge this so we don\u0027t have any issues if pycodestyle is ever updated to 2.6.0\n\n2) Revisit this test and fix it or delete it\n\nWhat do you think?","commit_id":"1019cc1f5c7258b9126ef50558f7c41d627db2dd"}]}