)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6bae676cd075bf3e92ba16c8ab351361b7e7239a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"76564576_d39e59ed","updated":"2023-05-04 13:28:58.000000000","message":"Sorry this has taken so long to review.  A few quick changes you can make are noted inline, and then this should be ready to merge.","commit_id":"cf8cafdc17e17dc8c0e826903e283a8a0321c79f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bef7debf5e30e57f679a13ca410b611ec3497919","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bc0c8f3b_332ec699","updated":"2024-09-10 12:18:51.000000000","message":"Added note about this revision to PS1; will add myself as co-author so it\u0027s clear why I\u0027m not voting on this patch.","commit_id":"02857c4831b382bf053ba9605991c807aa09a2cd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e05137db6ff1c424d8a0ca1481bed95de724f7e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"49c81662_74c6c2bd","updated":"2024-09-09 21:27:42.000000000","message":"Even though this is an old patch, it\u0027s worth making the correction.","commit_id":"02857c4831b382bf053ba9605991c807aa09a2cd"}],"api-ref/source/v2/metadefs-namespaces-properties.inc":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6bae676cd075bf3e92ba16c8ab351361b7e7239a","unresolved":true,"context_lines":[{"line_number":76,"context_line":"   - pattern: pattern"},{"line_number":77,"context_line":"   - type: type"},{"line_number":78,"context_line":"   - minLength: minLength"},{"line_number":79,"context_line":"   - name: name"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Response Example"},{"line_number":82,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"020b6bf3_1ad02c77","line":79,"range":{"start_line":79,"start_character":11,"end_line":79,"end_character":15},"updated":"2023-05-04 13:28:58.000000000","message":"Don\u0027t forget to get this one!","commit_id":"cf8cafdc17e17dc8c0e826903e283a8a0321c79f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bef7debf5e30e57f679a13ca410b611ec3497919","unresolved":false,"context_lines":[{"line_number":76,"context_line":"   - pattern: pattern"},{"line_number":77,"context_line":"   - type: type"},{"line_number":78,"context_line":"   - minLength: minLength"},{"line_number":79,"context_line":"   - name: name"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Response Example"},{"line_number":82,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"ad63c411_e606cb18","line":79,"range":{"start_line":79,"start_character":11,"end_line":79,"end_character":15},"in_reply_to":"020b6bf3_1ad02c77","updated":"2024-09-10 12:18:51.000000000","message":"Done","commit_id":"cf8cafdc17e17dc8c0e826903e283a8a0321c79f"}],"api-ref/source/v2/metadefs-parameters.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6bae676cd075bf3e92ba16c8ab351361b7e7239a","unresolved":true,"context_lines":[{"line_number":258,"context_line":"  in: body"},{"line_number":259,"context_line":"  required: false"},{"line_number":260,"context_line":"  type: string"},{"line_number":261,"context_line":"name-in-request:"},{"line_number":262,"context_line":"  description: |"},{"line_number":263,"context_line":"    The name of the property."},{"line_number":264,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"baac42b6_293602d7","line":261,"range":{"start_line":261,"start_character":8,"end_line":261,"end_character":15},"updated":"2023-05-04 13:28:58.000000000","message":"Maybe call this \u0027name-in-body\u0027, because you\u0027ll want to use it for the response, too.","commit_id":"cf8cafdc17e17dc8c0e826903e283a8a0321c79f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bef7debf5e30e57f679a13ca410b611ec3497919","unresolved":true,"context_lines":[{"line_number":258,"context_line":"  in: body"},{"line_number":259,"context_line":"  required: false"},{"line_number":260,"context_line":"  type: string"},{"line_number":261,"context_line":"name-in-request:"},{"line_number":262,"context_line":"  description: |"},{"line_number":263,"context_line":"    The name of the property."},{"line_number":264,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3e4d50b8_0059af00","line":261,"range":{"start_line":261,"start_character":8,"end_line":261,"end_character":15},"in_reply_to":"baac42b6_293602d7","updated":"2024-09-10 12:18:51.000000000","message":"Turns out that we don\u0027t need to define a new parameter, we already have name-property defined at lines 267-272 to handle this situation.","commit_id":"cf8cafdc17e17dc8c0e826903e283a8a0321c79f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6bae676cd075bf3e92ba16c8ab351361b7e7239a","unresolved":true,"context_lines":[{"line_number":260,"context_line":"  type: string"},{"line_number":261,"context_line":"name-in-request:"},{"line_number":262,"context_line":"  description: |"},{"line_number":263,"context_line":"    The name of the property."},{"line_number":264,"context_line":"  in: body"},{"line_number":265,"context_line":"  required: true"},{"line_number":266,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9b7be46c_ad6dab56","line":263,"updated":"2023-05-04 13:28:58.000000000","message":"I think you should include the 80 char length limitation mentioned in the \"old\" string:\nhttps://opendev.org/openstack/glance/src/branch/master/glance/db/sqlalchemy/models_metadef.py#L114","commit_id":"cf8cafdc17e17dc8c0e826903e283a8a0321c79f"}]}