)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"f456cb62dfffb35823272019a748d6881d9ef660","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"856d6c5f_02d27b6b","updated":"2022-11-14 16:49:35.000000000","message":"I\u0027m not sure about that. I understand this would have helped with the issue fixed in the previous commit, but aren\u0027t we going to end up just putting every single assignment in a try/except? :) \n\nI think ensuring that virtual_size() always returns a value instead of raising an exception should be enough. Any thoughts?","commit_id":"fa820c027cd39286a73b49b92ed4869815460c90"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6a92cbda78a021cf67081c4b538634fbcf39a080","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"506cb840_76572c9f","updated":"2022-11-15 03:10:16.000000000","message":"Looks good,just one question inline.","commit_id":"fa820c027cd39286a73b49b92ed4869815460c90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b7c4e39c502bb0d342d672e3e0042ca923d6a0be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bee80675_8f9f66b9","in_reply_to":"856d6c5f_02d27b6b","updated":"2022-11-14 17:22:01.000000000","message":"Well, it\u0027s supposed to, but you see what happened in the previous patch. I think if we had more \"nice to have but not critical\" attributes than just virtual_size, we\u0027d put them all in the same try..except so it wouldn\u0027t be much more work. There are also potentially things we might want to scrape out of the stream that we *do* want to interrupt the transfer.\n\nBut, I put this as a separate patch to keep it separate for a reason, so I can drop this one if preferred.","commit_id":"fa820c027cd39286a73b49b92ed4869815460c90"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ac28a18685c4a5d46b781cee5b40da2a9a6800f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"943a6d71_3bdbad48","updated":"2022-11-15 20:05:35.000000000","message":"Looks good to me, thank you!","commit_id":"6bb241fc3b8756fd80dbf37d66daafe05903e032"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"2f9153a296c4783222829aaf0b719e8f16ab0f30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"beae13ef_89d3d07c","updated":"2023-02-15 15:23:51.000000000","message":"Hm, ok, 3 months later this seems reasonable to me, so let\u0027s merge this.","commit_id":"943124ed6c0f2e8caf9ceb296174e71b47fc6f4f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9e7f30f682a4d9656c95dfd07710747fd56bad64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6207d3fc_11e5dce2","updated":"2023-02-15 17:49:20.000000000","message":"recheck server error","commit_id":"943124ed6c0f2e8caf9ceb296174e71b47fc6f4f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"956896027f10eca067a43b9ff8ee1f0908b34e8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a0df4f68_d69c079f","updated":"2022-11-16 17:09:23.000000000","message":"thank you!","commit_id":"943124ed6c0f2e8caf9ceb296174e71b47fc6f4f"}],"glance/location.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6a92cbda78a021cf67081c4b538634fbcf39a080","unresolved":true,"context_lines":[{"line_number":587,"context_line":"        virtual_size \u003d 0"},{"line_number":588,"context_line":"        if fmt and fmt.format_match:"},{"line_number":589,"context_line":"            try:"},{"line_number":590,"context_line":"                virtual_size \u003d fmt.virtual_size"},{"line_number":591,"context_line":"                LOG.info(\u0027Image format matched and virtual size computed: %i\u0027,"},{"line_number":592,"context_line":"                         virtual_size)"},{"line_number":593,"context_line":"            except Exception as e:"},{"line_number":594,"context_line":"                LOG.error(\u0027Unable to determine virtual_size because: %s\u0027,"},{"line_number":595,"context_line":"                          e)"},{"line_number":596,"context_line":"        elif fmt:"},{"line_number":597,"context_line":"            LOG.warning(\u0027Image format %s did not match; \u0027"},{"line_number":598,"context_line":"                        \u0027unable to calculate virtual size\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ac8a104_88fdb75c","line":595,"range":{"start_line":590,"start_character":16,"end_line":595,"end_character":28},"updated":"2022-11-15 03:10:16.000000000","message":"This may be caught earlier, but is translation not used anymore or its just a not used here?\n\n_LI, _LE ?","commit_id":"fa820c027cd39286a73b49b92ed4869815460c90"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ac28a18685c4a5d46b781cee5b40da2a9a6800f1","unresolved":false,"context_lines":[{"line_number":587,"context_line":"        virtual_size \u003d 0"},{"line_number":588,"context_line":"        if fmt and fmt.format_match:"},{"line_number":589,"context_line":"            try:"},{"line_number":590,"context_line":"                virtual_size \u003d fmt.virtual_size"},{"line_number":591,"context_line":"                LOG.info(\u0027Image format matched and virtual size computed: %i\u0027,"},{"line_number":592,"context_line":"                         virtual_size)"},{"line_number":593,"context_line":"            except Exception as e:"},{"line_number":594,"context_line":"                LOG.error(\u0027Unable to determine virtual_size because: %s\u0027,"},{"line_number":595,"context_line":"                          e)"},{"line_number":596,"context_line":"        elif fmt:"},{"line_number":597,"context_line":"            LOG.warning(\u0027Image format %s did not match; \u0027"},{"line_number":598,"context_line":"                        \u0027unable to calculate virtual size\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e9666832_68be543d","line":595,"range":{"start_line":590,"start_character":16,"end_line":595,"end_character":28},"in_reply_to":"0e75a2b2_915a893d","updated":"2022-11-15 20:05:35.000000000","message":"_LI is optional!","commit_id":"fa820c027cd39286a73b49b92ed4869815460c90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"343d876bd66a018799e814adf6957e8981aaad65","unresolved":true,"context_lines":[{"line_number":587,"context_line":"        virtual_size \u003d 0"},{"line_number":588,"context_line":"        if fmt and fmt.format_match:"},{"line_number":589,"context_line":"            try:"},{"line_number":590,"context_line":"                virtual_size \u003d fmt.virtual_size"},{"line_number":591,"context_line":"                LOG.info(\u0027Image format matched and virtual size computed: %i\u0027,"},{"line_number":592,"context_line":"                         virtual_size)"},{"line_number":593,"context_line":"            except Exception as e:"},{"line_number":594,"context_line":"                LOG.error(\u0027Unable to determine virtual_size because: %s\u0027,"},{"line_number":595,"context_line":"                          e)"},{"line_number":596,"context_line":"        elif fmt:"},{"line_number":597,"context_line":"            LOG.warning(\u0027Image format %s did not match; \u0027"},{"line_number":598,"context_line":"                        \u0027unable to calculate virtual size\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0e75a2b2_915a893d","line":595,"range":{"start_line":590,"start_character":16,"end_line":595,"end_character":28},"in_reply_to":"9ac8a104_88fdb75c","updated":"2022-11-15 14:29:30.000000000","message":"Nope, just forgot it here.","commit_id":"fa820c027cd39286a73b49b92ed4869815460c90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2cd32381dcbcd8416d68293515f31b67cec1be1a","unresolved":false,"context_lines":[{"line_number":587,"context_line":"        virtual_size \u003d 0"},{"line_number":588,"context_line":"        if fmt and fmt.format_match:"},{"line_number":589,"context_line":"            try:"},{"line_number":590,"context_line":"                virtual_size \u003d fmt.virtual_size"},{"line_number":591,"context_line":"                LOG.info(\u0027Image format matched and virtual size computed: %i\u0027,"},{"line_number":592,"context_line":"                         virtual_size)"},{"line_number":593,"context_line":"            except Exception as e:"},{"line_number":594,"context_line":"                LOG.error(\u0027Unable to determine virtual_size because: %s\u0027,"},{"line_number":595,"context_line":"                          e)"},{"line_number":596,"context_line":"        elif fmt:"},{"line_number":597,"context_line":"            LOG.warning(\u0027Image format %s did not match; \u0027"},{"line_number":598,"context_line":"                        \u0027unable to calculate virtual size\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f74c316b_cc0ded8e","line":595,"range":{"start_line":590,"start_character":16,"end_line":595,"end_character":28},"in_reply_to":"e9666832_68be543d","updated":"2022-11-15 21:15:42.000000000","message":"Well, and that code was there so I didn\u0027t change it here, other than indenting :)","commit_id":"fa820c027cd39286a73b49b92ed4869815460c90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e0f74693d054602e949674001b3f6849864aadda","unresolved":true,"context_lines":[{"line_number":592,"context_line":"                         virtual_size)"},{"line_number":593,"context_line":"            except Exception as e:"},{"line_number":594,"context_line":"                LOG.error(_LE(\u0027Unable to determine virtual_size because: %s\u0027,"},{"line_number":595,"context_line":"                              e))"},{"line_number":596,"context_line":"        elif fmt:"},{"line_number":597,"context_line":"            LOG.warning(\u0027Image format %s did not match; \u0027"},{"line_number":598,"context_line":"                        \u0027unable to calculate virtual size\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7d037aca_b3f82dc9","line":595,"range":{"start_line":595,"start_character":0,"end_line":595,"end_character":33},"updated":"2022-11-15 21:25:42.000000000","message":"Whoops, I got my parens wrong.","commit_id":"6bb241fc3b8756fd80dbf37d66daafe05903e032"}]}