)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a26f82a8405e7634d87014eb9baacf7ac9cf8d62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a5889ccf_49b6f85e","updated":"2023-01-26 19:00:50.000000000","message":"A couple things inline, but I\u0027m sure this is a good idea. We should also add test coverage for this.","commit_id":"249bc83f1745c49ef4d087960bee258598d8662b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"af46d6d1d3b5d22eda5de2ca0d8dcb43ddfc5ee7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a151543b_b1e8e17f","updated":"2023-01-26 19:01:09.000000000","message":"Oops, meant to -1 fro the lack of tests at least.","commit_id":"249bc83f1745c49ef4d087960bee258598d8662b"},{"author":{"_account_id":9642,"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","username":"quatre"},"change_message_id":"1bd3f053d757630336a2dc6577daf952e437e8e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0bd745c8_3f9d2099","in_reply_to":"a5889ccf_49b6f85e","updated":"2023-01-27 09:16:32.000000000","message":"I am not sure but I think I can come-up with a small test for VMDK because it\u0027s a matter of changing a byte in a file. For VHDX however I don\u0027t think I will have time to do something significant in terms of tests.","commit_id":"249bc83f1745c49ef4d087960bee258598d8662b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4e961b7252338f0c9b4bda7a27f0dc11d9f88a48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d44cf5a_7ee5738c","updated":"2023-02-02 05:45:14.000000000","message":"Looks good to me\nIs this termed as enhancement or we should report a bug and backport it as well?","commit_id":"f15e5119ee9197c7ef4304fd0af985ea80fba75d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d9928d0b8639f3445cd1dec3b34f85e1fdeaee88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba050eb1_082f9597","in_reply_to":"9d44cf5a_7ee5738c","updated":"2023-02-02 14:53:12.000000000","message":"It\u0027s a bug. I\u0027m good with the vmdk stuff, but I\u0027d like to see a VHD test of some sort. I haven\u0027t had a chance to dig into this  with everything going on lately, but maybe Abhi you could come up with something? If not, I can try to look at it next week.","commit_id":"f15e5119ee9197c7ef4304fd0af985ea80fba75d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c82453ce40ce1006babc823d32f209fee2c1c66c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"012b2aab_01d48372","in_reply_to":"ba050eb1_082f9597","updated":"2023-02-02 14:57:25.000000000","message":"Ack, will try to find out some time tomorrow!","commit_id":"f15e5119ee9197c7ef4304fd0af985ea80fba75d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"694ad9372f656994aebffed467aaa7fc9310f3a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5a98abee_02dbbda8","updated":"2023-02-06 18:19:19.000000000","message":"Abhi, I didn\u0027t merge this because I thought we were going to file a bug. I just didn\u0027t get to it on Friday. Perhaps we should still do that so we can backport this?","commit_id":"d4d33ee30f303f783c0640cd72acb31b313e1164"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e3ef2457cedb2fbc6a45efd771cfbf65e6f952c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8a72a286_4537e96f","updated":"2023-02-03 16:04:41.000000000","message":"I just added a test for the VHDX case.","commit_id":"d4d33ee30f303f783c0640cd72acb31b313e1164"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6fd6de92c75ee3886761ae7fb96dd0fcf9b268c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9effed02_0bfff31d","updated":"2023-02-06 07:05:59.000000000","message":"recheck grenade failure","commit_id":"d4d33ee30f303f783c0640cd72acb31b313e1164"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2ef630924e1b3dfbdefd2fef470ee1be1def4faa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bf7b7da0_e60d644e","in_reply_to":"5a98abee_02dbbda8","updated":"2023-02-06 18:29:07.000000000","message":"Sorry, I missed that part. Yes we can report a bug and include that in backport patches.","commit_id":"d4d33ee30f303f783c0640cd72acb31b313e1164"}],"glance/common/format_inspector.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a26f82a8405e7634d87014eb9baacf7ac9cf8d62","unresolved":true,"context_lines":[{"line_number":547,"context_line":"        # is similar to how it\u0027s done in qemu."},{"line_number":548,"context_line":"        desc_offset \u003d desc_sec * 512"},{"line_number":549,"context_line":"        desc_size \u003d min(desc_num * 512, (1 \u003c\u003c 20) - 1)"},{"line_number":550,"context_line":"        if desc_offset !\u003d 0x200:"},{"line_number":551,"context_line":"            raise ImageFormatError(\"Wrong descriptor location\")"},{"line_number":552,"context_line":"            return"},{"line_number":553,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a9d96745_feb7feb3","line":550,"range":{"start_line":550,"start_character":26,"end_line":550,"end_character":31},"updated":"2023-01-26 19:00:50.000000000","message":"Where does 0x200 come from?","commit_id":"249bc83f1745c49ef4d087960bee258598d8662b"},{"author":{"_account_id":9642,"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","username":"quatre"},"change_message_id":"1bd3f053d757630336a2dc6577daf952e437e8e3","unresolved":false,"context_lines":[{"line_number":547,"context_line":"        # is similar to how it\u0027s done in qemu."},{"line_number":548,"context_line":"        desc_offset \u003d desc_sec * 512"},{"line_number":549,"context_line":"        desc_size \u003d min(desc_num * 512, (1 \u003c\u003c 20) - 1)"},{"line_number":550,"context_line":"        if desc_offset !\u003d 0x200:"},{"line_number":551,"context_line":"            raise ImageFormatError(\"Wrong descriptor location\")"},{"line_number":552,"context_line":"            return"},{"line_number":553,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9d84d868_f9fefc53","line":550,"range":{"start_line":550,"start_character":26,"end_line":550,"end_character":31},"in_reply_to":"a9d96745_feb7feb3","updated":"2023-01-27 09:16:32.000000000","message":"This is the offset of the beginning of the descriptor as hard-coded in qemu, I will reflect that with a comment. We also should keep this, lest someone could craft an image where the inspector and qemu may read different descriptors.","commit_id":"249bc83f1745c49ef4d087960bee258598d8662b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a26f82a8405e7634d87014eb9baacf7ac9cf8d62","unresolved":true,"context_lines":[{"line_number":549,"context_line":"        desc_size \u003d min(desc_num * 512, (1 \u003c\u003c 20) - 1)"},{"line_number":550,"context_line":"        if desc_offset !\u003d 0x200:"},{"line_number":551,"context_line":"            raise ImageFormatError(\"Wrong descriptor location\")"},{"line_number":552,"context_line":"            return"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"        if not self.has_region(\u0027descriptor\u0027):"},{"line_number":555,"context_line":"            self.new_region(\u0027descriptor\u0027, CaptureRegion("}],"source_content_type":"text/x-python","patch_set":1,"id":"66ebea88_183758dc","line":552,"updated":"2023-01-26 19:00:50.000000000","message":"This return never gets run, you can just remove it.","commit_id":"249bc83f1745c49ef4d087960bee258598d8662b"},{"author":{"_account_id":9642,"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","username":"quatre"},"change_message_id":"1bd3f053d757630336a2dc6577daf952e437e8e3","unresolved":false,"context_lines":[{"line_number":549,"context_line":"        desc_size \u003d min(desc_num * 512, (1 \u003c\u003c 20) - 1)"},{"line_number":550,"context_line":"        if desc_offset !\u003d 0x200:"},{"line_number":551,"context_line":"            raise ImageFormatError(\"Wrong descriptor location\")"},{"line_number":552,"context_line":"            return"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"        if not self.has_region(\u0027descriptor\u0027):"},{"line_number":555,"context_line":"            self.new_region(\u0027descriptor\u0027, CaptureRegion("}],"source_content_type":"text/x-python","patch_set":1,"id":"882c62fd_111a6255","line":552,"in_reply_to":"66ebea88_183758dc","updated":"2023-01-27 09:16:32.000000000","message":"That is what I think too, but previous similar conditions in the VMDKInspector were built with this construct.","commit_id":"249bc83f1745c49ef4d087960bee258598d8662b"}]}