)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4d7f0e7f98013ec6c2d05ed1c99bae7cc1cfff39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f5be1049_f32835b4","updated":"2023-02-02 06:02:37.000000000","message":"I guess best way is to break this patch into multiple small patches which will be easier for reviewers to review as well.\n\nYou can do it as follow;\n1. Remove unnecessary unit tests\n2. Migrate existing unit tests to use multistore (Again this can be divided in multiple patches)\n3. Remove unnecessary functional tests\n4. Migrate existing functional tests to use multistore (Again this can be divided in multiple patches)\n5. In the end remove dead code related to single store from actual code base.","commit_id":"81f98764e5dab1503f5adde954acbd1280f8ea76"}],"glance/api/v2/image_data.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4d7f0e7f98013ec6c2d05ed1c99bae7cc1cfff39","unresolved":true,"context_lines":[{"line_number":99,"context_line":"                                \"[Errno %(en)d]\"), {\u0027fn\u0027: file_path,"},{"line_number":100,"context_line":"                                                    \u0027en\u0027: e.errno})"},{"line_number":101,"context_line":"            else:"},{"line_number":102,"context_line":"                LOG.warning(_(\"Staged image data not found \""},{"line_number":103,"context_line":"                              \"at %(fn)s\"), {\u0027fn\u0027: file_path})"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self._restore(image_repo, image)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"62950080_16fbb0be","side":"PARENT","line":103,"range":{"start_line":102,"start_character":16,"end_line":103,"end_character":62},"updated":"2023-02-02 06:02:37.000000000","message":"I think you should shift this log warning in except block","commit_id":"907c56265438da43c13bf1a3369d5459b1267e34"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4d7f0e7f98013ec6c2d05ed1c99bae7cc1cfff39","unresolved":true,"context_lines":[{"line_number":313,"context_line":"            # enabled"},{"line_number":314,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.msg)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        # NOTE(jokke): this is horrible way to do it but as long as"},{"line_number":317,"context_line":"        # glance_store is in a shape it is, the only way. Don\u0027t hold me"},{"line_number":318,"context_line":"        # accountable for it."},{"line_number":319,"context_line":"        # TODO(abhishekk): After removal of backend module from glance_store"},{"line_number":320,"context_line":"        # need to change this to use multi_backend module."},{"line_number":321,"context_line":"        def _build_staging_store():"},{"line_number":322,"context_line":"            conf \u003d cfg.ConfigOpts()"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"            try:"},{"line_number":325,"context_line":"                multi_backend.register_opts(conf)"},{"line_number":326,"context_line":"            except cfg.DuplicateOptError:"},{"line_number":327,"context_line":"                pass"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"            conf.set_override(\u0027filesystem_store_datadir\u0027,"},{"line_number":330,"context_line":"                              CONF.node_staging_uri[7:],"},{"line_number":331,"context_line":"                              group\u003d\u0027glance_store\u0027)"},{"line_number":332,"context_line":"            staging_store \u003d backend._load_store(conf, \u0027file\u0027)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"            try:"},{"line_number":335,"context_line":"                staging_store.configure()"},{"line_number":336,"context_line":"            except AttributeError:"},{"line_number":337,"context_line":"                msg \u003d _(\"\u0027node_staging_uri\u0027 is not set correctly. Could not \""},{"line_number":338,"context_line":"                        \"load staging store.\")"},{"line_number":339,"context_line":"                raise exception.BadStoreUri(message\u003dmsg)"},{"line_number":340,"context_line":"            return staging_store"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        # NOTE(abhishekk): Use reserved \u0027os_glance_staging_store\u0027 for staging"},{"line_number":343,"context_line":"        # the data, the else part will be removed once multiple backend feature"}],"source_content_type":"text/x-python","patch_set":1,"id":"469ccf0e_036a8977","line":340,"range":{"start_line":316,"start_character":8,"end_line":340,"end_character":32},"updated":"2023-02-02 06:02:37.000000000","message":"You need to remove this entire method, I have added that comment when we didn\u0027t had reserved stores for staging, now since we do have, this needs to be removed entirely.","commit_id":"81f98764e5dab1503f5adde954acbd1280f8ea76"}],"glance/api/v2/images.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4d7f0e7f98013ec6c2d05ed1c99bae7cc1cfff39","unresolved":true,"context_lines":[{"line_number":899,"context_line":"                            \"[Errno %(en)d]\", {\u0027fn\u0027: file_path,"},{"line_number":900,"context_line":"                                               \u0027en\u0027: e.errno})"},{"line_number":901,"context_line":"                else:"},{"line_number":902,"context_line":"                    LOG.warning(_("},{"line_number":903,"context_line":"                        \"After upload to backend, deletion of staged \""},{"line_number":904,"context_line":"                        \"image data has failed because \""},{"line_number":905,"context_line":"                        \"it cannot be found at %(fn)s\"), {\u0027fn\u0027: file_path})"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"            image.delete()"},{"line_number":908,"context_line":"            self._delete_encryption_key(req.context, image)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0019e1b6_5453bcf8","side":"PARENT","line":905,"range":{"start_line":902,"start_character":20,"end_line":905,"end_character":75},"updated":"2023-02-02 06:02:37.000000000","message":"ditto","commit_id":"907c56265438da43c13bf1a3369d5459b1267e34"}],"glance/api/versions.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4d7f0e7f98013ec6c2d05ed1c99bae7cc1cfff39","unresolved":true,"context_lines":[{"line_number":96,"context_line":"                build_version_object(2.9, \u0027v2\u0027, \u0027SUPPORTED\u0027),"},{"line_number":97,"context_line":"                build_version_object(2.8, \u0027v2\u0027, \u0027SUPPORTED\u0027),"},{"line_number":98,"context_line":"            ])"},{"line_number":99,"context_line":"        else:"},{"line_number":100,"context_line":"            version_objs.extend(["},{"line_number":101,"context_line":"                build_version_object(2.9, \u0027v2\u0027, \u0027SUPPORTED\u0027),"},{"line_number":102,"context_line":"            ])"},{"line_number":103,"context_line":"        version_objs.extend(["},{"line_number":104,"context_line":"            build_version_object(2.7, \u0027v2\u0027, \u0027SUPPORTED\u0027),"},{"line_number":105,"context_line":"            build_version_object(2.6, \u0027v2\u0027, \u0027SUPPORTED\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"e770ea8e_ec82d5c4","side":"PARENT","line":102,"range":{"start_line":99,"start_character":8,"end_line":102,"end_character":14},"updated":"2023-02-02 06:02:37.000000000","message":"I guess this will stay as it is","commit_id":"907c56265438da43c13bf1a3369d5459b1267e34"}]}