)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"243ba18180df921bac3742d975d4f7cad43c815b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-07-20 17:27:35 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: Use WarningFixture in all tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I3e2227a01628f8f5d14d4b4ebf11a9374b52c228"},{"line_number":10,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f5a5163e_dbe02e9a","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":25},"updated":"2023-07-21 15:27:08.000000000","message":"Typo: it\u0027s WarningsFixture, plural.","commit_id":"de683a2a039d0578529dd33f080df9119b32fa16"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c91e60cd81d198a1e4dc3300939a6cdd17e7acb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-07-20 17:27:35 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: Use WarningFixture in all tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I3e2227a01628f8f5d14d4b4ebf11a9374b52c228"},{"line_number":10,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7dbbbc05_6830be27","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":25},"in_reply_to":"f5a5163e_dbe02e9a","updated":"2023-07-24 16:16:49.000000000","message":"Done","commit_id":"de683a2a039d0578529dd33f080df9119b32fa16"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29fddcf8801b6ab2d4ab6aa69d4a27d160216cee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"293f4e78_7dac8ff0","updated":"2023-07-20 14:23:23.000000000","message":"Ugh, I forgot to run pep8 😭 Where is pre-commit when you need it","commit_id":"af819043e23658add7f8be23b185a267a7ffd0d1"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"243ba18180df921bac3742d975d4f7cad43c815b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d6e0ce66_ba94654f","updated":"2023-07-21 15:27:08.000000000","message":"Thanks for taking care of this, a suggestion inside :)","commit_id":"de683a2a039d0578529dd33f080df9119b32fa16"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"bbf58cfb74946c66681186388e81b8d6aa7f1b99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a520822f_b9dd434e","updated":"2023-08-08 08:04:14.000000000","message":"It would have been better if we moved those 3 lines of fixtures code in common method and called that method from respective locations.","commit_id":"dc20d4a2a24df072d4a4bcb3277831dbd3aed650"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"49e024e6af9ceb851da2f3bdefa416cf1be7b7f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a1d9fd73_35388a9b","updated":"2023-07-25 13:48:30.000000000","message":"Regarding the refactoring: fair enough, let\u0027s do it later:)","commit_id":"dc20d4a2a24df072d4a4bcb3277831dbd3aed650"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"95e9d96fe284172a80966caedd7eb065e61e66ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"25118773_07ff0511","updated":"2023-08-08 05:42:07.000000000","message":"Thanks!","commit_id":"dc20d4a2a24df072d4a4bcb3277831dbd3aed650"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3ea063e949defad3fe79589430f2fa742b4f3276","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6fea852f_55de9eff","updated":"2023-08-09 05:55:24.000000000","message":"recheck\nopenstacksdk-functional-devstack timeout clearly not related","commit_id":"dc20d4a2a24df072d4a4bcb3277831dbd3aed650"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8f65e4464584f5847a86e8d8480f3d2865908bb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"87d9237b_a336e617","updated":"2023-07-24 21:30:56.000000000","message":"recheck unrelated functional test failure","commit_id":"dc20d4a2a24df072d4a4bcb3277831dbd3aed650"}],"glance/tests/unit/api/test_common.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"243ba18180df921bac3742d975d4f7cad43c815b","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Make sure logging output is limited but still test debug formatting"},{"line_number":53,"context_line":"        self.useFixture(log_fixture.get_logging_handle_error_fixture())"},{"line_number":54,"context_line":"        self.useFixture(glance_fixtures.StandardLogging())"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _get_image_metadata(self):"},{"line_number":57,"context_line":"        return {\u0027id\u0027: \u0027e31cb99c-fe89-49fb-9cc5-f5104fffa636\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a09ff2e_355ed5c4","line":54,"range":{"start_line":54,"start_character":24,"end_line":54,"end_character":55},"updated":"2023-07-21 15:27:08.000000000","message":"This looks like a c/c from glance/tests/utils.py. Couldn\u0027t we move this to a base class and have all our test classes inherit from it?","commit_id":"de683a2a039d0578529dd33f080df9119b32fa16"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c91e60cd81d198a1e4dc3300939a6cdd17e7acb","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Make sure logging output is limited but still test debug formatting"},{"line_number":53,"context_line":"        self.useFixture(log_fixture.get_logging_handle_error_fixture())"},{"line_number":54,"context_line":"        self.useFixture(glance_fixtures.StandardLogging())"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _get_image_metadata(self):"},{"line_number":57,"context_line":"        return {\u0027id\u0027: \u0027e31cb99c-fe89-49fb-9cc5-f5104fffa636\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"e5e3f4d8_1f307b40","line":54,"range":{"start_line":54,"start_character":24,"end_line":54,"end_character":55},"in_reply_to":"7a09ff2e_355ed5c4","updated":"2023-07-24 16:16:49.000000000","message":"I\u0027d rather do that separately, to be honest. This base class doesn\u0027t exist yet and we probably want to give some though to what should be included (see nova\u0027s `nova.test.TestCase` for example)","commit_id":"de683a2a039d0578529dd33f080df9119b32fa16"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"243ba18180df921bac3742d975d4f7cad43c815b","unresolved":true,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # Make sure logging output is limited but still test debug formatting"},{"line_number":152,"context_line":"        self.useFixture(log_fixture.get_logging_handle_error_fixture())"},{"line_number":153,"context_line":"        self.useFixture(glance_fixtures.StandardLogging())"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @mock.patch(\u0027glance.async_.get_threadpool_model\u0027)"},{"line_number":156,"context_line":"    def test_get_thread_pool(self, mock_gtm):"}],"source_content_type":"text/x-python","patch_set":2,"id":"663b8e0d_d553b3a8","line":153,"range":{"start_line":153,"start_character":24,"end_line":153,"end_character":55},"updated":"2023-07-21 15:27:08.000000000","message":"Ditto","commit_id":"de683a2a039d0578529dd33f080df9119b32fa16"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c91e60cd81d198a1e4dc3300939a6cdd17e7acb","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # Make sure logging output is limited but still test debug formatting"},{"line_number":152,"context_line":"        self.useFixture(log_fixture.get_logging_handle_error_fixture())"},{"line_number":153,"context_line":"        self.useFixture(glance_fixtures.StandardLogging())"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @mock.patch(\u0027glance.async_.get_threadpool_model\u0027)"},{"line_number":156,"context_line":"    def test_get_thread_pool(self, mock_gtm):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fee7e981_944720f4","line":153,"range":{"start_line":153,"start_character":24,"end_line":153,"end_character":55},"in_reply_to":"663b8e0d_d553b3a8","updated":"2023-07-24 16:16:49.000000000","message":"Per above","commit_id":"de683a2a039d0578529dd33f080df9119b32fa16"}],"glance/tests/unit/common/test_client.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"243ba18180df921bac3742d975d4f7cad43c815b","unresolved":true,"context_lines":[{"line_number":28,"context_line":"class TestClient(testtools.TestCase):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(TestClient, self).setUp()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        self.endpoint \u003d \u0027example.com\u0027"},{"line_number":34,"context_line":"        self.client \u003d client.BaseClient(self.endpoint, port\u003d9191,"}],"source_content_type":"text/x-python","patch_set":2,"id":"428f3215_b0b4283c","line":31,"range":{"start_line":31,"start_character":32,"end_line":31,"end_character":37},"updated":"2023-07-21 15:27:08.000000000","message":"Please remove the new empty line.","commit_id":"de683a2a039d0578529dd33f080df9119b32fa16"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c91e60cd81d198a1e4dc3300939a6cdd17e7acb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class TestClient(testtools.TestCase):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(TestClient, self).setUp()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        self.endpoint \u003d \u0027example.com\u0027"},{"line_number":34,"context_line":"        self.client \u003d client.BaseClient(self.endpoint, port\u003d9191,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a244450a_07b88d62","line":31,"range":{"start_line":31,"start_character":32,"end_line":31,"end_character":37},"in_reply_to":"428f3215_b0b4283c","updated":"2023-07-24 16:16:49.000000000","message":"Done","commit_id":"de683a2a039d0578529dd33f080df9119b32fa16"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"243ba18180df921bac3742d975d4f7cad43c815b","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        # Make sure logging output is limited but still test debug formatting"},{"line_number":41,"context_line":"        self.useFixture(log_fixture.get_logging_handle_error_fixture())"},{"line_number":42,"context_line":"        self.useFixture(glance_fixtures.StandardLogging())"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_make_auth_plugin(self):"},{"line_number":45,"context_line":"        creds \u003d {\u0027strategy\u0027: \u0027keystone\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"35eb43c2_ca22f6a1","line":42,"range":{"start_line":42,"start_character":24,"end_line":42,"end_character":55},"updated":"2023-07-21 15:27:08.000000000","message":"Ditto","commit_id":"de683a2a039d0578529dd33f080df9119b32fa16"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c91e60cd81d198a1e4dc3300939a6cdd17e7acb","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        # Make sure logging output is limited but still test debug formatting"},{"line_number":41,"context_line":"        self.useFixture(log_fixture.get_logging_handle_error_fixture())"},{"line_number":42,"context_line":"        self.useFixture(glance_fixtures.StandardLogging())"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_make_auth_plugin(self):"},{"line_number":45,"context_line":"        creds \u003d {\u0027strategy\u0027: \u0027keystone\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"432ff405_29162266","line":42,"range":{"start_line":42,"start_character":24,"end_line":42,"end_character":55},"in_reply_to":"35eb43c2_ca22f6a1","updated":"2023-07-24 16:16:49.000000000","message":"Also ditto","commit_id":"de683a2a039d0578529dd33f080df9119b32fa16"}],"glance/tests/unit/test_cache_middleware.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"243ba18180df921bac3742d975d4f7cad43c815b","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # Make sure logging output is limited but still test debug formatting"},{"line_number":71,"context_line":"        self.useFixture(log_fixture.get_logging_handle_error_fixture())"},{"line_number":72,"context_line":"        self.useFixture(glance_fixtures.StandardLogging())"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_v2_match_id(self):"},{"line_number":75,"context_line":"        req \u003d webob.Request.blank(\u0027/v2/images/asdf/file\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f3ce666_e99df89f","line":72,"range":{"start_line":72,"start_character":24,"end_line":72,"end_character":55},"updated":"2023-07-21 15:27:08.000000000","message":"Ditto","commit_id":"de683a2a039d0578529dd33f080df9119b32fa16"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c91e60cd81d198a1e4dc3300939a6cdd17e7acb","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # Make sure logging output is limited but still test debug formatting"},{"line_number":71,"context_line":"        self.useFixture(log_fixture.get_logging_handle_error_fixture())"},{"line_number":72,"context_line":"        self.useFixture(glance_fixtures.StandardLogging())"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_v2_match_id(self):"},{"line_number":75,"context_line":"        req \u003d webob.Request.blank(\u0027/v2/images/asdf/file\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3c084e35_0f116c1e","line":72,"range":{"start_line":72,"start_character":24,"end_line":72,"end_character":55},"in_reply_to":"1f3ce666_e99df89f","updated":"2023-07-24 16:16:49.000000000","message":"Also ditto","commit_id":"de683a2a039d0578529dd33f080df9119b32fa16"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"243ba18180df921bac3742d975d4f7cad43c815b","unresolved":true,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # Make sure logging output is limited but still test debug formatting"},{"line_number":100,"context_line":"        self.useFixture(log_fixture.get_logging_handle_error_fixture())"},{"line_number":101,"context_line":"        self.useFixture(glance_fixtures.StandardLogging())"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def test_stash_cache_request_info(self):"},{"line_number":104,"context_line":"        self.middleware._stash_request_info(self.request, \u0027asdf\u0027, \u0027GET\u0027, \u0027v2\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c033c0ae_f70b852b","line":101,"range":{"start_line":101,"start_character":24,"end_line":101,"end_character":55},"updated":"2023-07-21 15:27:08.000000000","message":"Ditto","commit_id":"de683a2a039d0578529dd33f080df9119b32fa16"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c91e60cd81d198a1e4dc3300939a6cdd17e7acb","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # Make sure logging output is limited but still test debug formatting"},{"line_number":100,"context_line":"        self.useFixture(log_fixture.get_logging_handle_error_fixture())"},{"line_number":101,"context_line":"        self.useFixture(glance_fixtures.StandardLogging())"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def test_stash_cache_request_info(self):"},{"line_number":104,"context_line":"        self.middleware._stash_request_info(self.request, \u0027asdf\u0027, \u0027GET\u0027, \u0027v2\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"44a9d41f_2b867d06","line":101,"range":{"start_line":101,"start_character":24,"end_line":101,"end_character":55},"in_reply_to":"c033c0ae_f70b852b","updated":"2023-07-24 16:16:49.000000000","message":"Also ditto","commit_id":"de683a2a039d0578529dd33f080df9119b32fa16"}]}