)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"b607b2d30303dd818823eeb286087783ab87650a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"22c27601_eb9eac52","updated":"2023-07-21 15:49:47.000000000","message":"Thanks for the patch, nitpicking inline :)","commit_id":"62663ddaec2847898e2015606a325cc9b1670671"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"8637ee94b7c69aaf2b8e16e08f3806b99c19b84d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f07f5f7_9b1df5b8","updated":"2023-09-06 06:04:40.000000000","message":"recheck ssh time out for resize_volume_backed_server tempest test","commit_id":"9b9afcaa29572c2e16b2b4ddfa9d70b99de0efb1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8fed50c0873e819da7c2edb85552da4fb09d7190","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0edd334a_5f11d312","updated":"2023-07-24 21:32:13.000000000","message":"recheck tempest timeout","commit_id":"9b9afcaa29572c2e16b2b4ddfa9d70b99de0efb1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"146ec183a1d4c41ad9451d5f792b5e53d384d9d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"40e34652_b6f8d0f6","updated":"2023-07-26 15:17:42.000000000","message":"recheck timeout","commit_id":"9b9afcaa29572c2e16b2b4ddfa9d70b99de0efb1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d999cd99ceed7dc1c7bd2b59d9a74fbbb890f5e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"846a6f10_7a60330d","updated":"2023-07-26 09:04:02.000000000","message":"recheck timeout","commit_id":"9b9afcaa29572c2e16b2b4ddfa9d70b99de0efb1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2904d34a960b715b6a71b78ebf86fcb52f41cdb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"60af19d7_c985cfb2","updated":"2023-09-06 10:05:52.000000000","message":"recheck unrelated failure","commit_id":"9b9afcaa29572c2e16b2b4ddfa9d70b99de0efb1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9e11b3c70db675205e18e03d1dbc3bf1a44eaecc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"36b704f4_8ffdf193","updated":"2023-07-25 09:15:15.000000000","message":"recheck unrelated tempest failure","commit_id":"9b9afcaa29572c2e16b2b4ddfa9d70b99de0efb1"}],"glance/db/sqlalchemy/alembic_migrations/__init__.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"b607b2d30303dd818823eeb286087783ab87650a","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        if \"pike01\" in heads:"},{"line_number":69,"context_line":"            update_alembic_version(\"pike01\", \"pike_contract01\")"},{"line_number":70,"context_line":"        elif \"ocata01\" in heads:"},{"line_number":71,"context_line":"            update_alembic_version(\"ocata01\", \"ocata_contract01\")"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        heads \u003d context.get_current_heads()"},{"line_number":74,"context_line":"        return heads"}],"source_content_type":"text/x-python","patch_set":1,"id":"d67ad554_ec57500f","line":71,"range":{"start_line":71,"start_character":12,"end_line":71,"end_character":34},"updated":"2023-07-21 15:49:47.000000000","message":"These changes are unrelated to this patch.","commit_id":"62663ddaec2847898e2015606a325cc9b1670671"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"255359123f1d192f2431010f5081fed0b139c023","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        if \"pike01\" in heads:"},{"line_number":69,"context_line":"            update_alembic_version(\"pike01\", \"pike_contract01\")"},{"line_number":70,"context_line":"        elif \"ocata01\" in heads:"},{"line_number":71,"context_line":"            update_alembic_version(\"ocata01\", \"ocata_contract01\")"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        heads \u003d context.get_current_heads()"},{"line_number":74,"context_line":"        return heads"}],"source_content_type":"text/x-python","patch_set":1,"id":"73e26e73_6e9ac419","line":71,"range":{"start_line":71,"start_character":12,"end_line":71,"end_character":34},"in_reply_to":"d67ad554_ec57500f","updated":"2023-07-25 09:15:06.000000000","message":"Per other file","commit_id":"62663ddaec2847898e2015606a325cc9b1670671"}],"glance/db/sqlalchemy/alembic_migrations/env.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"b607b2d30303dd818823eeb286087783ab87650a","unresolved":true,"context_lines":[{"line_number":29,"context_line":"# other values from the config, defined by the needs of env.py,"},{"line_number":30,"context_line":"# can be acquired:"},{"line_number":31,"context_line":"# my_important_option \u003d config.get_main_option(\"my_important_option\")"},{"line_number":32,"context_line":"# ... etc."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Interpret the config file for Python logging."},{"line_number":35,"context_line":"# This line sets up loggers basically."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f426796_32daed16","side":"PARENT","line":32,"range":{"start_line":32,"start_character":5,"end_line":32,"end_character":6},"updated":"2023-07-21 15:49:47.000000000","message":"Why are you removing these comments?","commit_id":"932cbc5da97f6d557797abf4839e49e60939265f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5653e8359f5a5e335eb03ae358d107eaf71acd18","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# other values from the config, defined by the needs of env.py,"},{"line_number":30,"context_line":"# can be acquired:"},{"line_number":31,"context_line":"# my_important_option \u003d config.get_main_option(\"my_important_option\")"},{"line_number":32,"context_line":"# ... etc."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Interpret the config file for Python logging."},{"line_number":35,"context_line":"# This line sets up loggers basically."}],"source_content_type":"text/x-python","patch_set":1,"id":"704908de_919f6465","side":"PARENT","line":32,"range":{"start_line":32,"start_character":5,"end_line":32,"end_character":6},"in_reply_to":"1f426796_32daed16","updated":"2023-08-09 17:50:35.000000000","message":"To be honest, I just copy-pasted this section from the nova equivalent and that was removed there. It\u0027s kind of unnecessary anyway: just RTM 😉","commit_id":"932cbc5da97f6d557797abf4839e49e60939265f"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"b607b2d30303dd818823eeb286087783ab87650a","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from logging import config as log_config"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from alembic import context"},{"line_number":19,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"aec0c636_9faa13dc","line":16,"range":{"start_line":16,"start_character":30,"end_line":16,"end_character":40},"updated":"2023-07-21 15:49:47.000000000","message":"The new line is unrelated to this patch.","commit_id":"62663ddaec2847898e2015606a325cc9b1670671"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"255359123f1d192f2431010f5081fed0b139c023","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from logging import config as log_config"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from alembic import context"},{"line_number":19,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"229a11b4_152481b7","line":16,"range":{"start_line":16,"start_character":30,"end_line":16,"end_character":40},"in_reply_to":"aec0c636_9faa13dc","updated":"2023-07-25 09:15:06.000000000","message":"per below","commit_id":"62663ddaec2847898e2015606a325cc9b1670671"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"b607b2d30303dd818823eeb286087783ab87650a","unresolved":true,"context_lines":[{"line_number":32,"context_line":"if config.attributes.get(\u0027configure_logger\u0027, True):"},{"line_number":33,"context_line":"    log_config.fileConfig(config.config_file_name)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# this is the MetaData object for the various models in the database"},{"line_number":36,"context_line":"target_metadata \u003d models.BASE.metadata"},{"line_number":37,"context_line":"for table in models_metadef.BASE_DICT.metadata.sorted_tables:"},{"line_number":38,"context_line":"    target_metadata._add_table(table.name, table.schema, table)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7b2b849a_63207e7f","line":35,"range":{"start_line":35,"start_character":23,"end_line":35,"end_character":29},"updated":"2023-07-21 15:49:47.000000000","message":"Is fixing this comment related to this patch?","commit_id":"62663ddaec2847898e2015606a325cc9b1670671"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"255359123f1d192f2431010f5081fed0b139c023","unresolved":false,"context_lines":[{"line_number":32,"context_line":"if config.attributes.get(\u0027configure_logger\u0027, True):"},{"line_number":33,"context_line":"    log_config.fileConfig(config.config_file_name)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# this is the MetaData object for the various models in the database"},{"line_number":36,"context_line":"target_metadata \u003d models.BASE.metadata"},{"line_number":37,"context_line":"for table in models_metadef.BASE_DICT.metadata.sorted_tables:"},{"line_number":38,"context_line":"    target_metadata._add_table(table.name, table.schema, table)"}],"source_content_type":"text/x-python","patch_set":1,"id":"272b660a_7f69643f","line":35,"range":{"start_line":35,"start_character":23,"end_line":35,"end_character":29},"in_reply_to":"4d380f75_b48e2ba0","updated":"2023-07-25 09:15:06.000000000","message":"Done","commit_id":"62663ddaec2847898e2015606a325cc9b1670671"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2aaa0329964fde0754ce450e019fed499d03da7d","unresolved":true,"context_lines":[{"line_number":32,"context_line":"if config.attributes.get(\u0027configure_logger\u0027, True):"},{"line_number":33,"context_line":"    log_config.fileConfig(config.config_file_name)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# this is the MetaData object for the various models in the database"},{"line_number":36,"context_line":"target_metadata \u003d models.BASE.metadata"},{"line_number":37,"context_line":"for table in models_metadef.BASE_DICT.metadata.sorted_tables:"},{"line_number":38,"context_line":"    target_metadata._add_table(table.name, table.schema, table)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4d380f75_b48e2ba0","line":35,"range":{"start_line":35,"start_character":23,"end_line":35,"end_character":29},"in_reply_to":"7b2b849a_63207e7f","updated":"2023-07-24 17:04:09.000000000","message":"Eh, not really, no. I\u0027ve just copied-pasted this from the other projects (nova, keystone, cinder, ...) where this is defined. There\u0027s value in them all working roughly the same way.\n\nI could remove this but I don\u0027t really want to respin the series to do so, if that\u0027s okay 😅","commit_id":"62663ddaec2847898e2015606a325cc9b1670671"}]}