)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"764d89c332e5af3b5cd5f485d4432afefaa02e55","unresolved":false,"context_lines":[{"line_number":15,"context_line":"it rather well [1] (Look for \"Legacy Features of Query.join()\" and"},{"line_number":16,"context_line":"\"Joins to a Target with an ON Clause\"). Essentially, because we are"},{"line_number":17,"context_line":"joining e.g. the ImageTag table multiple times, we need to create an"},{"line_number":18,"context_line":"alias and use it for both the join and resulting queries."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] https://docs.sqlalchemy.org/en/14/orm/query.html#sqlalchemy.orm.Query.join"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5141c5e2_d938dfd7","line":18,"updated":"2023-07-24 17:10:30.000000000","message":"fwiw, I did try rewriting the query to avoid multiple joins but without this there\u0027s no apparent way to do an OR join (join on tag_a OR tag_b OR ...)","commit_id":"2d4b891906d1b01ecf52da70c16e1b32cb69a693"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"176ea666a841caf26b379659eae436720cd0e44e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b30a770c_2cad2b68","updated":"2023-09-05 14:19:44.000000000","message":"I like Abhishek\u0027s suggestions, but since he +2ed I don\u0027t feel too bad about merging this as is.","commit_id":"44050a2f753e4a3af76475c27f3adea719819cd1"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2820004089d732b6d966b1126f18ac1c9c6999fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7de912b9_46f75695","updated":"2023-08-08 08:30:42.000000000","message":"Looks good but one suggestion inline","commit_id":"44050a2f753e4a3af76475c27f3adea719819cd1"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"69db116e29e572de4a972d8826f43a33b2fa5c19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1882b7f6_68d67184","updated":"2023-08-14 07:25:54.000000000","message":"Thanks!","commit_id":"44050a2f753e4a3af76475c27f3adea719819cd1"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"dc51a54748c27095a50e065e0276bd52d5897741","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9b707ad2_13887457","updated":"2023-08-09 06:00:36.000000000","message":"recheck\n\nglance-multistore-cinder-import timeouts while cleaning operation in test_resize_volume_backed_server_confirm test","commit_id":"44050a2f753e4a3af76475c27f3adea719819cd1"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1ff1d7d6ea49bd68f1256ee87ef97e0334f216a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"542115c0_33acb65d","updated":"2023-08-08 08:24:18.000000000","message":"recheck\n\nimage saving race condition + DB connection error for few tests","commit_id":"44050a2f753e4a3af76475c27f3adea719819cd1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2167c524f654222c436a178178f95dbe1516a4fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f5484cb_36dab897","updated":"2023-09-12 08:20:15.000000000","message":"recheck failure on base patch...le sigh","commit_id":"44050a2f753e4a3af76475c27f3adea719819cd1"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e15ef203ab866430b52605d85f0d93d4823cc187","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6919e173_d8067590","updated":"2023-08-02 06:14:37.000000000","message":"recheck timeout","commit_id":"44050a2f753e4a3af76475c27f3adea719819cd1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1e3adfd49df7040eb94124c6d46f71429c96e255","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"93baf123_bd28ecc2","updated":"2023-07-26 15:18:00.000000000","message":"recheck timeout","commit_id":"44050a2f753e4a3af76475c27f3adea719819cd1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4eadc1bda2b98249cdce26df0f9b871282d59fdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a3317cfe_60cfb772","updated":"2023-07-25 09:16:18.000000000","message":"recheck timeout","commit_id":"44050a2f753e4a3af76475c27f3adea719819cd1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cd2ef258a8ba97c79dfe25c66f57c0464e5ee6b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f0724d0b_e6b6c50c","updated":"2023-07-26 09:04:17.000000000","message":"recheck timeout","commit_id":"44050a2f753e4a3af76475c27f3adea719819cd1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"115f449cb8187dc6c1536d4e6726fcd6ea38d888","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"99026999_3b1757d1","updated":"2023-09-12 10:57:43.000000000","message":"recheck unrelated failure","commit_id":"44050a2f753e4a3af76475c27f3adea719819cd1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a8a86e2c524215c2f1b4a4df358e1971deda295","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"275c4931_202660d6","updated":"2023-09-11 07:44:43.000000000","message":"recheck unrelated failure on base patch","commit_id":"44050a2f753e4a3af76475c27f3adea719819cd1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dbe3baac6b56852794b0a61d473318f1cb957c20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b45cab78_14495ec3","updated":"2023-07-25 14:33:09.000000000","message":"recheck unrelated failures","commit_id":"44050a2f753e4a3af76475c27f3adea719819cd1"}],"glance/db/sqlalchemy/api.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2820004089d732b6d966b1126f18ac1c9c6999fc","unresolved":true,"context_lines":[{"line_number":492,"context_line":"        tags \u003d filters.pop(\u0027tags\u0027)"},{"line_number":493,"context_line":"        for tag in tags:"},{"line_number":494,"context_line":"            alias \u003d sa_orm.aliased(models.ImageTag)"},{"line_number":495,"context_line":"            tag_filters \u003d [alias.deleted \u003d\u003d False]"},{"line_number":496,"context_line":"            tag_filters.extend([alias.value \u003d\u003d tag])"},{"line_number":497,"context_line":"            tag_conditions.append((alias, tag_filters))"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    filters \u003d {k: v for k, v in filters.items() if v is not None}"}],"source_content_type":"text/x-python","patch_set":2,"id":"dc4ee09c_70b8a73b","line":496,"range":{"start_line":495,"start_character":12,"end_line":496,"end_character":52},"updated":"2023-08-08 08:30:42.000000000","message":"I know not related to this but if we are modifying it any then why not\n\ntag_filters \u003d [alias.deleted \u003d\u003d False, alias.value \u003d\u003d tag]","commit_id":"44050a2f753e4a3af76475c27f3adea719819cd1"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2820004089d732b6d966b1126f18ac1c9c6999fc","unresolved":true,"context_lines":[{"line_number":558,"context_line":"def _make_image_property_condition(key, value):"},{"line_number":559,"context_line":"    alias \u003d sa_orm.aliased(models.ImageProperty)"},{"line_number":560,"context_line":"    prop_filters \u003d [alias.deleted \u003d\u003d False]"},{"line_number":561,"context_line":"    prop_filters.extend([alias.name \u003d\u003d key])"},{"line_number":562,"context_line":"    prop_filters.extend([alias.value \u003d\u003d value])"},{"line_number":563,"context_line":"    return alias, prop_filters"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff4d6a0e_cea6ef13","line":562,"range":{"start_line":561,"start_character":4,"end_line":562,"end_character":47},"updated":"2023-08-08 08:30:42.000000000","message":"ditto","commit_id":"44050a2f753e4a3af76475c27f3adea719819cd1"}]}