)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b8bd219f4881ddc82442643056e6d655289bc4ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2c5fc84f_29592b08","updated":"2023-11-03 09:48:03.000000000","message":"recheck cinder-multistore timeout in scenario tests","commit_id":"9b0177193ba6bbfd531114c289f4fa66f3641d2c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ff78d6dd5c18f3e042a8385fcc5abc1fc5b22b9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"27c3fae2_dbcd1eb1","updated":"2024-02-08 17:44:50.000000000","message":"Thank you for inputs Dan!","commit_id":"3c11ef2047dddcd864e212b68cf103b2b4577d05"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"eea0d5655aeb9c3c3feb8183b97bebe95b53dbce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4721a7d7_797548ab","updated":"2024-01-25 05:20:21.000000000","message":"recheck backup fails to reach state within given time.","commit_id":"3c11ef2047dddcd864e212b68cf103b2b4577d05"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"71aa9b7ccc1548eb4bbec234aa9da00f2ab3578a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a3c7a6e3_2d0d388d","updated":"2024-02-15 01:43:45.000000000","message":"Thanks!\n\nThis makes https://review.opendev.org/c/openstack/glance/+/900026 redundant, gotta remember to abandon it if this merges.","commit_id":"b6bd03d4bc5cd3eef8b73b72b3998da66b95cbb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fb9db82ce3e05d2085e7d9dbc0c0dd559f3a9b77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3170fa4c_94889c01","updated":"2024-02-09 14:47:36.000000000","message":"recheck cinder timed out creating volume","commit_id":"b6bd03d4bc5cd3eef8b73b72b3998da66b95cbb3"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4a7cd8b13340ae3d1d57feb010b67e277bbd226a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b38c6a70_f86ba353","updated":"2024-02-19 14:26:25.000000000","message":"recheck server fault","commit_id":"b6bd03d4bc5cd3eef8b73b72b3998da66b95cbb3"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"cf54ee689bf0dce511232ec30749ec7dfa64492e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3b226a4f_cad879c1","updated":"2024-02-19 05:29:46.000000000","message":"recheck unrelated timeout","commit_id":"b6bd03d4bc5cd3eef8b73b72b3998da66b95cbb3"}],"glance/db/sqlalchemy/alembic_migrations/versions/2024_1_expand01_add_cache_tables.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d1a59f084445a77903148eb6234b77b19b4f97a1","unresolved":true,"context_lines":[{"line_number":36,"context_line":"def _add_node_reference_table():"},{"line_number":37,"context_line":"    op.create_table(\u0027node_reference\u0027,"},{"line_number":38,"context_line":"                    Column(\u0027node_reference_id\u0027, Integer(), nullable\u003dFalse,"},{"line_number":39,"context_line":"                           autoincrement\u003dTrue),"},{"line_number":40,"context_line":"                    Column(\u0027node_reference_url\u0027, String(length\u003d255),"},{"line_number":41,"context_line":"                           nullable\u003dFalse),"},{"line_number":42,"context_line":"                    PrimaryKeyConstraint(\u0027node_reference_id\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"0f103dc2_66c0401f","line":39,"updated":"2024-02-08 15:43:28.000000000","message":"Sorry if I missed this earlier, but I think the lesson we\u0027ve learned in nova is that making all of these IDs BigInteger is a good idea for the future. The cache table is definitely more likely to hit it first, and I can see the argument for thinking this will never roll over, but it\u0027s fairly painful if and when your auto-increment column hits the limit.","commit_id":"3c11ef2047dddcd864e212b68cf103b2b4577d05"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ff78d6dd5c18f3e042a8385fcc5abc1fc5b22b9b","unresolved":true,"context_lines":[{"line_number":36,"context_line":"def _add_node_reference_table():"},{"line_number":37,"context_line":"    op.create_table(\u0027node_reference\u0027,"},{"line_number":38,"context_line":"                    Column(\u0027node_reference_id\u0027, Integer(), nullable\u003dFalse,"},{"line_number":39,"context_line":"                           autoincrement\u003dTrue),"},{"line_number":40,"context_line":"                    Column(\u0027node_reference_url\u0027, String(length\u003d255),"},{"line_number":41,"context_line":"                           nullable\u003dFalse),"},{"line_number":42,"context_line":"                    PrimaryKeyConstraint(\u0027node_reference_id\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"8f5f8645_a8653417","line":39,"in_reply_to":"0f103dc2_66c0401f","updated":"2024-02-08 17:44:50.000000000","message":"Ack, will update in next PS","commit_id":"3c11ef2047dddcd864e212b68cf103b2b4577d05"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d1a59f084445a77903148eb6234b77b19b4f97a1","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                        name\u003d\u0027ix_cached_images_image_id_node_reference_id\u0027),"},{"line_number":72,"context_line":"                    mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":73,"context_line":"                    mysql_charset\u003d\u0027utf8\u0027,"},{"line_number":74,"context_line":"                    extend_existing\u003dTrue)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":6,"id":"3d4de364_86f7eb6b","line":74,"updated":"2024-02-08 15:43:28.000000000","message":"Surely you want an index on `image_id` right? Or maybe on that _and_ `node_reference_id`? I guess I need to see what queries you\u0027re going to do, but if there are tons of cached images, we\u0027ll want to be able to look those up quickly I think.","commit_id":"3c11ef2047dddcd864e212b68cf103b2b4577d05"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ff78d6dd5c18f3e042a8385fcc5abc1fc5b22b9b","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                        name\u003d\u0027ix_cached_images_image_id_node_reference_id\u0027),"},{"line_number":72,"context_line":"                    mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":73,"context_line":"                    mysql_charset\u003d\u0027utf8\u0027,"},{"line_number":74,"context_line":"                    extend_existing\u003dTrue)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":6,"id":"dd7a375c_ba21be59","line":74,"in_reply_to":"3d4de364_86f7eb6b","updated":"2024-02-08 17:44:50.000000000","message":"Ack, earlier structure didn\u0027t had any indexes So i didn\u0027t added any.","commit_id":"3c11ef2047dddcd864e212b68cf103b2b4577d05"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"955b36210e88925d2bb2d196e745e60f9412ab1e","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                        name\u003d\u0027ix_cached_images_image_id_node_reference_id\u0027),"},{"line_number":72,"context_line":"                    mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":73,"context_line":"                    mysql_charset\u003d\u0027utf8\u0027,"},{"line_number":74,"context_line":"                    extend_existing\u003dTrue)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":6,"id":"17d470a4_93668164","line":74,"in_reply_to":"4536367a_805cc198","updated":"2024-02-09 14:35:59.000000000","message":"Oh yep, it does, goog","commit_id":"3c11ef2047dddcd864e212b68cf103b2b4577d05"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"955b36210e88925d2bb2d196e745e60f9412ab1e","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                        name\u003d\u0027ix_cached_images_image_id_node_reference_id\u0027),"},{"line_number":72,"context_line":"                    mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":73,"context_line":"                    mysql_charset\u003d\u0027utf8\u0027,"},{"line_number":74,"context_line":"                    extend_existing\u003dTrue)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":6,"id":"29992044_ebe9509e","line":74,"in_reply_to":"4536367a_805cc198","updated":"2024-02-09 14:35:59.000000000","message":"Yep, it does, so if you always look them up image and node together, then you\u0027re good.","commit_id":"3c11ef2047dddcd864e212b68cf103b2b4577d05"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6d5bb0b26764b2d4811667a3f18012905c0d6782","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                        name\u003d\u0027ix_cached_images_image_id_node_reference_id\u0027),"},{"line_number":72,"context_line":"                    mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":73,"context_line":"                    mysql_charset\u003d\u0027utf8\u0027,"},{"line_number":74,"context_line":"                    extend_existing\u003dTrue)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":6,"id":"4536367a_805cc198","line":74,"in_reply_to":"dd7a375c_ba21be59","updated":"2024-02-09 07:28:54.000000000","message":"I think by default it creates index for unique constraints;\n\nhttps://review.opendev.org/c/openstack/glance/+/899869/6/glance/tests/functional/db/migrations/test_2024_1_expand01.py#55","commit_id":"3c11ef2047dddcd864e212b68cf103b2b4577d05"}]}