)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8c08f143993aaebea67d8a3b636d7fbb49779487","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Made provision to read gloabl glance-api.conf file by"},{"line_number":10,"context_line":"cache-pruner, cache-cleaner command line utility tools"},{"line_number":11,"context_line":"to make those compatible with cenralized_db cache driver."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related blueprint centralized-cache-db"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dcfc818c_e8c9c170","line":11,"range":{"start_line":11,"start_character":30,"end_line":11,"end_character":43},"updated":"2023-11-28 14:45:17.000000000","message":"centralized_db","commit_id":"dc138e8b33903a939500ac8d91e5677f71b9ed72"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"84968fe91f5815499eced594fa8ecee96a61d246","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Made provision to read gloabl glance-api.conf file by"},{"line_number":10,"context_line":"cache-pruner, cache-cleaner command line utility tools"},{"line_number":11,"context_line":"to make those compatible with cenralized_db cache driver."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related blueprint centralized-cache-db"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dc3193f0_ddf04109","line":11,"range":{"start_line":11,"start_character":30,"end_line":11,"end_character":43},"in_reply_to":"dcfc818c_e8c9c170","updated":"2024-02-20 15:02:07.000000000","message":"Still borken :)","commit_id":"dc138e8b33903a939500ac8d91e5677f71b9ed72"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"05abf4962349741ccb9962d70b093b1871e51d44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2551dfcf_3453151e","updated":"2023-11-03 09:47:17.000000000","message":"rechec cinder-multistore timeout during scenario tests execution.","commit_id":"ad45433cc6d0907cac4f668523004ffa1790e485"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"aadae51c2ff0634e78b16ed50d93a3fc911056bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1eb21e0b_85dd1622","updated":"2023-11-07 07:17:10.000000000","message":"recheck Failed to delete volume within the required time in cinder multistore job","commit_id":"ad45433cc6d0907cac4f668523004ffa1790e485"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"81ff2f21c9ada0c5c8f9b217936c28e3f47fa672","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bf0377c8_a99cd006","updated":"2023-11-07 05:00:04.000000000","message":"recheck cinder-multistore timeout during scenario tests execution.","commit_id":"ad45433cc6d0907cac4f668523004ffa1790e485"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"41844f924fd4737efa9dc33fbc6f991ac3e446cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"65de03e0_c86e15ad","updated":"2023-11-07 09:23:44.000000000","message":"recheck unrelated failure","commit_id":"ad45433cc6d0907cac4f668523004ffa1790e485"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9d743e42cf3aa6d0c100cea73bf52ef3e02fd6fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bc3e7e91_5ffb23a1","updated":"2023-11-09 15:22:23.000000000","message":"recheck","commit_id":"dc138e8b33903a939500ac8d91e5677f71b9ed72"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"dff41f0e83057b5c2eb7ca32480bb5ffabbeb381","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ec445c95_94d2cf4f","updated":"2023-11-10 05:05:03.000000000","message":"recheck multiple 500 errors","commit_id":"dc138e8b33903a939500ac8d91e5677f71b9ed72"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"360f7b871f38154c62d06f028b3fa003a66bd7f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7a3dd513_6f145872","updated":"2024-02-01 06:06:46.000000000","message":"recheck grenade failure","commit_id":"a0640e18fecb0e5d8293ca3e6af26323416186a0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8652549985ca49cf82192e1691508ef7a3f271b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"22d40a7f_21a38a99","updated":"2024-01-25 05:22:33.000000000","message":"recheck timeout and multiple failures","commit_id":"a0640e18fecb0e5d8293ca3e6af26323416186a0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"33fedd054b2e47d740664ae67364109abd4f0186","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"cc584a87_c64b5d06","updated":"2024-02-14 04:35:13.000000000","message":"recheck unrelated timeout","commit_id":"43ba1b7011391d9550801dd5c3620b721c938835"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f2578caa437703059ca630a95f8c9ddbfd95a339","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7adcc95a_a7031af8","updated":"2024-02-14 10:01:39.000000000","message":"recheck failed to delete volume","commit_id":"1fa50957a063b9e20485f93db0388f580a689a53"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d7a325d57f3f62131f8ab026e258b1dc9c7bd044","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"0bde692e_eb375c76","updated":"2024-02-20 17:46:18.000000000","message":"I didn\u0027t found the better place to do it and wanted to highlight that cache utilities does not use global api conf file which has worker_self_reference_url defined.","commit_id":"322dc1e92d299e4ff4b95a0838ffc026aa1d7446"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"84968fe91f5815499eced594fa8ecee96a61d246","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"6b388f29_f116c3cf","updated":"2024-02-20 15:02:07.000000000","message":"I\u0027m not sure I understand why this tiny change is its own patch. Is there some value to doing this in isolation to prove it doesn\u0027t break anything?","commit_id":"322dc1e92d299e4ff4b95a0838ffc026aa1d7446"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e17e916b4c63f63dbb89605552991ce1af5ad597","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"1c55b66d_2d1e8f85","updated":"2024-02-19 16:59:56.000000000","message":"recheck similar volume time out error","commit_id":"322dc1e92d299e4ff4b95a0838ffc026aa1d7446"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c8ffc5d5288963fab2b44dfe01dd00c97d081dff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"c1a966eb_f530555f","updated":"2024-02-19 05:33:41.000000000","message":"recheck unrelated timeout","commit_id":"322dc1e92d299e4ff4b95a0838ffc026aa1d7446"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8ff6293641ae622a070133a334c5a634ce7c7f25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"a91476fc_291c9576","updated":"2024-02-19 14:25:25.000000000","message":"recheck volume fails to reach desired state.","commit_id":"322dc1e92d299e4ff4b95a0838ffc026aa1d7446"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"e604e3f36a5efa8d336fa8dd6e06dedcb132f73b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"10457603_86722331","updated":"2024-02-27 13:22:57.000000000","message":"Looks good to me! Thanks !","commit_id":"9c7820740a5ceaf31336da39624226b9e398e84d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"edde9a872331043ff0d2fd0f14ea5960a8cd5a9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"081a1cce_769b9fcd","updated":"2024-02-26 18:27:50.000000000","message":"recheck grenade failure looks unrelated","commit_id":"9c7820740a5ceaf31336da39624226b9e398e84d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"baf0b1e4da8a5b2ceec28be45edc842a26d6e323","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"701d33c1_04d52768","updated":"2024-02-21 06:56:00.000000000","message":"recheck volume fails to reach desired state","commit_id":"9c7820740a5ceaf31336da39624226b9e398e84d"}],"glance/common/config.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"85cd31e5a61093f8a4cae98895e2372473d7e8c8","unresolved":true,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"def parse_cache_args(args\u003dNone):"},{"line_number":660,"context_line":"    config_files \u003d cfg.find_config_files(project\u003d\u0027glance\u0027, prog\u003d\u0027glance-cache\u0027)"},{"line_number":661,"context_line":"    config_files.extend(cfg.find_config_files(project\u003d\u0027glance\u0027,"},{"line_number":662,"context_line":"                                              prog\u003d\u0027glance-api\u0027))"},{"line_number":663,"context_line":"    parse_args(args\u003dargs, default_config_files\u003dconfig_files)"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"6e93ebfe_d3d503af","line":662,"range":{"start_line":661,"start_character":4,"end_line":662,"end_character":65},"updated":"2023-12-19 06:23:07.000000000","message":"With this change config files for glance-api are loaded AFTER check config file. So in case api config and cache config have different values then the values in api config are honored. This is not backword compatible and we should honor the cache config file.\n\nIn addition, adding api config can\u0027t eliminate configuration impact (ex. some options might be explicitly set only in api.conf but loading api.conf additionally makes the cache cli load that option). I\u0027m wondering if we should really take care of this automatically or we can just leave the required configurations. (as is done for the other options such as store options).","commit_id":"dc138e8b33903a939500ac8d91e5677f71b9ed72"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"854e1959d5cdd0ed7651daab9a3e248b58237f4f","unresolved":true,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"def parse_cache_args(args\u003dNone):"},{"line_number":660,"context_line":"    config_files \u003d cfg.find_config_files(project\u003d\u0027glance\u0027, prog\u003d\u0027glance-cache\u0027)"},{"line_number":661,"context_line":"    config_files.extend(cfg.find_config_files(project\u003d\u0027glance\u0027,"},{"line_number":662,"context_line":"                                              prog\u003d\u0027glance-api\u0027))"},{"line_number":663,"context_line":"    parse_args(args\u003dargs, default_config_files\u003dconfig_files)"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d7652210_396b45b5","line":662,"range":{"start_line":661,"start_character":4,"end_line":662,"end_character":65},"in_reply_to":"5061360a_67b8955c","updated":"2024-01-17 09:37:14.000000000","message":"Yes I think we should read the api config first, so that users can override options for cache CLI using the options in cache.conf.\n\nI understand this may not affect glance-api but I\u0027m concerned with the impact on glance cache CLI.","commit_id":"dc138e8b33903a939500ac8d91e5677f71b9ed72"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ac745e8be721f656bae87e394bf86dec4e6fcb84","unresolved":true,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"def parse_cache_args(args\u003dNone):"},{"line_number":660,"context_line":"    config_files \u003d cfg.find_config_files(project\u003d\u0027glance\u0027, prog\u003d\u0027glance-cache\u0027)"},{"line_number":661,"context_line":"    config_files.extend(cfg.find_config_files(project\u003d\u0027glance\u0027,"},{"line_number":662,"context_line":"                                              prog\u003d\u0027glance-api\u0027))"},{"line_number":663,"context_line":"    parse_args(args\u003dargs, default_config_files\u003dconfig_files)"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5061360a_67b8955c","line":662,"range":{"start_line":661,"start_character":4,"end_line":662,"end_character":65},"in_reply_to":"6e93ebfe_d3d503af","updated":"2023-12-19 06:36:46.000000000","message":"Do you think it\u0027s better to read api config first and cache config later?\n\nI don\u0027t think there will be any impact if we load additional options since this function is only called with cache CLI utility.","commit_id":"dc138e8b33903a939500ac8d91e5677f71b9ed72"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ab434bc54ed7148fe07ef8500cc48b821f1bb9c1","unresolved":false,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"def parse_cache_args(args\u003dNone):"},{"line_number":660,"context_line":"    config_files \u003d cfg.find_config_files(project\u003d\u0027glance\u0027, prog\u003d\u0027glance-cache\u0027)"},{"line_number":661,"context_line":"    config_files.extend(cfg.find_config_files(project\u003d\u0027glance\u0027,"},{"line_number":662,"context_line":"                                              prog\u003d\u0027glance-api\u0027))"},{"line_number":663,"context_line":"    parse_args(args\u003dargs, default_config_files\u003dconfig_files)"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"94b80c29_0084d232","line":662,"range":{"start_line":661,"start_character":4,"end_line":662,"end_character":65},"in_reply_to":"d7652210_396b45b5","updated":"2024-01-19 10:00:29.000000000","message":"Done","commit_id":"dc138e8b33903a939500ac8d91e5677f71b9ed72"}]}