)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c7e9cb006e60bf1fb8922422fe47c543b78be616","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0c216da1_19975290","updated":"2024-01-31 17:54:15.000000000","message":"recheck modified devstack patch to set centralized_db driver by default","commit_id":"4beb50c37251b4c673ee71ae173e9d5ebb4ab441"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3fac0f622430a35be2234b99a5b43eb7e22f95ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dd68cae9_a32554c3","updated":"2024-02-01 05:45:27.000000000","message":"recheck ssh timeout","commit_id":"8fc297210f1d37909923417f7f652cbdeec06016"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4311ec6f7ad4547e2f5618ae0ce45ae1f19a6344","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0639bf20_f5fde529","updated":"2024-02-14 04:42:09.000000000","message":"recheck timeout","commit_id":"e38a117cc3b3dc912f9326364e1531a9f7e22d60"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d70b4fc76ae72b807f3dc28c666dabe913b98acf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c04f70c1_4084bf9e","updated":"2024-02-21 05:23:52.000000000","message":"recheck volume fails to reach desired state","commit_id":"4f973850591dfec379cda9b9cdf190e2e1e2705d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2c544be3adf7d0ee1d00d51a77cddcb9d350e43f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f6e11418_5b6e1373","updated":"2024-02-28 10:04:42.000000000","message":"recheck dependency updated","commit_id":"14aa05c1ca0ac512e3146e7ebcbf90adf2bca419"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4a6895b00934e0017a2edac687864c74c9d26581","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"de9c7af6_cba2ed05","updated":"2024-02-28 04:13:45.000000000","message":"recheck py311 passes locally","commit_id":"14aa05c1ca0ac512e3146e7ebcbf90adf2bca419"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6236f5aeb9fd6c676d577b38956a7861024fd6c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1320f16a_62425b70","updated":"2024-02-28 09:39:39.000000000","message":"recheck volume fails to reach expected state","commit_id":"14aa05c1ca0ac512e3146e7ebcbf90adf2bca419"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"28fe3875929b5267dacf7590bb165bde468eea60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5220a2b0_c9538852","updated":"2024-02-28 17:53:34.000000000","message":"recheck volume disappeared in between operation","commit_id":"2f6405df5674adb553e020da5dba57d5869425b3"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fda969b1c8986e4ccd12248e229865fb55e3ac39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ac578276_29dbe45c","updated":"2024-03-05 19:50:27.000000000","message":"Thank you for inputs!","commit_id":"cb9d34e01d0f6fe160b4bce84903ad56f8241844"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b422c7dc2613d904dd61e282be45f81f3cf28971","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5a991825_3229b7b7","updated":"2024-03-05 19:56:30.000000000","message":"Cyril was already +2 I just asked to move some doc text, so fast approving.","commit_id":"9b9111f81996a22527f9622d0707891e445cbd5f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"99aa1e22ee643b7d40eea2af5251147a69be1bf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d0f8df35_11e395b6","updated":"2024-03-06 04:10:23.000000000","message":"recheck image failed to cache","commit_id":"9b9111f81996a22527f9622d0707891e445cbd5f"}],"glance/image_cache/__init__.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"adbf413823a60839d7c686acd3a403ff783d0fca","unresolved":true,"context_lines":[{"line_number":56,"context_line":"  information. It also requires a filesystem that sets ``atime`` on the files"},{"line_number":57,"context_line":"  when accessed."},{"line_number":58,"context_line":"* The ``centralized_db`` driver uses a central database (which will be common"},{"line_number":59,"context_line":"  for all glance nodes) to track the usage of cached images."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Deprecation warning:"},{"line_number":62,"context_line":"    * As centralized database will now be used for image cache management, the"}],"source_content_type":"text/x-python","patch_set":13,"id":"24458144_fa0c436d","line":59,"updated":"2024-03-05 19:30:52.000000000","message":"Maybe we should move this to the top of the list and also say \"(deprecated)\" after sqlite? I. see the deprecation warning below, but it should probably not be the top entry in the list :)","commit_id":"cb9d34e01d0f6fe160b4bce84903ad56f8241844"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fda969b1c8986e4ccd12248e229865fb55e3ac39","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  information. It also requires a filesystem that sets ``atime`` on the files"},{"line_number":57,"context_line":"  when accessed."},{"line_number":58,"context_line":"* The ``centralized_db`` driver uses a central database (which will be common"},{"line_number":59,"context_line":"  for all glance nodes) to track the usage of cached images."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Deprecation warning:"},{"line_number":62,"context_line":"    * As centralized database will now be used for image cache management, the"}],"source_content_type":"text/x-python","patch_set":13,"id":"43634a9b_d2724a2a","line":59,"in_reply_to":"24458144_fa0c436d","updated":"2024-03-05 19:50:27.000000000","message":"Acknowledged","commit_id":"cb9d34e01d0f6fe160b4bce84903ad56f8241844"}],"glance/tests/unit/common/test_wsgi.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"adbf413823a60839d7c686acd3a403ff783d0fca","unresolved":true,"context_lines":[{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    @mock.patch.object(prefetcher, \u0027Prefetcher\u0027)"},{"line_number":579,"context_line":"    @mock.patch.object(wsgi.Server, \u0027configure_socket\u0027)"},{"line_number":580,"context_line":"    @mock.patch(\u0027glance.sqlite_migration.can_migrate_to_central_db\u0027)"},{"line_number":581,"context_line":"    def test_http_keepalive(self, mock_migrate_db, mock_configure_socket,"},{"line_number":582,"context_line":"                            mock_prefetcher):"},{"line_number":583,"context_line":"        mock_migrate_db.return_value \u003d False"}],"source_content_type":"text/x-python","patch_set":13,"id":"8c0d5c62_0b61d16a","line":580,"updated":"2024-03-05 19:30:52.000000000","message":"Hmm, why do you need to mock all these out if the tests are setting the driver to sqlite? Just saying that it\u0027s probably not great to leave all these mocks in place which may not be testing stuff when you actually switch the tests to use centralized...","commit_id":"cb9d34e01d0f6fe160b4bce84903ad56f8241844"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fda969b1c8986e4ccd12248e229865fb55e3ac39","unresolved":true,"context_lines":[{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    @mock.patch.object(prefetcher, \u0027Prefetcher\u0027)"},{"line_number":579,"context_line":"    @mock.patch.object(wsgi.Server, \u0027configure_socket\u0027)"},{"line_number":580,"context_line":"    @mock.patch(\u0027glance.sqlite_migration.can_migrate_to_central_db\u0027)"},{"line_number":581,"context_line":"    def test_http_keepalive(self, mock_migrate_db, mock_configure_socket,"},{"line_number":582,"context_line":"                            mock_prefetcher):"},{"line_number":583,"context_line":"        mock_migrate_db.return_value \u003d False"}],"source_content_type":"text/x-python","patch_set":13,"id":"bb6a92bb_5d082078","line":580,"in_reply_to":"8c0d5c62_0b61d16a","updated":"2024-03-05 19:50:27.000000000","message":"Since default cache driver now is centralized_db, if I don\u0027t mock this method then it will fail in migrate_if_required where it tries to connect to sqlite db which is now not set in tests explicitly.\n\nOther option is to set it explicitly in each failing test.","commit_id":"cb9d34e01d0f6fe160b4bce84903ad56f8241844"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b942a66e11ae39765dc36352ab0458064be0814b","unresolved":false,"context_lines":[{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    @mock.patch.object(prefetcher, \u0027Prefetcher\u0027)"},{"line_number":579,"context_line":"    @mock.patch.object(wsgi.Server, \u0027configure_socket\u0027)"},{"line_number":580,"context_line":"    @mock.patch(\u0027glance.sqlite_migration.can_migrate_to_central_db\u0027)"},{"line_number":581,"context_line":"    def test_http_keepalive(self, mock_migrate_db, mock_configure_socket,"},{"line_number":582,"context_line":"                            mock_prefetcher):"},{"line_number":583,"context_line":"        mock_migrate_db.return_value \u003d False"}],"source_content_type":"text/x-python","patch_set":13,"id":"b0d09052_3c72c0cf","line":580,"in_reply_to":"bb6a92bb_5d082078","updated":"2024-03-05 19:55:28.000000000","message":"Acknowledged","commit_id":"cb9d34e01d0f6fe160b4bce84903ad56f8241844"}]}