)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"221579a72e53873270863a1bf45776d4f45082e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ea988c22_50c45a9e","updated":"2024-03-01 01:03:48.000000000","message":"Abhi, this was failing for Brian and I locally when trying to run your \"flaky test\" patch. TBH, I don\u0027t know why it\u0027s not failing in Zuul (but haven\u0027t looked hard). Either way, probably want to +W this in your morning :)","commit_id":"9df586a5fe2fd02b4f7497fc9e73b45c4acaf25d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2f00fe6122cd0b32834715de3077e1b260043b73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0379ec70_9aaecf5f","updated":"2024-03-01 13:38:14.000000000","message":"Comment inline about the proposed followup.","commit_id":"9df586a5fe2fd02b4f7497fc9e73b45c4acaf25d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"409f213dc4103d372d262fef8c892a861757a4d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6a911517_b81cf94f","updated":"2024-02-29 21:49:15.000000000","message":"Dang, that surely needs a better error behavior!","commit_id":"9df586a5fe2fd02b4f7497fc9e73b45c4acaf25d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b4303790294f633e8cc9e198eecaf812798ee854","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"63ed6a7c_fdf78f76","updated":"2024-03-01 04:47:44.000000000","message":"Thank you Brian and Dan!!","commit_id":"9df586a5fe2fd02b4f7497fc9e73b45c4acaf25d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5b9ab9e452acc3be68a8fc269d349d3d8fdabb51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3fea84a2_bfc1eb83","updated":"2024-03-01 05:50:49.000000000","message":"Will submit a patch if everyone agrees.","commit_id":"9df586a5fe2fd02b4f7497fc9e73b45c4acaf25d"}],"glance/tests/utils.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5b9ab9e452acc3be68a8fc269d349d3d8fdabb51","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        self.test_dir2 \u003d self.useFixture(fixtures.TempDir()).path"},{"line_number":88,"context_line":"        self.conf_dir \u003d os.path.join(self.test_dir, \u0027etc\u0027)"},{"line_number":89,"context_line":"        utils.safe_mkdirs(self.conf_dir)"},{"line_number":90,"context_line":"        self.lock_dir \u003d os.path.join(self.test_dir, \u0027locks\u0027)"},{"line_number":91,"context_line":"        utils.safe_mkdirs(self.lock_dir)"},{"line_number":92,"context_line":"        lockutils.set_defaults(self.lock_dir)"},{"line_number":93,"context_line":"        self.set_policy()"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # Limit the amount of DeprecationWarning messages in the unit test logs"}],"source_content_type":"text/x-python","patch_set":1,"id":"40e1f220_0573b2bd","line":92,"range":{"start_line":90,"start_character":7,"end_line":92,"end_character":45},"updated":"2024-03-01 05:50:49.000000000","message":"Since we have moved this in base class, I think it is better to remove it from\n\nhttps://github.com/openstack/glance/blob/master/glance/tests/unit/base.py#L122\nhttps://github.com/openstack/glance/blob/master/glance/tests/unit/base.py#L160","commit_id":"9df586a5fe2fd02b4f7497fc9e73b45c4acaf25d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2f00fe6122cd0b32834715de3077e1b260043b73","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        self.test_dir2 \u003d self.useFixture(fixtures.TempDir()).path"},{"line_number":88,"context_line":"        self.conf_dir \u003d os.path.join(self.test_dir, \u0027etc\u0027)"},{"line_number":89,"context_line":"        utils.safe_mkdirs(self.conf_dir)"},{"line_number":90,"context_line":"        self.lock_dir \u003d os.path.join(self.test_dir, \u0027locks\u0027)"},{"line_number":91,"context_line":"        utils.safe_mkdirs(self.lock_dir)"},{"line_number":92,"context_line":"        lockutils.set_defaults(self.lock_dir)"},{"line_number":93,"context_line":"        self.set_policy()"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # Limit the amount of DeprecationWarning messages in the unit test logs"}],"source_content_type":"text/x-python","patch_set":1,"id":"5332d6cb_7f4707fb","line":92,"range":{"start_line":90,"start_character":7,"end_line":92,"end_character":45},"in_reply_to":"40e1f220_0573b2bd","updated":"2024-03-01 13:38:14.000000000","message":"I completely missed that we were already using this.  I put it in the base class because I didn\u0027t know how many different tests were affected, and so that it would be already set when new tests were added.  But the other approach would be to have the class TestMigrate in your patch inherit from IsolatedUnitTest, although maybe that would bring in too much baggage to the db migration test.  I\u0027ll defer to your judgement, but i agree that a follow up is in order.","commit_id":"9df586a5fe2fd02b4f7497fc9e73b45c4acaf25d"}]}