)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b313b2bed37b1a4d3e2788467d3777d610d06b59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"40cc56b2_44f3ccc9","updated":"2024-03-07 09:09:24.000000000","message":"Looks good, thank you!","commit_id":"50813e9455a5ed80ecc57d93e85d4ad95e4f71d6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b5ee75080861b994f366cdfff9c6e31b098bc421","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3c01ab7a_8fa7b74d","updated":"2024-03-07 14:10:58.000000000","message":"A few issues noted inline, but overall the content looks good.","commit_id":"12e3a336eec45828a0a346d240653069636fd095"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1cc1dba307de228a33f694d630372558b864f3b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4a6594a7_0e9165d8","updated":"2024-03-11 05:37:42.000000000","message":"Need to hold to mention additional note/scenario.","commit_id":"913de6f75c58c2bd4a6148b1f0424ed29ce1a623"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3c1e6cfdcb1306ac5443ebccaeceb3009f179fab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f044c56d_12f6c180","updated":"2024-03-07 19:07:33.000000000","message":"Revisions LGTM.\n\nIt looks like several cinder options are missing (for example, cinder_volume_type, cinder_use_multipath), but let\u0027s hold that for a followup (to either update the text or to replace the text with a link to the cinder section of the generated config file that\u0027s in the docs).","commit_id":"913de6f75c58c2bd4a6148b1f0424ed29ce1a623"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"35cb174eb9b9955510eb0826a29840b74842bcdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4adc6654_fe1d2953","updated":"2024-03-07 17:32:03.000000000","message":"Thanks Brian for the great improvements!","commit_id":"913de6f75c58c2bd4a6148b1f0424ed29ce1a623"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"36df8290dc4620d017fbfc558c941421594e6a5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1127fdc3_6757bd00","updated":"2024-03-11 09:00:44.000000000","message":"Added upgrade scenario when single store doesn\u0027t have credentials configured in glance config file","commit_id":"81772be8994f9fd48a0aa8139a6943dddc24a9d5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b4289f8f08b9254fc178a27f70d02f0e73e2c685","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"27eb3958_66f7fb16","updated":"2024-03-28 19:01:45.000000000","message":"Changes LGTM.  We should think about splitting this page up, it\u0027s getting a bit overwhelming.","commit_id":"81772be8994f9fd48a0aa8139a6943dddc24a9d5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b85804fef4276674117e12a0ca2cc8b16725ce68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9614f224_651b0478","updated":"2024-03-11 09:04:51.000000000","message":"Looks good to me, thank you!","commit_id":"81772be8994f9fd48a0aa8139a6943dddc24a9d5"}],"doc/source/configuration/configuring.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b5ee75080861b994f366cdfff9c6e31b098bc421","unresolved":true,"context_lines":[{"line_number":758,"context_line":""},{"line_number":759,"context_line":"Configuring the Cinder Storage Backend"},{"line_number":760,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"**Note**: To create a Cinder volume from an image in this store quickly, additional"},{"line_number":763,"context_line":"settings are required. Please see the"},{"line_number":764,"context_line":"`Volume-backed image \u003chttps://docs.openstack.org/cinder/latest/admin/blockstorage-volume-backed-image.html\u003e`_"}],"source_content_type":"text/x-rst","patch_set":3,"id":"e22d38d8_c80902d6","line":761,"updated":"2024-03-07 14:10:58.000000000","message":"To avoid confusion later, I think we should add an introductory paragraph here, something like:\n\nThe cinder store gives you the ability to store images in volumes (one volume per image) in the Block Storage service.  Glance does not have direct access to whatever backend(s) are configured for Cinder; it simply hands the image data over to the Block Storage service, and Cinder decides where exactly it will be stored.\n\nGlance can influence where the data will be stored by setting the ``cinder_volume_type`` option when configuring your cinder store.  See below for details.","commit_id":"12e3a336eec45828a0a346d240653069636fd095"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"35cb174eb9b9955510eb0826a29840b74842bcdb","unresolved":false,"context_lines":[{"line_number":758,"context_line":""},{"line_number":759,"context_line":"Configuring the Cinder Storage Backend"},{"line_number":760,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"**Note**: To create a Cinder volume from an image in this store quickly, additional"},{"line_number":763,"context_line":"settings are required. Please see the"},{"line_number":764,"context_line":"`Volume-backed image \u003chttps://docs.openstack.org/cinder/latest/admin/blockstorage-volume-backed-image.html\u003e`_"}],"source_content_type":"text/x-rst","patch_set":3,"id":"e238e64a_9d91890b","line":761,"in_reply_to":"e22d38d8_c80902d6","updated":"2024-03-07 17:32:03.000000000","message":"Done","commit_id":"12e3a336eec45828a0a346d240653069636fd095"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b5ee75080861b994f366cdfff9c6e31b098bc421","unresolved":true,"context_lines":[{"line_number":764,"context_line":"`Volume-backed image \u003chttps://docs.openstack.org/cinder/latest/admin/blockstorage-volume-backed-image.html\u003e`_"},{"line_number":765,"context_line":"documentation for more information."},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"**Note**: It is recommended to set service credentials in the configuration"},{"line_number":768,"context_line":"file to create the Image-Volume in internal project otherwise it will be"},{"line_number":769,"context_line":"created in the user project and is susceptible to modifications by normal"},{"line_number":770,"context_line":"users eventually corrupting the image."}],"source_content_type":"text/x-rst","patch_set":3,"id":"c36e19e3_6ada01c7","line":767,"updated":"2024-03-07 14:10:58.000000000","message":"Suggestion: make this a warning box and begin with the problem, not the solution.  What I mean is something like:\n\n```\n   .. warning::\n      \n      Because an Image-Volume created in a user account is susceptible to\n      modifications by normal users that can corrupt the image, we recommend\n      that service credentials *always* be set in the configuration file so\n      that the Image-Volume will be created in an internal project not directly\n      accessible by non-privileged users.\n      \n      To create ...\n```","commit_id":"12e3a336eec45828a0a346d240653069636fd095"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"35cb174eb9b9955510eb0826a29840b74842bcdb","unresolved":false,"context_lines":[{"line_number":764,"context_line":"`Volume-backed image \u003chttps://docs.openstack.org/cinder/latest/admin/blockstorage-volume-backed-image.html\u003e`_"},{"line_number":765,"context_line":"documentation for more information."},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"**Note**: It is recommended to set service credentials in the configuration"},{"line_number":768,"context_line":"file to create the Image-Volume in internal project otherwise it will be"},{"line_number":769,"context_line":"created in the user project and is susceptible to modifications by normal"},{"line_number":770,"context_line":"users eventually corrupting the image."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a98f765_f9706904","line":767,"in_reply_to":"c36e19e3_6ada01c7","updated":"2024-03-07 17:32:03.000000000","message":"Changed non-priviledged to non-service since with the suggested way, only the services should be able to access the resources.","commit_id":"12e3a336eec45828a0a346d240653069636fd095"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b5ee75080861b994f366cdfff9c6e31b098bc421","unresolved":true,"context_lines":[{"line_number":973,"context_line":"Configuring multiple Cinder Storage Backend"},{"line_number":974,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"From Victoria onwards Glance fully supports configuring multiple cinder"},{"line_number":977,"context_line":"backends and user/operator will decide which cinder backend to use. While"},{"line_number":978,"context_line":"using cinder as a store for glance, operator should configure which volume"},{"line_number":979,"context_line":"types to used by setting the ``enabled_backends`` configuration option in"},{"line_number":980,"context_line":"``glance-api.conf``. For each of the stores defined in ``enabled_backends``"},{"line_number":981,"context_line":"administrator has to set specific ``volume_type`` using"},{"line_number":982,"context_line":"``cinder_volume_type`` configuration option in its own config section."},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"**NOTE**: Even in cinder one backend can be associated with multiple"},{"line_number":985,"context_line":"volume type(s), glance will support only one store per cinder volume type."}],"source_content_type":"text/x-rst","patch_set":3,"id":"6c5252c8_95527042","line":982,"range":{"start_line":976,"start_character":0,"end_line":982,"end_character":70},"updated":"2024-03-07 14:10:58.000000000","message":"I find this paragraph very confusing.  I suggest rewriting along these lines:\n\nFrom Victoria onwards Glance fully supports configuring multiple cinder\nstores by taking advantage of cinder volume-types.  Note that volume-types are defined by a Cinder administrator, and hence setting up multiple cinder stores will require collaboration with that person.\n\nFrom the Glance side, you will add each of the cinder stores you want to define to the ``enabled_backends`` configuration option in ``glance-api.conf``.  For each of these stores, you must then set the ``cinder_volume_type`` configuration option in the store\u0027s specific configuration section of ``glance-api.conf``.  What to set it to will depend on the volume-types that are available in Cinder; consult with your Cinder administrator to get a list of appropriate volume-types.","commit_id":"12e3a336eec45828a0a346d240653069636fd095"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"35cb174eb9b9955510eb0826a29840b74842bcdb","unresolved":false,"context_lines":[{"line_number":973,"context_line":"Configuring multiple Cinder Storage Backend"},{"line_number":974,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"From Victoria onwards Glance fully supports configuring multiple cinder"},{"line_number":977,"context_line":"backends and user/operator will decide which cinder backend to use. While"},{"line_number":978,"context_line":"using cinder as a store for glance, operator should configure which volume"},{"line_number":979,"context_line":"types to used by setting the ``enabled_backends`` configuration option in"},{"line_number":980,"context_line":"``glance-api.conf``. For each of the stores defined in ``enabled_backends``"},{"line_number":981,"context_line":"administrator has to set specific ``volume_type`` using"},{"line_number":982,"context_line":"``cinder_volume_type`` configuration option in its own config section."},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"**NOTE**: Even in cinder one backend can be associated with multiple"},{"line_number":985,"context_line":"volume type(s), glance will support only one store per cinder volume type."}],"source_content_type":"text/x-rst","patch_set":3,"id":"c96cd605_10b6cfb1","line":982,"range":{"start_line":976,"start_character":0,"end_line":982,"end_character":70},"in_reply_to":"6c5252c8_95527042","updated":"2024-03-07 17:32:03.000000000","message":"Done","commit_id":"12e3a336eec45828a0a346d240653069636fd095"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b5ee75080861b994f366cdfff9c6e31b098bc421","unresolved":true,"context_lines":[{"line_number":980,"context_line":"``glance-api.conf``. For each of the stores defined in ``enabled_backends``"},{"line_number":981,"context_line":"administrator has to set specific ``volume_type`` using"},{"line_number":982,"context_line":"``cinder_volume_type`` configuration option in its own config section."},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"**NOTE**: Even in cinder one backend can be associated with multiple"},{"line_number":985,"context_line":"volume type(s), glance will support only one store per cinder volume type."},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"**NOTE**: It is mandatory to set the following configuration parameters for"},{"line_number":988,"context_line":"multiple cinder stores to work:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"a677d270_7c741450","line":985,"range":{"start_line":983,"start_character":0,"end_line":985,"end_character":74},"updated":"2024-03-07 14:10:58.000000000","message":"I suggest deleting this paragraph, it\u0027s more confusing than illuminating.","commit_id":"12e3a336eec45828a0a346d240653069636fd095"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"35cb174eb9b9955510eb0826a29840b74842bcdb","unresolved":false,"context_lines":[{"line_number":980,"context_line":"``glance-api.conf``. For each of the stores defined in ``enabled_backends``"},{"line_number":981,"context_line":"administrator has to set specific ``volume_type`` using"},{"line_number":982,"context_line":"``cinder_volume_type`` configuration option in its own config section."},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"**NOTE**: Even in cinder one backend can be associated with multiple"},{"line_number":985,"context_line":"volume type(s), glance will support only one store per cinder volume type."},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"**NOTE**: It is mandatory to set the following configuration parameters for"},{"line_number":988,"context_line":"multiple cinder stores to work:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8ab9a37e_7e6f141c","line":985,"range":{"start_line":983,"start_character":0,"end_line":985,"end_character":74},"in_reply_to":"a677d270_7c741450","updated":"2024-03-07 17:32:03.000000000","message":"Sounds good and we\u0027ve already mentioned the one glance store to one volume type mapping above\nDone","commit_id":"12e3a336eec45828a0a346d240653069636fd095"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b5ee75080861b994f366cdfff9c6e31b098bc421","unresolved":true,"context_lines":[{"line_number":997,"context_line":"validate the volume types set in the glance configuration file using the"},{"line_number":998,"context_line":"above credentials."},{"line_number":999,"context_line":"If this is not validated during sevice start, we might fail to create the"},{"line_number":1000,"context_line":"image later due to invalid volume type being configured."},{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"Below are some multiple cinder store configuration examples."},{"line_number":1003,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"8fa50999_b4541a8c","line":1000,"updated":"2024-03-07 14:10:58.000000000","message":"I suggest putting this note into a warning box; don\u0027t forget to put a blank line before line 999 so that it starts a new paragraph (which I think is your intention).","commit_id":"12e3a336eec45828a0a346d240653069636fd095"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"35cb174eb9b9955510eb0826a29840b74842bcdb","unresolved":false,"context_lines":[{"line_number":997,"context_line":"validate the volume types set in the glance configuration file using the"},{"line_number":998,"context_line":"above credentials."},{"line_number":999,"context_line":"If this is not validated during sevice start, we might fail to create the"},{"line_number":1000,"context_line":"image later due to invalid volume type being configured."},{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"Below are some multiple cinder store configuration examples."},{"line_number":1003,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"33e79905_ae410964","line":1000,"in_reply_to":"8fa50999_b4541a8c","updated":"2024-03-07 17:32:03.000000000","message":"Done\nAlso didn\u0027t intend to put it in a different paragraph, combined both the lines.","commit_id":"12e3a336eec45828a0a346d240653069636fd095"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b5ee75080861b994f366cdfff9c6e31b098bc421","unresolved":true,"context_lines":[{"line_number":1251,"context_line":"URLs for legacy images will be changed from ``cinder://volume-id`` to"},{"line_number":1252,"context_line":"``cinder://store-name/volume-id``."},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"**Note**: After upgrade from single cinder store to use multiple cinder"},{"line_number":1255,"context_line":"stores the first ``image-list`` or first ``GET`` or ``image-show`` call for"},{"line_number":1256,"context_line":"image will take additional time as we will perform the lazy loading"},{"line_number":1257,"context_line":"operation to update legacy image location url to use new image location urls."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a410b6c_4200785b","line":1254,"updated":"2024-03-07 14:10:58.000000000","message":"Maybe make this a warning box","commit_id":"12e3a336eec45828a0a346d240653069636fd095"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"35cb174eb9b9955510eb0826a29840b74842bcdb","unresolved":false,"context_lines":[{"line_number":1251,"context_line":"URLs for legacy images will be changed from ``cinder://volume-id`` to"},{"line_number":1252,"context_line":"``cinder://store-name/volume-id``."},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"**Note**: After upgrade from single cinder store to use multiple cinder"},{"line_number":1255,"context_line":"stores the first ``image-list`` or first ``GET`` or ``image-show`` call for"},{"line_number":1256,"context_line":"image will take additional time as we will perform the lazy loading"},{"line_number":1257,"context_line":"operation to update legacy image location url to use new image location urls."}],"source_content_type":"text/x-rst","patch_set":3,"id":"d09c0f44_215af32d","line":1254,"in_reply_to":"9a410b6c_4200785b","updated":"2024-03-07 17:32:03.000000000","message":"I\u0027m not sure why this should be a warning? we are just notifying users that after the upgrade, the image-show call will update the location URL from old format to new format and there is nothing that the users should be concerned about.\n\nI think you meant the above note, which i can see a reason for, will put it in a warning box","commit_id":"12e3a336eec45828a0a346d240653069636fd095"}]}