)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"d5dd1d9b63cb8e69b9048234d03f28428e140098","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0232f7c6_dcb9474c","updated":"2024-04-30 11:44:31.000000000","message":"How did you figure this out? Are you running a specific linter?","commit_id":"13278bc6893153ffe5de54a5d96f57cd8668606d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2f4a664c410c1d250c13a45e16ea19afeb360f80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9cff0b46_89e1e78e","updated":"2024-04-30 11:48:35.000000000","message":"Question inline.","commit_id":"13278bc6893153ffe5de54a5d96f57cd8668606d"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"dbb0dd70195033ea519b1f6f54d2a5333763f0f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3ae0f1ba_7aa04f84","updated":"2024-09-03 14:13:56.000000000","message":"I edited the commit message.","commit_id":"c4a0a94e60412cca18e7c3eeecd460f4c95afc22"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"22f0c2558c90647ef1f7214691946288ed909deb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"25797524_f4ed6fa3","updated":"2024-09-04 02:17:33.000000000","message":"No objection from me.","commit_id":"c4a0a94e60412cca18e7c3eeecd460f4c95afc22"}],"glance/cmd/control.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2f4a664c410c1d250c13a45e16ea19afeb360f80","unresolved":true,"context_lines":[{"line_number":173,"context_line":"                msg \u003d (_(\u0027unable to launch %(serv)s. Got error: %(e)s\u0027) %"},{"line_number":174,"context_line":"                       {\u0027serv\u0027: server, \u0027e\u0027: e})"},{"line_number":175,"context_line":"                sys.exit(msg)"},{"line_number":176,"context_line":"            sys.exit(0)"},{"line_number":177,"context_line":"        else:"},{"line_number":178,"context_line":"            write_pid_file(pid_file, pid)"},{"line_number":179,"context_line":"            await_child(pid, await_time)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9cfd5f81_1670624d","side":"PARENT","line":176,"updated":"2024-04-30 11:48:35.000000000","message":"Could you explain why this is unreachable? Seems like if there\u0027s no exception raised at line 171, it will be executed.","commit_id":"309ca3aec26b6dd49b8d955c4900a5c390d14537"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"f664c334616644a599643c69e944d77babb2c19d","unresolved":true,"context_lines":[{"line_number":173,"context_line":"                msg \u003d (_(\u0027unable to launch %(serv)s. Got error: %(e)s\u0027) %"},{"line_number":174,"context_line":"                       {\u0027serv\u0027: server, \u0027e\u0027: e})"},{"line_number":175,"context_line":"                sys.exit(msg)"},{"line_number":176,"context_line":"            sys.exit(0)"},{"line_number":177,"context_line":"        else:"},{"line_number":178,"context_line":"            write_pid_file(pid_file, pid)"},{"line_number":179,"context_line":"            await_child(pid, await_time)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6da01df0_12966ad8","side":"PARENT","line":176,"in_reply_to":"9cfd5f81_1670624d","updated":"2024-09-03 14:10:42.000000000","message":"According to the docs[1]:\n\n\"These functions all execute a new program, replacing the current process; they do not return\".\n\nSo we indeed never reach sys.exit(0).\n\n[1] https://docs.python.org/3/library/os.html#os.execlp","commit_id":"309ca3aec26b6dd49b8d955c4900a5c390d14537"}]}