)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"ece7c10b71cc2ace07d04c02010a1f5f0f0930b5","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nothing uses this yet but that will come soon. We also rename \u0027[DEFAULT]"},{"line_number":10,"context_line":"hashing_algorithm\u0027 to \u0027[DEFAULT] default_hashing_algorithm\u0027."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I43ac62029637c015d6befe9071f1b594e9eec4c2"},{"line_number":13,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"a007007c_9dcfc6a9","line":11,"updated":"2024-10-01 07:06:34.000000000","message":"Need blueprint details with Implements tag.","commit_id":"3a38d00fba5605091c9a48656f5e7a272dd738e9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"1271446164c6afc71141d25b67e036f9b224d052","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"55bdfb96_a41e777f","updated":"2024-09-03 07:47:22.000000000","message":"LGTM, Thanks for the patch!","commit_id":"3a0eddce89f5949ea581909fc2dc271fce842f98"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"73d23ac2e93dda04d94db044b5c1a85838d5eabd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ab72f99c_bd6cf0ae","updated":"2024-09-03 07:46:36.000000000","message":"recheck","commit_id":"3a0eddce89f5949ea581909fc2dc271fce842f98"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"ece7c10b71cc2ace07d04c02010a1f5f0f0930b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"740966c7_d0ccccbc","updated":"2024-10-01 07:06:34.000000000","message":"Please add a releasenote as well.","commit_id":"3a38d00fba5605091c9a48656f5e7a272dd738e9"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"b9402c4ffbc7a139c374158067f28cb85439f15f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"07009980_80f18868","updated":"2024-10-01 07:03:47.000000000","message":"recheck","commit_id":"3a38d00fba5605091c9a48656f5e7a272dd738e9"}],"etc/glance-api.conf":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"41ebeac59b8b1ce2eb72b41d63d686bef86c8a18","unresolved":false,"context_lines":[{"line_number":104,"context_line":"#"},{"line_number":105,"context_line":"# Related options:"},{"line_number":106,"context_line":"#     * None"},{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":"#  (integer value)"},{"line_number":109,"context_line":"#image_member_quota \u003d 128"},{"line_number":110,"context_line":""}],"source_content_type":"text/plain","patch_set":1,"id":"86d25c42_b3763659","side":"PARENT","line":107,"updated":"2024-06-17 15:46:09.000000000","message":"All these changes are unrelated and are coming in because it\u0027s been a while since we regenerated these docs, evidently.","commit_id":"dfbfdad77fdc91899f64d2ff186097cfb2065ab7"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"9e463fee8d0342ccd36c5ce70ce02648e515c009","unresolved":false,"context_lines":[{"line_number":104,"context_line":"#"},{"line_number":105,"context_line":"# Related options:"},{"line_number":106,"context_line":"#     * None"},{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":"#  (integer value)"},{"line_number":109,"context_line":"#image_member_quota \u003d 128"},{"line_number":110,"context_line":""}],"source_content_type":"text/plain","patch_set":1,"id":"9103398b_f6011c58","side":"PARENT","line":107,"in_reply_to":"86d25c42_b3763659","updated":"2024-06-21 16:00:41.000000000","message":"Could we have a patch that regenerates the doc as the first patch in your patch series, then?","commit_id":"dfbfdad77fdc91899f64d2ff186097cfb2065ab7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"35cae370450e5a3db8b7aa3284878a62593a22ae","unresolved":false,"context_lines":[{"line_number":104,"context_line":"#"},{"line_number":105,"context_line":"# Related options:"},{"line_number":106,"context_line":"#     * None"},{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":"#  (integer value)"},{"line_number":109,"context_line":"#image_member_quota \u003d 128"},{"line_number":110,"context_line":""}],"source_content_type":"text/plain","patch_set":1,"id":"34a2a804_3f23cab6","side":"PARENT","line":107,"in_reply_to":"9103398b_f6011c58","updated":"2024-08-20 13:46:10.000000000","message":"Done","commit_id":"dfbfdad77fdc91899f64d2ff186097cfb2065ab7"}],"glance/common/config.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"420ba23555e0614d21b059113f528026c5aef53c","unresolved":true,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"Related options:"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"* ``[DEFAULT] hashing_algorithm`` determines the default hashing algorithm to"},{"line_number":223,"context_line":"  use if the user does not provide an algorithm."},{"line_number":224,"context_line":"\"\"\"),"},{"line_number":225,"context_line":"    ),"}],"source_content_type":"text/x-python","patch_set":3,"id":"c407b3b0_8c7b2625","line":222,"range":{"start_line":222,"start_character":14,"end_line":222,"end_character":31},"updated":"2024-09-09 09:13:33.000000000","message":"This should be default_hashing_algorithm .","commit_id":"3a0eddce89f5949ea581909fc2dc271fce842f98"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a1298909ed118d1decf29058e5d8840ce969df85","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"Related options:"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"* ``[DEFAULT] hashing_algorithm`` determines the default hashing algorithm to"},{"line_number":223,"context_line":"  use if the user does not provide an algorithm."},{"line_number":224,"context_line":"\"\"\"),"},{"line_number":225,"context_line":"    ),"}],"source_content_type":"text/x-python","patch_set":3,"id":"62aef82a_ab878f0a","line":222,"range":{"start_line":222,"start_character":14,"end_line":222,"end_character":31},"in_reply_to":"c407b3b0_8c7b2625","updated":"2024-09-17 11:20:05.000000000","message":"Done","commit_id":"3a0eddce89f5949ea581909fc2dc271fce842f98"}],"glance/location.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"9e463fee8d0342ccd36c5ce70ce02648e515c009","unresolved":true,"context_lines":[{"line_number":472,"context_line":"        \"\"\""},{"line_number":473,"context_line":"        hashing_algo \u003d ("},{"line_number":474,"context_line":"            self.image.os_hash_algo or CONF[\u0027default_hashing_algorithm\u0027]"},{"line_number":475,"context_line":"        )"},{"line_number":476,"context_line":"        if CONF.enabled_backends:"},{"line_number":477,"context_line":"            (location, size, checksum,"},{"line_number":478,"context_line":"             multihash, loc_meta) \u003d self.store_api.add_with_multihash("}],"source_content_type":"text/x-python","patch_set":1,"id":"84e09883_a0ab2ec8","line":475,"range":{"start_line":475,"start_character":8,"end_line":475,"end_character":9},"updated":"2024-06-21 16:00:41.000000000","message":"Shouldn\u0027t we make sure that hashing_algo is part of CONF.allowed_hashing_algorithms?\n\nI can imagine an admin misconfiguring Glance and having something like this in their config file:\n\ndefault_hash_algorithm\u003dsha512\nallowed_hash_algorithms\u003d[\u0027sha256\u0027]","commit_id":"f4d6afc7c2e35a051c777bf0c92e1c8ddbc99e6e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3b4b451432854164707804ff293bf15207f5b6b8","unresolved":false,"context_lines":[{"line_number":472,"context_line":"        \"\"\""},{"line_number":473,"context_line":"        hashing_algo \u003d ("},{"line_number":474,"context_line":"            self.image.os_hash_algo or CONF[\u0027default_hashing_algorithm\u0027]"},{"line_number":475,"context_line":"        )"},{"line_number":476,"context_line":"        if CONF.enabled_backends:"},{"line_number":477,"context_line":"            (location, size, checksum,"},{"line_number":478,"context_line":"             multihash, loc_meta) \u003d self.store_api.add_with_multihash("}],"source_content_type":"text/x-python","patch_set":1,"id":"f76e9ae1_7ed8c1ff","line":475,"range":{"start_line":475,"start_character":8,"end_line":475,"end_character":9},"in_reply_to":"1e8ff336_b4ef374c","updated":"2024-08-20 15:29:56.000000000","message":"Done","commit_id":"f4d6afc7c2e35a051c777bf0c92e1c8ddbc99e6e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"35cae370450e5a3db8b7aa3284878a62593a22ae","unresolved":true,"context_lines":[{"line_number":472,"context_line":"        \"\"\""},{"line_number":473,"context_line":"        hashing_algo \u003d ("},{"line_number":474,"context_line":"            self.image.os_hash_algo or CONF[\u0027default_hashing_algorithm\u0027]"},{"line_number":475,"context_line":"        )"},{"line_number":476,"context_line":"        if CONF.enabled_backends:"},{"line_number":477,"context_line":"            (location, size, checksum,"},{"line_number":478,"context_line":"             multihash, loc_meta) \u003d self.store_api.add_with_multihash("}],"source_content_type":"text/x-python","patch_set":1,"id":"1e8ff336_b4ef374c","line":475,"range":{"start_line":475,"start_character":8,"end_line":475,"end_character":9},"in_reply_to":"84e09883_a0ab2ec8","updated":"2024-08-20 13:46:10.000000000","message":"Good point. Done.","commit_id":"f4d6afc7c2e35a051c777bf0c92e1c8ddbc99e6e"}]}