)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"9a92bb31ba0ef3c904d61777c78a96c929c250ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bd4f41f0_9ec05073","updated":"2024-07-09 07:09:31.000000000","message":"LGTM, Thank you !!","commit_id":"d6f50be9f7eb33275226a034db4689b4c8966ef9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"05d6a529612755ac77f403cdcb33d00cf27944bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cc077f68_cbe44e96","updated":"2024-08-01 14:23:17.000000000","message":"One comment, let me put this in my test machine and run through it.","commit_id":"d6f50be9f7eb33275226a034db4689b4c8966ef9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1608f7d630982bc8712998385a073c7bc99bfe31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ebd36529_d6c62a2b","updated":"2024-08-01 14:28:52.000000000","message":"Will push a new PS soon!","commit_id":"d6f50be9f7eb33275226a034db4689b4c8966ef9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"160f80ce5ca6d1d2228429395390ff535fc89915","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"44699f1a_002ce1ae","updated":"2024-07-08 13:24:52.000000000","message":"recheck ssh timeout","commit_id":"d6f50be9f7eb33275226a034db4689b4c8966ef9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5c64a8c132075b65aef0bbcfb786516a5f4ceb50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e74b47d7_1c7b3ea0","updated":"2024-07-08 16:08:40.000000000","message":"recheck volume failed to reach expected state","commit_id":"d6f50be9f7eb33275226a034db4689b4c8966ef9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"76244d7c83df166b0bf7ab1dc11701bfc4223a82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9f616f20_e1bb105b","updated":"2024-07-08 19:44:54.000000000","message":"recheck volume failed to reach expected state again","commit_id":"d6f50be9f7eb33275226a034db4689b4c8966ef9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5d939167b95b3e186365819a2cec499a5ce7007e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ac2c736c_791f0fd4","updated":"2024-08-01 15:17:23.000000000","message":"Abhi is going to follow up with extra tests. I\u0027ve confirmed this works in devstack, so we can trust him :)","commit_id":"e79ad07d8309a65eeada5235ceda886e262037c7"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"e70b8a6c6c8304cca163781b259d03b0fd386524","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"29486328_e3afb15d","updated":"2024-08-01 14:52:48.000000000","message":"Hm, I feel Dan\u0027s comments have not been adressed here :/","commit_id":"e79ad07d8309a65eeada5235ceda886e262037c7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e528ecf4f1c1c36016f287b55f7b22b0cf5bc009","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4d8daf8c_834b04bb","updated":"2024-08-01 16:39:54.000000000","message":"I didn\u0027t look at the coverage report, but looks like we should be good here now, thanks.","commit_id":"ea131dd1442861cb5884f99b6bb9e47e397605ce"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"8a290f815f908c615f225f9c2ac12e777a45d5ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b3464957_46359092","updated":"2024-08-02 16:04:20.000000000","message":"Thanks for the tests!","commit_id":"ea131dd1442861cb5884f99b6bb9e47e397605ce"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f1c7e320287e8914b26e3c8dac3485b0a1fd906a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ae1c1f4a_36d60797","updated":"2024-08-02 07:38:23.000000000","message":"recheck glance remote service failed to start","commit_id":"ea131dd1442861cb5884f99b6bb9e47e397605ce"}],"glance/async_/flows/plugins/image_conversion.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"40cef011ddcd4799ed69a5edacd7e12a7f77acc4","unresolved":true,"context_lines":[{"line_number":225,"context_line":"        # to move all stores out of \"importing\" and into \"failed\"."},{"line_number":226,"context_line":"        with self.action_wrapper as action:"},{"line_number":227,"context_line":"            action.set_image_attribute(status\u003d\u0027queued\u0027)"},{"line_number":228,"context_line":"            if self.stores:"},{"line_number":229,"context_line":"                action.remove_importing_stores(self.stores)"},{"line_number":230,"context_line":"                action.add_failed_stores(self.stores)"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"30ed067d_a2ae0ffe","line":228,"updated":"2024-08-01 14:44:49.000000000","message":"No tst coverage for when this is false? When would it be? If multistore is disabled or something?","commit_id":"d6f50be9f7eb33275226a034db4689b4c8966ef9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"465c8118566cd9987b6b86fa1ac698c6132d7d5d","unresolved":true,"context_lines":[{"line_number":225,"context_line":"        # to move all stores out of \"importing\" and into \"failed\"."},{"line_number":226,"context_line":"        with self.action_wrapper as action:"},{"line_number":227,"context_line":"            action.set_image_attribute(status\u003d\u0027queued\u0027)"},{"line_number":228,"context_line":"            if self.stores:"},{"line_number":229,"context_line":"                action.remove_importing_stores(self.stores)"},{"line_number":230,"context_line":"                action.add_failed_stores(self.stores)"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8ab10976_7b7386df","line":228,"in_reply_to":"30ed067d_a2ae0ffe","updated":"2024-08-01 14:46:50.000000000","message":"I think if multistore is disabled","commit_id":"d6f50be9f7eb33275226a034db4689b4c8966ef9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"7de8f2042ba9c87304b8fbdc1667478c59d67a18","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        # to move all stores out of \"importing\" and into \"failed\"."},{"line_number":226,"context_line":"        with self.action_wrapper as action:"},{"line_number":227,"context_line":"            action.set_image_attribute(status\u003d\u0027queued\u0027)"},{"line_number":228,"context_line":"            if self.stores:"},{"line_number":229,"context_line":"                action.remove_importing_stores(self.stores)"},{"line_number":230,"context_line":"                action.add_failed_stores(self.stores)"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"552a4528_91319aef","line":228,"in_reply_to":"8ab10976_7b7386df","updated":"2024-08-01 16:37:18.000000000","message":"Done","commit_id":"d6f50be9f7eb33275226a034db4689b4c8966ef9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"05d6a529612755ac77f403cdcb33d00cf27944bc","unresolved":true,"context_lines":[{"line_number":230,"context_line":"                action.add_failed_stores(self.stores)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        if self.src_path:"},{"line_number":233,"context_line":"            os.remove(self.src_path)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"def get_flow(**kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"cdde49da_1e2ca63b","line":233,"updated":"2024-08-01 14:23:17.000000000","message":"Might not matter, but maybe `try...except FileNotFoundError` just to make sure you don\u0027t fail here with a stack trace?","commit_id":"d6f50be9f7eb33275226a034db4689b4c8966ef9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b882ece0b833d3cd040dc104603e280c1771a6ef","unresolved":true,"context_lines":[{"line_number":230,"context_line":"                action.add_failed_stores(self.stores)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        if self.src_path:"},{"line_number":233,"context_line":"            os.remove(self.src_path)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"def get_flow(**kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"6f235dd5_0bc4b310","line":233,"in_reply_to":"40b1ae2a_dbf71feb","updated":"2024-08-01 14:48:01.000000000","message":"will try to add coverage for it, I need to mock the call though.","commit_id":"d6f50be9f7eb33275226a034db4689b4c8966ef9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"7de8f2042ba9c87304b8fbdc1667478c59d67a18","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                action.add_failed_stores(self.stores)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        if self.src_path:"},{"line_number":233,"context_line":"            os.remove(self.src_path)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"def get_flow(**kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9092105c_4af4ce0b","line":233,"in_reply_to":"6f235dd5_0bc4b310","updated":"2024-08-01 16:37:18.000000000","message":"Done","commit_id":"d6f50be9f7eb33275226a034db4689b4c8966ef9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1608f7d630982bc8712998385a073c7bc99bfe31","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                action.add_failed_stores(self.stores)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        if self.src_path:"},{"line_number":233,"context_line":"            os.remove(self.src_path)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"def get_flow(**kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"b0eb32c5_ac9e27cc","line":233,"in_reply_to":"cdde49da_1e2ca63b","updated":"2024-08-01 14:28:52.000000000","message":"Acknowledged","commit_id":"d6f50be9f7eb33275226a034db4689b4c8966ef9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"40cef011ddcd4799ed69a5edacd7e12a7f77acc4","unresolved":true,"context_lines":[{"line_number":230,"context_line":"                action.add_failed_stores(self.stores)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        if self.src_path:"},{"line_number":233,"context_line":"            os.remove(self.src_path)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"def get_flow(**kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"40b1ae2a_dbf71feb","line":233,"in_reply_to":"cdde49da_1e2ca63b","updated":"2024-08-01 14:44:49.000000000","message":"Also no test coverage for this it looks like...","commit_id":"d6f50be9f7eb33275226a034db4689b4c8966ef9"}]}