)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0b46f30d123b708edbf19238327a45f5c9d7bb9e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add new wait logic for functional test of add location API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some add location functional tests fail intermittently since"},{"line_number":10,"context_line":"in currect wait logic, wait call returns as soon as the image"},{"line_number":11,"context_line":"reaches to expected status but hash calculation doens\u0027t get"},{"line_number":12,"context_line":"completed sometimes within the provided time stamp."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"525c7897_52d918b9","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":10},"updated":"2024-08-28 14:24:11.000000000","message":"current?","commit_id":"0c7c753c26737d0055d2b26590c720629b5868ea"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"d981166ced02bf15afe3e2291017ee4638327ff3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add new wait logic for functional test of add location API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some add location functional tests fail intermittently since"},{"line_number":10,"context_line":"in currect wait logic, wait call returns as soon as the image"},{"line_number":11,"context_line":"reaches to expected status but hash calculation doens\u0027t get"},{"line_number":12,"context_line":"completed sometimes within the provided time stamp."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"32fa839c_37a3af16","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":10},"in_reply_to":"525c7897_52d918b9","updated":"2024-08-28 15:16:37.000000000","message":"Done","commit_id":"0c7c753c26737d0055d2b26590c720629b5868ea"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0b46f30d123b708edbf19238327a45f5c9d7bb9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8a91ef1d_bc4b3f83","updated":"2024-08-28 14:24:11.000000000","message":"Thanks for looking into this","commit_id":"0c7c753c26737d0055d2b26590c720629b5868ea"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"d981166ced02bf15afe3e2291017ee4638327ff3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"92987b49_f4adfb23","updated":"2024-08-28 15:16:37.000000000","message":"Thanks for the review Abhishek and Dan !!","commit_id":"94b5a4f9a616b31e545fa5f5d4108bdd62872256"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"bea47df430351c9fd3c0f66d422d87d22d314ed9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dbf47329_c0c2891c","updated":"2024-08-29 14:25:32.000000000","message":"LGTM, Thanks!","commit_id":"ca40d49f4ddddfe9cf8df6f234d816b9a2784a2c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a36578888a11649264857dff8a2303ff3e013491","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dcd4e70c_8b78abf0","updated":"2024-08-29 14:25:39.000000000","message":"Looks like feedback has been addressed","commit_id":"ca40d49f4ddddfe9cf8df6f234d816b9a2784a2c"}],"glance/tests/functional/ft_utils.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5a15824168a487c1d69eaf94a903ca23b7aa6eac","unresolved":true,"context_lines":[{"line_number":137,"context_line":"            return"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        time.sleep(delay_sec)"},{"line_number":140,"context_line":"    msg \u003d \"Entity {0} failed to reach status \u0027{1}\u0027 within {2} sec\""},{"line_number":141,"context_line":"    raise Exception(msg.format(image_id, status, max_sec))"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"def wait_for_copying(request_path, request_headers, stores\u003d[],"},{"line_number":145,"context_line":"                     max_sec\u003d10, delay_sec\u003d0.2, start_delay_sec\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2bfc404b_e334a202","line":142,"range":{"start_line":140,"start_character":3,"end_line":142,"end_character":1},"updated":"2024-08-28 13:38:42.000000000","message":"I think here you should also check if checksum is not set and give the error message accordingly.","commit_id":"0c7c753c26737d0055d2b26590c720629b5868ea"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"d981166ced02bf15afe3e2291017ee4638327ff3","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            return"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        time.sleep(delay_sec)"},{"line_number":140,"context_line":"    msg \u003d \"Entity {0} failed to reach status \u0027{1}\u0027 within {2} sec\""},{"line_number":141,"context_line":"    raise Exception(msg.format(image_id, status, max_sec))"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"def wait_for_copying(request_path, request_headers, stores\u003d[],"},{"line_number":145,"context_line":"                     max_sec\u003d10, delay_sec\u003d0.2, start_delay_sec\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e23301a0_0662acee","line":142,"range":{"start_line":140,"start_character":3,"end_line":142,"end_character":1},"in_reply_to":"2bfc404b_e334a202","updated":"2024-08-28 15:16:37.000000000","message":"Done","commit_id":"0c7c753c26737d0055d2b26590c720629b5868ea"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2ed187441201c6366a69bdb7e9654cb7e1dff355","unresolved":true,"context_lines":[{"line_number":137,"context_line":"            return"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        time.sleep(delay_sec)"},{"line_number":140,"context_line":"    if image[\u0027checksum\u0027] is None and image[\u0027status\u0027] !\u003d status:"},{"line_number":141,"context_line":"        msg \u003d (\"Entity {0} failed to complete hash caclulation and \""},{"line_number":142,"context_line":"               \"reach to expected status \u0027{1}\u0027 within {2} sec\")"},{"line_number":143,"context_line":"        raise Exception(msg.format(image_id, status, max_sec))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def wait_for_copying(request_path, request_headers, stores\u003d[],"}],"source_content_type":"text/x-python","patch_set":2,"id":"ecd74480_d10dc9e0","line":143,"range":{"start_line":140,"start_character":5,"end_line":143,"end_character":62},"updated":"2024-08-28 15:20:28.000000000","message":"You should have different message for above condition\n\nif image checksum is None:\n   message and raise\n\nif image status !\u003d status:\n    message and raise","commit_id":"94b5a4f9a616b31e545fa5f5d4108bdd62872256"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"d9eed7205edb27a840d1249a70b95eb982529d9c","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            return"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        time.sleep(delay_sec)"},{"line_number":140,"context_line":"    if image[\u0027checksum\u0027] is None and image[\u0027status\u0027] !\u003d status:"},{"line_number":141,"context_line":"        msg \u003d (\"Entity {0} failed to complete hash caclulation and \""},{"line_number":142,"context_line":"               \"reach to expected status \u0027{1}\u0027 within {2} sec\")"},{"line_number":143,"context_line":"        raise Exception(msg.format(image_id, status, max_sec))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def wait_for_copying(request_path, request_headers, stores\u003d[],"}],"source_content_type":"text/x-python","patch_set":2,"id":"53777020_b17f1b3c","line":143,"range":{"start_line":140,"start_character":5,"end_line":143,"end_character":62},"in_reply_to":"ecd74480_d10dc9e0","updated":"2024-08-29 06:07:29.000000000","message":"Done","commit_id":"94b5a4f9a616b31e545fa5f5d4108bdd62872256"}]}