)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"a6ec64a0ed3c7c4e0f8bd3998bacc60cce92bbaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6ded57b4_f6470bfc","updated":"2024-09-25 17:41:56.000000000","message":"Please rebase this before PTG, and we\u0027ll confirm that Windows support is something we want to see removed.","commit_id":"0ee897ce0b083d50bd95b4bf1c673be49d4d3b89"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9468b6bd875ba943a6314e9ee31f642933222be4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"62a98869_646168f9","in_reply_to":"6ded57b4_f6470bfc","updated":"2024-09-26 00:59:44.000000000","message":"Done.","commit_id":"0ee897ce0b083d50bd95b4bf1c673be49d4d3b89"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d4eac5c9e16aa12775fac45cd7cafc3c4a5afccc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"22cb2bc2_84323190","updated":"2024-09-27 13:31:08.000000000","message":"recheck","commit_id":"67aa07da72f095264ed2b9fb391d63edfb0b69d8"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"acf43a59b8824621deefd2d94a7b9ca843688465","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aee3f29f_f119f66b","updated":"2024-10-29 15:39:33.000000000","message":"I think in glance/common/wsgi.py, you could remove:\n\n- the pipe-handle option\n- the use of pipe_handle in get_num_workers\n\nAnd then it would all be gone!","commit_id":"ced6e689b2f03b5974ccfd796f2e44332c043535"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1b5c5dd679ee40dea0d55cbdc84b2d5cf3582cf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ff2704d8_860f604b","in_reply_to":"aee3f29f_f119f66b","updated":"2024-10-29 15:48:31.000000000","message":"Oh yes. That\u0027s definitely a good catch. I also made a few more cleanups since wsgi server no longer require any cli options.","commit_id":"ced6e689b2f03b5974ccfd796f2e44332c043535"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"0a9d5f75979de47a8b5f125bbf44be3108d30bf2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d8ad1e67_c91ebb7c","updated":"2024-10-29 15:54:43.000000000","message":"Thanks for the quick patch! You will hate me, but I think we also want to edit:\n\n- lines 31 to 34 in doc/source/admin/requirements.rst\n- there is a mention of Windows at lines 1689-1690 of doc/source/configuration/configuring.rst","commit_id":"ecbbe5faf93f099963d9c8d8875bef32f2f5da67"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"0889f45bec8bbe4db99e6f069c8cfe959652abec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8ea12bcd_253d8c8c","updated":"2024-10-29 16:25:58.000000000","message":"Great, thanks!","commit_id":"acab9351a1fa124f2bdeb58d2f407070071dc9d2"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"a54017ccbe4076d4429052ee7f4010da3a10baa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6d4d0e3b_c3b8fc70","updated":"2024-10-29 16:49:57.000000000","message":"Technically we\u0027re waiting on TC to confirm it\u0027s ok to do this, but I\u0027m not too worried.","commit_id":"acab9351a1fa124f2bdeb58d2f407070071dc9d2"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"0a0f3db3d96df554e0206820bea73f5a6de0b25f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a0448836_9735fc1f","updated":"2024-10-30 15:21:15.000000000","message":"Thanks, gmann!","commit_id":"acab9351a1fa124f2bdeb58d2f407070071dc9d2"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"cd192127369cba336f6ffa95e423f444aa669afe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"da6ddd43_af496fa8","updated":"2024-10-30 10:01:17.000000000","message":"recheck failed to delete image property with error, Oct 29 20:08:03.600482 np0038915941 devstack@g-api.service[87397]: ERROR glance.common.wsgi sqlalchemy.exc.InvalidRequestError: Can\u0027t operate on closed transaction inside context manager.  Please complete the context manager before emitting further commands.","commit_id":"acab9351a1fa124f2bdeb58d2f407070071dc9d2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac77356c05148626f000a3031ba42173f53e3674","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"34aa14f9_bdb00860","updated":"2024-10-31 03:20:08.000000000","message":"recheck the failures were not seen before. Let\u0027s see if these are consistent ones","commit_id":"acab9351a1fa124f2bdeb58d2f407070071dc9d2"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6129dea5a09607bd8477f08f2d7223b48aaf8226","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"43156e76_3fda84a4","updated":"2024-10-29 19:13:08.000000000","message":"recheck, unrelated network error","commit_id":"acab9351a1fa124f2bdeb58d2f407070071dc9d2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e920fd39d8b04753c1fed2e8270b55c5a7683df9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d2be310b_275fc5da","in_reply_to":"6d4d0e3b_c3b8fc70","updated":"2024-10-29 18:03:10.000000000","message":"We are good to remove it as it was deprecated in 2024.1. More than deprecation, it went untestd and unmaintained when we removed the os-win in 2023.2 so anyone impacted due to this could have come forward till now. \n\nWe also announced it many times in ML, and I talked to the foundation staff to check with Microsoft if they are interested in maintaining it after the Cloudbase company went away. But no interested party on this. So removing it is right thing to do.","commit_id":"acab9351a1fa124f2bdeb58d2f407070071dc9d2"}],"glance/tests/utils.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"a6ec64a0ed3c7c4e0f8bd3998bacc60cce92bbaf","unresolved":true,"context_lines":[{"line_number":177,"context_line":"        # If really needed, on Py3 we can get the clock resolution using"},{"line_number":178,"context_line":"        # time.get_clock_info, but at that point we may as well just sleep 1ms"},{"line_number":179,"context_line":"        # all the time."},{"line_number":180,"context_line":"        pass"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"class requires(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"278a29bd_57f55bd6","line":180,"updated":"2024-09-25 17:41:56.000000000","message":"The comment alone does not make much sense anymore: \"we may as well just sleep 1ms\"... but we don\u0027t.\n\nMaybe we could remove this method since this has never been used on a Unix system?","commit_id":"0ee897ce0b083d50bd95b4bf1c673be49d4d3b89"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9468b6bd875ba943a6314e9ee31f642933222be4","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        # If really needed, on Py3 we can get the clock resolution using"},{"line_number":178,"context_line":"        # time.get_clock_info, but at that point we may as well just sleep 1ms"},{"line_number":179,"context_line":"        # all the time."},{"line_number":180,"context_line":"        pass"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"class requires(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"68f116d6_1a44822e","line":180,"in_reply_to":"278a29bd_57f55bd6","updated":"2024-09-26 00:59:44.000000000","message":"+1. I\u0027ve removed this and run unit/functional tests in my local but don\u0027t see any failures immediately so I think we can drop it now.","commit_id":"0ee897ce0b083d50bd95b4bf1c673be49d4d3b89"}]}