)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"589e0550527dd14fd059e497de60212837ab5488","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cdfc5cd9_8eb007d6","updated":"2024-10-01 14:55:17.000000000","message":"Is there a spec for this cross-project work?","commit_id":"185caea313f3afe46da13c320322cf777caaf5b5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bebddfa7b547deade6e5386c4c6a894be7e6630a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"65854685_bc5eebde","in_reply_to":"cdfc5cd9_8eb007d6","updated":"2024-10-01 15:07:24.000000000","message":"This is the glance-only part, spec in the commit message.","commit_id":"185caea313f3afe46da13c320322cf777caaf5b5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"acc39018c863494ee2ae2ca257a3ac74b2db9611","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b6aa3318_eb85fd83","updated":"2024-10-02 18:32:19.000000000","message":"recheck tempest updated","commit_id":"25d78d47475d200a824b6b8ea912aa05862f6863"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"80e749a13d556eed703c191514e4d107a98bfc7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0b501b43_96a9b682","updated":"2024-10-15 07:03:15.000000000","message":"I don\u0027t know we still follow flags in commit message if so then this definitely warrant for DocImpact flag, else looks good to me.","commit_id":"89e3c61ba130767f47a974361d2d53b1ce698d3b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"343b3c9c8063ed1247b34b8af8cf30ba0b7b7e11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e8c5e182_aee5a752","updated":"2024-10-03 17:08:48.000000000","message":"recheck known glance issue when deleting images","commit_id":"89e3c61ba130767f47a974361d2d53b1ce698d3b"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"6c95da9bce83ac05c0da9b90ad1e5c0c15db4a3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"56121471_745e0927","updated":"2025-02-20 20:55:16.000000000","message":"A couple of things I do not understand","commit_id":"41c4b384e3769a70c3eac703959973bef2836021"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"79233b2ba23b88f144cd78d8acf3ae3077fbbd63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"94e03ea7_cefdafab","updated":"2025-02-24 15:20:22.000000000","message":"OK, all good now!","commit_id":"7c748d3857ae71682ff4a5b28e292389281caf1d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e60f81aa5ec12b87510878f8df966c5c581942c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ae92201b_e32b57fc","updated":"2025-02-24 18:17:16.000000000","message":"recheck unrelated cinder timeout","commit_id":"7c748d3857ae71682ff4a5b28e292389281caf1d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"bad33fa424a23cb9e8f345a197dbc3849a9947ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"930e3045_bcc3a821","updated":"2025-02-24 18:19:43.000000000","message":"thank you!!","commit_id":"7c748d3857ae71682ff4a5b28e292389281caf1d"}],"glance/location.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"80e749a13d556eed703c191514e4d107a98bfc7c","unresolved":true,"context_lines":[{"line_number":594,"context_line":"        else:"},{"line_number":595,"context_line":"            # FIXME(danms): Either warn here if we are unable to inspect non-"},{"line_number":596,"context_line":"            # bare images or maybe make this a hard fail"},{"line_number":597,"context_line":"            pass"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        try:"},{"line_number":600,"context_line":"            self._upload_to_store(data, verifier, backend, size)"},{"line_number":601,"context_line":"        except format_inspector.ImageFormatError as e:"}],"source_content_type":"text/x-python","patch_set":8,"id":"abda41cf_4c1d2b2d","line":598,"range":{"start_line":597,"start_character":12,"end_line":598,"end_character":1},"updated":"2024-10-15 07:03:15.000000000","message":"Instead of pass can we log debug statement here?","commit_id":"89e3c61ba130767f47a974361d2d53b1ce698d3b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c4b64ecc8abe27cc1e1332022e4cff15a1960dc3","unresolved":true,"context_lines":[{"line_number":594,"context_line":"        else:"},{"line_number":595,"context_line":"            # FIXME(danms): Either warn here if we are unable to inspect non-"},{"line_number":596,"context_line":"            # bare images or maybe make this a hard fail"},{"line_number":597,"context_line":"            pass"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        try:"},{"line_number":600,"context_line":"            self._upload_to_store(data, verifier, backend, size)"},{"line_number":601,"context_line":"        except format_inspector.ImageFormatError as e:"}],"source_content_type":"text/x-python","patch_set":8,"id":"daa0c62f_43f33b5d","line":598,"range":{"start_line":597,"start_character":12,"end_line":598,"end_character":1},"in_reply_to":"abda41cf_4c1d2b2d","updated":"2024-10-15 13:48:35.000000000","message":"Yes (in the comment) but I thought we might want to discuss if we want to reject containers we can\u0027t inspect. I think nova only really supports bare, so maybe it doesn\u0027t matter (for nova) but if the operator wants all images inspected, it seems weird to let people bypass this just because they compress the image. Technically we should be able to decompress on the fly if we want, but the other containers will be much harder.","commit_id":"89e3c61ba130767f47a974361d2d53b1ce698d3b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"616075e051d982720add0e3328c8d971f72919fd","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        else:"},{"line_number":595,"context_line":"            # FIXME(danms): Either warn here if we are unable to inspect non-"},{"line_number":596,"context_line":"            # bare images or maybe make this a hard fail"},{"line_number":597,"context_line":"            pass"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        try:"},{"line_number":600,"context_line":"            self._upload_to_store(data, verifier, backend, size)"},{"line_number":601,"context_line":"        except format_inspector.ImageFormatError as e:"}],"source_content_type":"text/x-python","patch_set":8,"id":"6bfa7153_37977367","line":598,"range":{"start_line":597,"start_character":12,"end_line":598,"end_character":1},"in_reply_to":"daa0c62f_43f33b5d","updated":"2024-11-25 06:29:01.000000000","message":"Acknowledged","commit_id":"89e3c61ba130767f47a974361d2d53b1ce698d3b"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"6c95da9bce83ac05c0da9b90ad1e5c0c15db4a3e","unresolved":true,"context_lines":[{"line_number":590,"context_line":"                kwargs[\u0027expected_format\u0027] \u003d self.image.disk_format"},{"line_number":591,"context_line":"                LOG.debug(\u0027Enabling in-flight format inspection for %s\u0027,"},{"line_number":592,"context_line":"                          self.image.disk_format)"},{"line_number":593,"context_line":"            data \u003d format_inspector.InspectWrapper(data)"},{"line_number":594,"context_line":"        else:"},{"line_number":595,"context_line":"            # FIXME(danms): Either warn here if we are unable to inspect non-"},{"line_number":596,"context_line":"            # bare images or maybe make this a hard fail"}],"source_content_type":"text/x-python","patch_set":11,"id":"03a89610_483105a1","line":593,"range":{"start_line":593,"start_character":0,"end_line":593,"end_character":12},"updated":"2025-02-20 20:55:16.000000000","message":"It does not seem like we\u0027re using kwargs here. Did you mean:\n\ndata \u003d format_inspector.InspectWrapper(data, **kwargs) ?","commit_id":"41c4b384e3769a70c3eac703959973bef2836021"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a050db63fd996946c3ea11200998e6577a982739","unresolved":true,"context_lines":[{"line_number":590,"context_line":"                kwargs[\u0027expected_format\u0027] \u003d self.image.disk_format"},{"line_number":591,"context_line":"                LOG.debug(\u0027Enabling in-flight format inspection for %s\u0027,"},{"line_number":592,"context_line":"                          self.image.disk_format)"},{"line_number":593,"context_line":"            data \u003d format_inspector.InspectWrapper(data)"},{"line_number":594,"context_line":"        else:"},{"line_number":595,"context_line":"            # FIXME(danms): Either warn here if we are unable to inspect non-"},{"line_number":596,"context_line":"            # bare images or maybe make this a hard fail"}],"source_content_type":"text/x-python","patch_set":11,"id":"3435f8ff_503720f5","line":593,"range":{"start_line":593,"start_character":0,"end_line":593,"end_character":12},"in_reply_to":"03a89610_483105a1","updated":"2025-02-20 21:05:40.000000000","message":"Oops, good catch. However, this patch still does what it says on the tin, it just waits until the end of the stream to reject. I think that happened here is sort of a rebase error while I was working on the GPT compat stuff above (since if we\u0027re allowing gpt or raw we need to be able to be graceful and not abort the stream until we know what it is). So I think I can just revert this hunk back to the FIXME from before so it\u0027s not confusing. Make sense?","commit_id":"41c4b384e3769a70c3eac703959973bef2836021"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"87c5cec41534e01bc4189c2ab9eda57370f5eb47","unresolved":false,"context_lines":[{"line_number":590,"context_line":"                kwargs[\u0027expected_format\u0027] \u003d self.image.disk_format"},{"line_number":591,"context_line":"                LOG.debug(\u0027Enabling in-flight format inspection for %s\u0027,"},{"line_number":592,"context_line":"                          self.image.disk_format)"},{"line_number":593,"context_line":"            data \u003d format_inspector.InspectWrapper(data)"},{"line_number":594,"context_line":"        else:"},{"line_number":595,"context_line":"            # FIXME(danms): Either warn here if we are unable to inspect non-"},{"line_number":596,"context_line":"            # bare images or maybe make this a hard fail"}],"source_content_type":"text/x-python","patch_set":11,"id":"672ecea4_0f2b2954","line":593,"range":{"start_line":593,"start_character":0,"end_line":593,"end_character":12},"in_reply_to":"3435f8ff_503720f5","updated":"2025-02-20 22:33:10.000000000","message":"Acknowledged","commit_id":"41c4b384e3769a70c3eac703959973bef2836021"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"6c95da9bce83ac05c0da9b90ad1e5c0c15db4a3e","unresolved":true,"context_lines":[{"line_number":614,"context_line":"            format \u003d str(inspector)"},{"line_number":615,"context_line":"            if format \u003d\u003d self.image.disk_format:"},{"line_number":616,"context_line":"                LOG.info(\u0027Image format matched and virtual size computed: %i\u0027,"},{"line_number":617,"context_line":"                         virtual_size)"},{"line_number":618,"context_line":"                virtual_size \u003d inspector.virtual_size"},{"line_number":619,"context_line":"            elif (format \u003d\u003d \u0027raw\u0027 and"},{"line_number":620,"context_line":"                  self.image.disk_format not in format_inspector.ALL_FORMATS):"}],"source_content_type":"text/x-python","patch_set":11,"id":"0b5b633f_a845abbc","line":617,"range":{"start_line":617,"start_character":0,"end_line":617,"end_character":25},"updated":"2025-02-20 20:55:16.000000000","message":"virtual_size is always going to be 0 here, isn\u0027t it?","commit_id":"41c4b384e3769a70c3eac703959973bef2836021"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"08f42d44de3206cfd5dc4adb6e6c66568dce530f","unresolved":true,"context_lines":[{"line_number":614,"context_line":"            format \u003d str(inspector)"},{"line_number":615,"context_line":"            if format \u003d\u003d self.image.disk_format:"},{"line_number":616,"context_line":"                LOG.info(\u0027Image format matched and virtual size computed: %i\u0027,"},{"line_number":617,"context_line":"                         virtual_size)"},{"line_number":618,"context_line":"                virtual_size \u003d inspector.virtual_size"},{"line_number":619,"context_line":"            elif (format \u003d\u003d \u0027raw\u0027 and"},{"line_number":620,"context_line":"                  self.image.disk_format not in format_inspector.ALL_FORMATS):"}],"source_content_type":"text/x-python","patch_set":11,"id":"e240714e_abf8c620","line":617,"range":{"start_line":617,"start_character":0,"end_line":617,"end_character":25},"in_reply_to":"0b5b633f_a845abbc","updated":"2025-02-24 14:30:43.000000000","message":"Sorry, somehow I didn\u0027t commit this draft comment:\n\n\u003e Also good catch, not sure how these lines got flipped\n\nThe order of the extraction and the LOG statement got flipped somewhere. I fixed it in the latest iteration but it probably wasn\u0027t obvious without my comment.","commit_id":"41c4b384e3769a70c3eac703959973bef2836021"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"87c5cec41534e01bc4189c2ab9eda57370f5eb47","unresolved":true,"context_lines":[{"line_number":614,"context_line":"            format \u003d str(inspector)"},{"line_number":615,"context_line":"            if format \u003d\u003d self.image.disk_format:"},{"line_number":616,"context_line":"                LOG.info(\u0027Image format matched and virtual size computed: %i\u0027,"},{"line_number":617,"context_line":"                         virtual_size)"},{"line_number":618,"context_line":"                virtual_size \u003d inspector.virtual_size"},{"line_number":619,"context_line":"            elif (format \u003d\u003d \u0027raw\u0027 and"},{"line_number":620,"context_line":"                  self.image.disk_format not in format_inspector.ALL_FORMATS):"}],"source_content_type":"text/x-python","patch_set":11,"id":"6a453851_a2baac6e","line":617,"range":{"start_line":617,"start_character":0,"end_line":617,"end_character":25},"in_reply_to":"0b5b633f_a845abbc","updated":"2025-02-20 22:33:10.000000000","message":"What about this?","commit_id":"41c4b384e3769a70c3eac703959973bef2836021"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"87c5cec41534e01bc4189c2ab9eda57370f5eb47","unresolved":true,"context_lines":[{"line_number":584,"context_line":"            # FIXME(danms): We do not pass an expected_format here because"},{"line_number":585,"context_line":"            # we do not (currently) want to interrupt the data pipeline if"},{"line_number":586,"context_line":"            # the format does not match."},{"line_number":587,"context_line":"            kwargs \u003d {}"},{"line_number":588,"context_line":"            LOG.debug(\u0027Enabling in-flight format inspection for %s\u0027,"},{"line_number":589,"context_line":"                      self.image.disk_format)"},{"line_number":590,"context_line":"            data \u003d format_inspector.InspectWrapper(data)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ab8d5e54_e720be76","line":587,"range":{"start_line":587,"start_character":0,"end_line":587,"end_character":12},"updated":"2025-02-20 22:33:10.000000000","message":"But please also remove this unused variable :)","commit_id":"eccaa03b6ed4a095283ca52795a292befc8423dc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"08f42d44de3206cfd5dc4adb6e6c66568dce530f","unresolved":true,"context_lines":[{"line_number":584,"context_line":"            # FIXME(danms): We do not pass an expected_format here because"},{"line_number":585,"context_line":"            # we do not (currently) want to interrupt the data pipeline if"},{"line_number":586,"context_line":"            # the format does not match."},{"line_number":587,"context_line":"            kwargs \u003d {}"},{"line_number":588,"context_line":"            LOG.debug(\u0027Enabling in-flight format inspection for %s\u0027,"},{"line_number":589,"context_line":"                      self.image.disk_format)"},{"line_number":590,"context_line":"            data \u003d format_inspector.InspectWrapper(data)"}],"source_content_type":"text/x-python","patch_set":12,"id":"8ae7cb25_5f674052","line":587,"range":{"start_line":587,"start_character":0,"end_line":587,"end_character":12},"in_reply_to":"ab8d5e54_e720be76","updated":"2025-02-24 14:30:43.000000000","message":"Gah :)","commit_id":"eccaa03b6ed4a095283ca52795a292befc8423dc"}]}