)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"6e89fd35463aea1dacea20eaf34fde9360759067","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6f8dea9d_d7921a38","updated":"2024-10-17 15:49:40.000000000","message":"We already have a glance/common/wsgi.py so I did not add a glance.common.wsgi module, as that would have required bigger changes throughout the code base. Do we really need a module or is it fine the way I did it?\n\nThis has obviously not been tested, and I don\u0027t think Glance currently supports uwsgi too well, but I\u0027d like to be ready for the changes coming our way.","commit_id":"b27ac643aa14ec7ce987eb55f4fb8e69aeb3c9e1"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"935a1c4dbbe8123ef299325cdcad4c8e71c1fc52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"887bc564_072dabb5","in_reply_to":"025f75f8_242a1c23","updated":"2024-10-18 14:55:31.000000000","message":"My bad, I wanted to have this in glance/common/wsgi for some reason :) I\u0027ll abandon this in favor of your patch.","commit_id":"b27ac643aa14ec7ce987eb55f4fb8e69aeb3c9e1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"990ad20f18aaed00888da2fae4cdc923cc775751","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"17cb8d48_fe58b375","in_reply_to":"16889053_656c439c","updated":"2024-10-18 12:42:34.000000000","message":"I\u0027m confused. What\u0027s going to fail? Nothing should be importing `glance.wsgi` except a WSGI server, and nothing should be inside the `glance.wsgi` package except an `api` module with an `application` attribute. Everything that\u0027s currently in `glance.common.wsgi` should stay exactly where it is.","commit_id":"b27ac643aa14ec7ce987eb55f4fb8e69aeb3c9e1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8ee5b048c21e53677b266a4bba5aee42f98515cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"025f75f8_242a1c23","in_reply_to":"17cb8d48_fe58b375","updated":"2024-10-18 12:46:06.000000000","message":"I proposed https://review.opendev.org/c/openstack/glance/+/932701 as an alternative. Unit tests worked fine so I\u0027m interested in the functional/integration tests. I figure we\u0027re either talking about different things or I\u0027m missing something really obvious so this seemed easier 😅","commit_id":"b27ac643aa14ec7ce987eb55f4fb8e69aeb3c9e1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"61493d0bed63533c7bb26c1784121370c6cd434f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d8920899_d410fe33","in_reply_to":"6f8dea9d_d7921a38","updated":"2024-10-17 16:49:15.000000000","message":"The reason for the `{service}.wsgi` module to provide as consistent an approach as possible across services. If you look at changes under the topic you\u0027ve used, you\u0027ll see that for e.g. nova, I actually [removed the existing `nova/wsgi.py` file](https://review.opendev.org/c/openstack/nova/+/902686) to free up space (if you will) for this new package. That wasn\u0027t necessary in cinder since they already have a package and I just [added a new `api` module](https://review.opendev.org/c/openstack/cinder/+/902876).\n\nIn this instance, could you simply move `glance/common/wsgi_api.py` to `glance/wsgi/app.py` and be done? There\u0027s no need to move everything from `glance/common/wsgi` to `glance/wsgi`. We didn\u0027t do that for Nova.\n\n```\nmkdir glance/wsgi\ntouch glance/wsgi/__init__.py\ngit mv glance/common/wsgi_api.py glance/wsgi/api.py\n```\n\nOught to do the trick. Plus changes to the release note and apidoc ignore.","commit_id":"b27ac643aa14ec7ce987eb55f4fb8e69aeb3c9e1"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"383d9ff538b47dc5b627fa926dd1eb6a64c39102","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"16889053_656c439c","in_reply_to":"7e3ca713_c55808f8","updated":"2024-10-17 20:04:20.000000000","message":"This was my initial approach, but we often do:\n\n    from glance.common import wsgi  # This is glance/common/wsgi.py\n    \nIf we create glance/wsgi/ then these import are going to fail :)","commit_id":"b27ac643aa14ec7ce987eb55f4fb8e69aeb3c9e1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dd87a69d337c6edd8ee5ec0c1af9f0b4fc2d2942","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7e3ca713_c55808f8","in_reply_to":"d8920899_d410fe33","updated":"2024-10-17 16:50:52.000000000","message":"Just to be extra clear, Cinder has more stuff in their `cinder.wsgi` package because it was already there. It wouldn\u0027t go there if we starting from scratch (better to have it in e.g. `cinder.api`) but I wasn\u0027t going boiling that ocean 😄","commit_id":"b27ac643aa14ec7ce987eb55f4fb8e69aeb3c9e1"}]}