)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"15fdb4886a200eb818fffe551118dc5adc5d1507","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Related to blueprint glance-as-defender"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tempest/+/933870"},{"line_number":26,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/933928"},{"line_number":27,"context_line":"Depends-On: https://review.opendev.org/c/openstack/cinder/+/934261"},{"line_number":28,"context_line":"Change-Id: I32416d38e295d32ae24652ec83716ca82eb76b06"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"159d50dc_e363d2a0","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":67},"updated":"2026-10-22 13:40:36.000000000","message":"Tempest change is merged, so remove this depends-on as well","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"a7b814c214d8fa544d84553e6d4e3ab19f839dcd","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Related to blueprint glance-as-defender"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tempest/+/933870"},{"line_number":26,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/933928"},{"line_number":27,"context_line":"Depends-On: https://review.opendev.org/c/openstack/cinder/+/934261"},{"line_number":28,"context_line":"Change-Id: I32416d38e295d32ae24652ec83716ca82eb76b06"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"087e2527_d6664b3c","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":67},"in_reply_to":"159d50dc_e363d2a0","updated":"2026-10-23 07:35:02.000000000","message":"Done","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"15fdb4886a200eb818fffe551118dc5adc5d1507","unresolved":true,"context_lines":[{"line_number":23,"context_line":"Related to blueprint glance-as-defender"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tempest/+/933870"},{"line_number":26,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/933928"},{"line_number":27,"context_line":"Depends-On: https://review.opendev.org/c/openstack/cinder/+/934261"},{"line_number":28,"context_line":"Change-Id: I32416d38e295d32ae24652ec83716ca82eb76b06"},{"line_number":29,"context_line":"Signed-off-by: PranaliD \u003cpdeore@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"e7e72010_666eb955","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":64},"updated":"2026-10-22 13:40:36.000000000","message":"As nova change is merged, you can remove this depends-on","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"a7b814c214d8fa544d84553e6d4e3ab19f839dcd","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Related to blueprint glance-as-defender"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tempest/+/933870"},{"line_number":26,"context_line":"Depends-On: https://review.opendev.org/c/openstack/nova/+/933928"},{"line_number":27,"context_line":"Depends-On: https://review.opendev.org/c/openstack/cinder/+/934261"},{"line_number":28,"context_line":"Change-Id: I32416d38e295d32ae24652ec83716ca82eb76b06"},{"line_number":29,"context_line":"Signed-off-by: PranaliD \u003cpdeore@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1cba7530_18cf82dc","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":64},"in_reply_to":"e7e72010_666eb955","updated":"2026-10-23 07:35:02.000000000","message":"Done","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"512294ce893638fcc6dc86d60dbcee1b90482449","unresolved":true,"context_lines":[{"line_number":23,"context_line":"Related to blueprint glance-as-defender"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Depends-On: https://review.opendev.org/c/openstack/cinder/+/934261"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Co-Authored-By: PranaliD \u003cpdeore@redhat.com\u003e"},{"line_number":28,"context_line":"Change-Id: I32416d38e295d32ae24652ec83716ca82eb76b06"},{"line_number":29,"context_line":"Signed-off-by: PranaliD \u003cpdeore@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"4fb13e30_8561284f","line":26,"updated":"2026-10-23 14:25:22.000000000","message":"As per latest openstack standards please mention Assisted-By in commit message if any model is used for coding.","commit_id":"f313251a844eedd9c741fa8df06192dda4d5762d"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"0daa389444dca556a8cd428a705eb1309d11cdec","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Related to blueprint glance-as-defender"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Depends-On: https://review.opendev.org/c/openstack/cinder/+/934261"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Co-Authored-By: PranaliD \u003cpdeore@redhat.com\u003e"},{"line_number":28,"context_line":"Change-Id: I32416d38e295d32ae24652ec83716ca82eb76b06"},{"line_number":29,"context_line":"Signed-off-by: PranaliD \u003cpdeore@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"e259c8ac_ba3bfdc5","line":26,"in_reply_to":"4fb13e30_8561284f","updated":"2026-10-26 10:24:54.000000000","message":"Done","commit_id":"f313251a844eedd9c741fa8df06192dda4d5762d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8c2ba997198d69f90748aa4ffa61d26d95c73907","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"58790f88_0874fbfa","updated":"2024-11-01 14:31:03.000000000","message":"recheck tempest changed","commit_id":"648013ff2e355e59b7286775f9cfba18e6cf51d1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2d34d082497b587a7197fbbdb1fb7f36e4484f68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1a00be10_ea132ce7","updated":"2024-11-06 15:23:08.000000000","message":"recheck with oslo.utils released","commit_id":"6d0803ada2478ac371b3c8ab1e7af27c06358caf"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"73d0811ab17b7f0dc4e5950ac0d1759abc8bac33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ea39478d_93ad9ae7","updated":"2024-11-08 15:29:37.000000000","message":"recheck cinder changed","commit_id":"711d6bcb53f788edb7b1331c8de914a633294fba"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ddaa5180640d0eb6c80fb9e9d13c396057cb2125","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c5040dc1_b6278e89","updated":"2024-11-12 18:01:31.000000000","message":"recheck tempest changed again","commit_id":"711d6bcb53f788edb7b1331c8de914a633294fba"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d8f4c89e586df6945f5f6433d371418f6b3ecd48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9b743669_5f820dd5","updated":"2024-11-12 15:52:52.000000000","message":"recheck tempest fixed","commit_id":"711d6bcb53f788edb7b1331c8de914a633294fba"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"00a277d9aac9ce1b52a9141b1865e6a2cee68e08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dffcab70_4c90127c","updated":"2024-11-13 15:33:04.000000000","message":"recheck tempest updated","commit_id":"711d6bcb53f788edb7b1331c8de914a633294fba"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0f9adb6f280ee0a37a9832dbd0ad8251615caf6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fb3d514e_27c31ce2","updated":"2024-11-14 00:01:20.000000000","message":"recheck server fail during image delete, common fail unrelated","commit_id":"d51e24a60adb14b22db1a649c3c9ca6ff00abdc6"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"28cf017cadd781ad44169a60cab8c254e8690e5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"72bed1f0_14e49064","updated":"2024-11-13 20:10:12.000000000","message":"recheck this is good now, unrelated functional failure","commit_id":"d51e24a60adb14b22db1a649c3c9ca6ff00abdc6"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e97f03f0837b0749fed7d7d0c3e60c7de011d574","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1601c4de_efe28468","updated":"2025-01-14 19:45:19.000000000","message":"recheck error during cleanup (again) but unrelated to gpt since it\u0027s in vmdk","commit_id":"a551c54a93e678d6e07e4af300485aa49f1b34db"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"ab10bb313df2b30bb1c8fa545c8176c70bebe650","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6d504fd1_fdb97f9e","updated":"2025-02-24 20:54:59.000000000","message":"recheck","commit_id":"4b78a0c9ef32b1b106e44574c0d41a02307cba07"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9794abb09e4a2766be24610c2a591deda0135183","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"50ebbb8a_04b5c69b","updated":"2025-02-25 18:33:46.000000000","message":"LGTM","commit_id":"7b1ca0c43c763c93295fd7d0b28d14205ba00377"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"b6a127ab04d4d01dae85fbb5e3c960db9884a1e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d840d405_ac56f30e","updated":"2025-03-26 18:46:42.000000000","message":"@cyril@redhat.com hello, please review this MR.","commit_id":"def11f3b3adf832bf96711c84f520d1231e4b0d1"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"3eab23feb3d5d782d7abd64d10183d101eed3e60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"c95da3f8_26906ca1","updated":"2026-06-24 18:01:24.000000000","message":"@dms@danplanet.com Hello, please look merge conflict.","commit_id":"def11f3b3adf832bf96711c84f520d1231e4b0d1"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"fdb88db2f8b2df63172e8b315f284a91fd997e05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"282ded8f_059abdcc","in_reply_to":"c95da3f8_26906ca1","updated":"2026-10-09 11:32:03.000000000","message":"Rebased and resolved the merge conflict.","commit_id":"def11f3b3adf832bf96711c84f520d1231e4b0d1"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"15fdb4886a200eb818fffe551118dc5adc5d1507","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"03c3c455_65388000","updated":"2026-10-22 13:40:36.000000000","message":"Since gpt is now a valid disk_format, the deprecated Tasks API conversion path can still receive a GPT image and call qemu-img with -f gpt, which qemu-img does not understand. Documenting that path as unsupported is not enough while the API is still enabled.\n\nPlease either map gpt to raw there, consistent with the new conversion plugin, or reject GPT explicitly with a clear error before calling qemu-img. If it is rejected, please add a test for that behavior.","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"a7b814c214d8fa544d84553e6d4e3ab19f839dcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"cf251b8c_dc7fd3bd","in_reply_to":"03c3c455_65388000","updated":"2026-10-23 07:35:02.000000000","message":"The old task conversion now maps gpt to raw before qemu-img -f, in glance/async_/flows/convert.py around line 106. Other formats are unchanged. Added a test that a gpt image is passed as -f raw.","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ce11797a487d6bfc6fb99a015e66ce7afc49298b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"a70ba0ba_d0e5da38","updated":"2026-10-23 09:21:15.000000000","message":"Important, sorry i missed this earlier.\n\nThe parallel staged-import path bypasses the format and safety validation used by direct upload. It wraps the stream, but never checks formats, format, or safety_check() before marking locations active. Please share the direct-upload validation logic with this path and add tests for format mismatch and safety-check failure.","commit_id":"d88964e166be40e6cbd592ad16e1ea7d0a0a1b1a"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"a7b814c214d8fa544d84553e6d4e3ab19f839dcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"4e335668_0811e642","updated":"2026-10-23 07:35:02.000000000","message":"Thank Abhishek for the review ! please see this updated PS with inline replies.","commit_id":"d88964e166be40e6cbd592ad16e1ea7d0a0a1b1a"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"6e69855cb2f75b650acfaba7780138088f2521d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"f670824b_2d024e46","in_reply_to":"a70ba0ba_d0e5da38","updated":"2026-10-23 12:34:03.000000000","message":"Done. The direct-upload check now lives in check_image_format() in glance/location.py, line 40. set_data() calls it at line 710. The parallel staged path calls the same function at glance/async_/flows/parallel_api_image_import.py, lines 270–272, after the data is read and before the location is marked active.","commit_id":"d88964e166be40e6cbd592ad16e1ea7d0a0a1b1a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"512294ce893638fcc6dc86d60dbcee1b90482449","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"c0c6bb0c_ca778b4c","updated":"2026-10-23 14:25:22.000000000","message":"The patch looks in good shape however I have one improvement suggestion which will avoid unnecessary write and delete from the backend.","commit_id":"f313251a844eedd9c741fa8df06192dda4d5762d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0f97e69fa32c4cfa6eb38a0b6efb66bce180624b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"3155e20f_e38caadc","updated":"2026-10-26 14:04:08.000000000","message":"All my concerns are addressed, thank you!!\nIf new PS is needed then add APIImpact flag in commit message.","commit_id":"2009938926858a99168ac7aa3e4fad81d779eef1"}],"glance/async_/flows/convert.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8526b931d4ec7247efc8164a30c83d8ea2f7da4d","unresolved":true,"context_lines":[{"line_number":106,"context_line":"        src_format \u003d image_obj.disk_format"},{"line_number":107,"context_line":"        # qemu-img does not understand gpt, so pass raw instead."},{"line_number":108,"context_line":"        if src_format \u003d\u003d \u0027gpt\u0027:"},{"line_number":109,"context_line":"            src_format \u003d \u0027raw\u0027"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # TODO(flaper87): Check whether the image is in the desired"},{"line_number":112,"context_line":"        # format already. Probably using `qemu-img` just like the"}],"source_content_type":"text/x-python","patch_set":21,"id":"2fbd68f6_e163cb3b","line":109,"updated":"2026-10-30 14:57:27.000000000","message":"Even though I know this is sort of the opposite of earlier feedback, I think we might be better off putting this behind the tasks api removal so we can strip out all the legacy stuff from this patch. I doubt it will be tested (aside from in-tree) anyway, so it seems better to just not ever do it.","commit_id":"4740ff419dd8fe4fb5477e958b86758b25d146a1"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"e0eba0bc201a37bd848c3b8f4b7c6195e2222eae","unresolved":true,"context_lines":[{"line_number":106,"context_line":"        src_format \u003d image_obj.disk_format"},{"line_number":107,"context_line":"        # qemu-img does not understand gpt, so pass raw instead."},{"line_number":108,"context_line":"        if src_format \u003d\u003d \u0027gpt\u0027:"},{"line_number":109,"context_line":"            src_format \u003d \u0027raw\u0027"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # TODO(flaper87): Check whether the image is in the desired"},{"line_number":112,"context_line":"        # format already. Probably using `qemu-img` just like the"}],"source_content_type":"text/x-python","patch_set":21,"id":"29c61fad_44f9cc1f","line":109,"in_reply_to":"2fbd68f6_e163cb3b","updated":"2026-11-02 08:49:33.000000000","message":"Done. Removed the GPT handling from the old task conversion, and removed the test for it.","commit_id":"4740ff419dd8fe4fb5477e958b86758b25d146a1"}],"glance/async_/flows/parallel_api_image_import.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"512294ce893638fcc6dc86d60dbcee1b90482449","unresolved":true,"context_lines":[{"line_number":269,"context_line":"    # the copy before the caller marks the location active."},{"line_number":270,"context_line":"    if image.container_format \u003d\u003d \u0027bare\u0027:"},{"line_number":271,"context_line":"        try:"},{"line_number":272,"context_line":"            virtual_size \u003d glance.location.check_image_format("},{"line_number":273,"context_line":"                upload_data, image.disk_format)"},{"line_number":274,"context_line":"        except exception.InvalidImageData:"},{"line_number":275,"context_line":"            try:"},{"line_number":276,"context_line":"                store_utils.delete_image_location_from_backend("}],"source_content_type":"text/x-python","patch_set":18,"id":"46f0891a_6f70e802","line":273,"range":{"start_line":272,"start_character":12,"end_line":273,"end_character":47},"updated":"2026-10-23 14:25:22.000000000","message":"IMO as the image is already staged, validating its format and safety before the parallel store copying begins makes more sense. With this code, each store uploads the data first and then deletes it if validation fails.\n\n\nThe better approach is to extend _VerifyStagedImageSignatureTask and rename it to _VerifyStagedImageTask, so signature, format, and safety checks all happen once before _ParallelStoreImportTask.\n\nIf you want signature verification stays separate, add _VerifyStagedImageFormatTask before the parallel import task.","commit_id":"f313251a844eedd9c741fa8df06192dda4d5762d"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"0daa389444dca556a8cd428a705eb1309d11cdec","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    # the copy before the caller marks the location active."},{"line_number":270,"context_line":"    if image.container_format \u003d\u003d \u0027bare\u0027:"},{"line_number":271,"context_line":"        try:"},{"line_number":272,"context_line":"            virtual_size \u003d glance.location.check_image_format("},{"line_number":273,"context_line":"                upload_data, image.disk_format)"},{"line_number":274,"context_line":"        except exception.InvalidImageData:"},{"line_number":275,"context_line":"            try:"},{"line_number":276,"context_line":"                store_utils.delete_image_location_from_backend("}],"source_content_type":"text/x-python","patch_set":18,"id":"d099a331_3ec2f391","line":273,"range":{"start_line":272,"start_character":12,"end_line":273,"end_character":47},"in_reply_to":"46f0891a_6f70e802","updated":"2026-10-26 10:24:54.000000000","message":"Done","commit_id":"f313251a844eedd9c741fa8df06192dda4d5762d"}],"glance/async_/flows/plugins/image_conversion.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"15fdb4886a200eb818fffe551118dc5adc5d1507","unresolved":true,"context_lines":[{"line_number":141,"context_line":"            LOG.error(\u0027Image claimed to be %s format but format \u0027"},{"line_number":142,"context_line":"                      \u0027inspection found: ISO\u0027, source_format)"},{"line_number":143,"context_line":"            raise RuntimeError(\"Image has disallowed configuration\")"},{"line_number":144,"context_line":"        elif detected_format !\u003d source_format:"},{"line_number":145,"context_line":"            LOG.error(\u0027Image claimed to be %s format failed format \u0027"},{"line_number":146,"context_line":"                      \u0027inspection\u0027, source_format)"},{"line_number":147,"context_line":"            raise RuntimeError(\u0027Image format mismatch\u0027)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # NOTE(danms): We need to consider GPT to be raw for qemu, since"},{"line_number":150,"context_line":"        # it does not distinguish between the two."}],"source_content_type":"text/x-python","patch_set":16,"id":"56a95262_6e716267","line":147,"range":{"start_line":144,"start_character":0,"end_line":147,"end_character":55},"updated":"2026-10-22 13:40:36.000000000","message":"Before this change, a detected GPT image was mapped to raw before source-format validation:\n\n\n    if detected_format \u003d\u003d \u0027gpt\u0027:\n        # FIXME(danms): We need to consider GPT to be raw for compatibility\n        detected_format \u003d \u0027raw\u0027\n\nAs a result, an image declared disk_format\u003draw but containing GPT data was accepted for compatibility. With this change, that mapping now happens only when calling qemu-img, after the source-format check. The same image now fails with Image format mismatch when output_format\u003dgpt, while direct upload still allows this combination.\n\nIs rejecting this image during conversion intentional? If so, please document the behavior and add a test. If not, the compatibility mapping should still apply to source-format validation.","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"a7b814c214d8fa544d84553e6d4e3ab19f839dcd","unresolved":true,"context_lines":[{"line_number":141,"context_line":"            LOG.error(\u0027Image claimed to be %s format but format \u0027"},{"line_number":142,"context_line":"                      \u0027inspection found: ISO\u0027, source_format)"},{"line_number":143,"context_line":"            raise RuntimeError(\"Image has disallowed configuration\")"},{"line_number":144,"context_line":"        elif detected_format !\u003d source_format:"},{"line_number":145,"context_line":"            LOG.error(\u0027Image claimed to be %s format failed format \u0027"},{"line_number":146,"context_line":"                      \u0027inspection\u0027, source_format)"},{"line_number":147,"context_line":"            raise RuntimeError(\u0027Image format mismatch\u0027)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # NOTE(danms): We need to consider GPT to be raw for qemu, since"},{"line_number":150,"context_line":"        # it does not distinguish between the two."}],"source_content_type":"text/x-python","patch_set":16,"id":"94de7d15_da087882","line":147,"range":{"start_line":144,"start_character":0,"end_line":147,"end_character":55},"in_reply_to":"56a95262_6e716267","updated":"2026-10-23 07:35:02.000000000","message":"Well, this doesn\u0027t seem intentional. A raw image with data GPT used to pass conversion. Direct upload still allows that image too. I changed the check now so conversion allows it again, and it does not hit the mismatch error on line 148.\n\nImage that is really disk_format\u003dgpt is unchanged. qemu-img is still called with raw at lines 155-157. I added a test for this raw image.","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ce11797a487d6bfc6fb99a015e66ce7afc49298b","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            LOG.error(\u0027Image claimed to be %s format but format \u0027"},{"line_number":142,"context_line":"                      \u0027inspection found: ISO\u0027, source_format)"},{"line_number":143,"context_line":"            raise RuntimeError(\"Image has disallowed configuration\")"},{"line_number":144,"context_line":"        elif detected_format !\u003d source_format:"},{"line_number":145,"context_line":"            LOG.error(\u0027Image claimed to be %s format failed format \u0027"},{"line_number":146,"context_line":"                      \u0027inspection\u0027, source_format)"},{"line_number":147,"context_line":"            raise RuntimeError(\u0027Image format mismatch\u0027)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # NOTE(danms): We need to consider GPT to be raw for qemu, since"},{"line_number":150,"context_line":"        # it does not distinguish between the two."}],"source_content_type":"text/x-python","patch_set":16,"id":"e2c88068_6b4ffbd3","line":147,"range":{"start_line":144,"start_character":0,"end_line":147,"end_character":55},"in_reply_to":"94de7d15_da087882","updated":"2026-10-23 09:21:15.000000000","message":"Acknowledged","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"}],"glance/common/config.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"15fdb4886a200eb818fffe551118dc5adc5d1507","unresolved":true,"context_lines":[{"line_number":99,"context_line":"                                                   group\u003d\u0027DEFAULT\u0027)]),"},{"line_number":100,"context_line":"    cfg.ListOpt(\u0027disk_formats\u0027,"},{"line_number":101,"context_line":"                default\u003d[\u0027ami\u0027, \u0027ari\u0027, \u0027aki\u0027, \u0027vhd\u0027, \u0027vhdx\u0027, \u0027vmdk\u0027, \u0027raw\u0027,"},{"line_number":102,"context_line":"                         \u0027qcow2\u0027, \u0027vdi\u0027, \u0027iso\u0027, \u0027ploop\u0027, \u0027gpt\u0027],"},{"line_number":103,"context_line":"                help\u003d_(\"Supported values for the \u0027disk_format\u0027 \""},{"line_number":104,"context_line":"                       \"image attribute\"),"},{"line_number":105,"context_line":"                deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027disk_formats\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3d61a078_79ea7d62","line":102,"range":{"start_line":102,"start_character":58,"end_line":102,"end_character":61},"updated":"2026-10-22 13:40:36.000000000","message":"I think we need a releasenote as we are adding new disk_format and and introducing new conversion target format as well.","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"a7b814c214d8fa544d84553e6d4e3ab19f839dcd","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                                                   group\u003d\u0027DEFAULT\u0027)]),"},{"line_number":100,"context_line":"    cfg.ListOpt(\u0027disk_formats\u0027,"},{"line_number":101,"context_line":"                default\u003d[\u0027ami\u0027, \u0027ari\u0027, \u0027aki\u0027, \u0027vhd\u0027, \u0027vhdx\u0027, \u0027vmdk\u0027, \u0027raw\u0027,"},{"line_number":102,"context_line":"                         \u0027qcow2\u0027, \u0027vdi\u0027, \u0027iso\u0027, \u0027ploop\u0027, \u0027gpt\u0027],"},{"line_number":103,"context_line":"                help\u003d_(\"Supported values for the \u0027disk_format\u0027 \""},{"line_number":104,"context_line":"                       \"image attribute\"),"},{"line_number":105,"context_line":"                deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027disk_formats\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ea7bac83_2dc8613d","line":102,"range":{"start_line":102,"start_character":58,"end_line":102,"end_character":61},"in_reply_to":"3d61a078_79ea7d62","updated":"2026-10-23 07:35:02.000000000","message":"Done","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"}],"glance/location.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"512294ce893638fcc6dc86d60dbcee1b90482449","unresolved":true,"context_lines":[{"line_number":37,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def check_image_format(data, disk_format):"},{"line_number":41,"context_line":"    \"\"\"Check inspected image data against ``disk_format``."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    ``data`` is the object passed to the store, usually an"}],"source_content_type":"text/x-python","patch_set":18,"id":"98573657_a9a7e36c","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":22},"updated":"2026-10-23 14:25:22.000000000","message":"I think you should move this method in glance/common/utils.py","commit_id":"f313251a844eedd9c741fa8df06192dda4d5762d"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"0daa389444dca556a8cd428a705eb1309d11cdec","unresolved":false,"context_lines":[{"line_number":37,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def check_image_format(data, disk_format):"},{"line_number":41,"context_line":"    \"\"\"Check inspected image data against ``disk_format``."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    ``data`` is the object passed to the store, usually an"}],"source_content_type":"text/x-python","patch_set":18,"id":"8c0f5205_0a171c77","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":22},"in_reply_to":"98573657_a9a7e36c","updated":"2026-10-26 10:24:54.000000000","message":"Done","commit_id":"f313251a844eedd9c741fa8df06192dda4d5762d"}],"glance/tests/unit/async_/flows/plugins/test_image_conversion.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"99799ee899f790123000a8edd9ccdad027e07e01","unresolved":true,"context_lines":[{"line_number":484,"context_line":"            RuntimeError, \u0027disallowed configuration\u0027,"},{"line_number":485,"context_line":"            self._test_image_convert_inspect_target_format,"},{"line_number":486,"context_line":"            out_format\u003d\u0027vmdk\u0027, dst_format\u003d\u0027vmdk\u0027, dest_safe_fails\u003d[\u0027mbr\u0027])"},{"line_number":487,"context_line":"            pre_inspector.__str__.return_value \u003d src_format"},{"line_number":488,"context_line":"            post_inspector.__str__.return_value \u003d dst_format"},{"line_number":489,"context_line":"            if not dest_safe:"},{"line_number":490,"context_line":"                post_inspector.safety_check.side_effect \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"b119d55e_99b60483","line":487,"updated":"2025-02-25 18:31:59.000000000","message":"Bad rebase here","commit_id":"7b1ca0c43c763c93295fd7d0b28d14205ba00377"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"750c7a40eae4b988c2b4442dbf5c9a254ee37aad","unresolved":false,"context_lines":[{"line_number":484,"context_line":"            RuntimeError, \u0027disallowed configuration\u0027,"},{"line_number":485,"context_line":"            self._test_image_convert_inspect_target_format,"},{"line_number":486,"context_line":"            out_format\u003d\u0027vmdk\u0027, dst_format\u003d\u0027vmdk\u0027, dest_safe_fails\u003d[\u0027mbr\u0027])"},{"line_number":487,"context_line":"            pre_inspector.__str__.return_value \u003d src_format"},{"line_number":488,"context_line":"            post_inspector.__str__.return_value \u003d dst_format"},{"line_number":489,"context_line":"            if not dest_safe:"},{"line_number":490,"context_line":"                post_inspector.safety_check.side_effect \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"34236c01_fc1ddc70","line":487,"in_reply_to":"b119d55e_99b60483","updated":"2025-02-26 04:38:39.000000000","message":"Done","commit_id":"7b1ca0c43c763c93295fd7d0b28d14205ba00377"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"15fdb4886a200eb818fffe551118dc5adc5d1507","unresolved":true,"context_lines":[{"line_number":500,"context_line":"            self._test_image_convert_inspect_target_format,"},{"line_number":501,"context_line":"            out_format\u003d\u0027vmdk\u0027, dst_format\u003d\u0027vmdk\u0027, dest_safe_fails\u003d[\u0027header\u0027])"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    def test_image_convert_raw_actual_gpt(self):"},{"line_number":504,"context_line":"        # Converted qcow2 to raw, but found gpt. Keep raw as instructed."},{"line_number":505,"context_line":"        self._test_image_convert_inspect_target_format("},{"line_number":506,"context_line":"            out_format\u003d\u0027raw\u0027, dst_format\u003d\u0027gpt\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"094f12a5_a218a43c","line":503,"updated":"2026-10-22 13:40:36.000000000","message":"Please add a case with src_format\u003d\u0027gpt\u0027 and assert both qemu-img info and qemu-img convert receive raw, not gpt.","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"a7b814c214d8fa544d84553e6d4e3ab19f839dcd","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            self._test_image_convert_inspect_target_format,"},{"line_number":501,"context_line":"            out_format\u003d\u0027vmdk\u0027, dst_format\u003d\u0027vmdk\u0027, dest_safe_fails\u003d[\u0027header\u0027])"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    def test_image_convert_raw_actual_gpt(self):"},{"line_number":504,"context_line":"        # Converted qcow2 to raw, but found gpt. Keep raw as instructed."},{"line_number":505,"context_line":"        self._test_image_convert_inspect_target_format("},{"line_number":506,"context_line":"            out_format\u003d\u0027raw\u0027, dst_format\u003d\u0027gpt\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"27b4a0f5_e5d8ffb4","line":503,"in_reply_to":"094f12a5_a218a43c","updated":"2026-10-23 07:35:02.000000000","message":"Done","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"15fdb4886a200eb818fffe551118dc5adc5d1507","unresolved":true,"context_lines":[{"line_number":510,"context_line":"        # Converted qcow2 to gpt, but found no gpt. Image should end up as raw."},{"line_number":511,"context_line":"        self._test_image_convert_inspect_target_format("},{"line_number":512,"context_line":"            out_format\u003d\u0027gpt\u0027, dst_format\u003d\u0027raw\u0027)"},{"line_number":513,"context_line":"        self.assertEqual(\u0027raw\u0027, self.img_repo.get.return_value.disk_format)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    def test_image_convert_gpt_actual_gpt(self):"},{"line_number":516,"context_line":"        # Converted qcow2 to gpt, and found gpt. Image should end up as gpt."}],"source_content_type":"text/x-python","patch_set":16,"id":"03063e4a_5710ab22","line":513,"updated":"2026-10-22 13:40:36.000000000","message":"Also assert the qemu target format is raw when output_format\u003d\u0027gpt\u0027. Right now the tests check only the resulting Glance disk_format.","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"a7b814c214d8fa544d84553e6d4e3ab19f839dcd","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        # Converted qcow2 to gpt, but found no gpt. Image should end up as raw."},{"line_number":511,"context_line":"        self._test_image_convert_inspect_target_format("},{"line_number":512,"context_line":"            out_format\u003d\u0027gpt\u0027, dst_format\u003d\u0027raw\u0027)"},{"line_number":513,"context_line":"        self.assertEqual(\u0027raw\u0027, self.img_repo.get.return_value.disk_format)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    def test_image_convert_gpt_actual_gpt(self):"},{"line_number":516,"context_line":"        # Converted qcow2 to gpt, and found gpt. Image should end up as gpt."}],"source_content_type":"text/x-python","patch_set":16,"id":"800ba3af_fbb8e420","line":513,"in_reply_to":"03063e4a_5710ab22","updated":"2026-10-23 07:35:02.000000000","message":"Done","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"15fdb4886a200eb818fffe551118dc5adc5d1507","unresolved":true,"context_lines":[{"line_number":518,"context_line":"            out_format\u003d\u0027gpt\u0027, dst_format\u003d\u0027gpt\u0027)"},{"line_number":519,"context_line":"        self.assertEqual(\u0027gpt\u0027, self.img_repo.get.return_value.disk_format)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def _set_image_conversion(self, mock_os_remove, stores\u003d[]):"},{"line_number":522,"context_line":"        mock_os_remove.return_value \u003d None"},{"line_number":523,"context_line":"        wrapper \u003d mock.MagicMock()"},{"line_number":524,"context_line":"        image_convert \u003d image_conversion._ConvertImage(self.context,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ea01bdc0_8f0ff439","line":521,"updated":"2026-10-22 13:40:36.000000000","message":"IN addition to conversion tests, I think we need unit tests for direct-upload flow as well covering, disk_format\u003d\u0027gpt\u0027, valid GPT, raw/qcow2/ISO mismatch, and safety-check failure.","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ce11797a487d6bfc6fb99a015e66ce7afc49298b","unresolved":false,"context_lines":[{"line_number":518,"context_line":"            out_format\u003d\u0027gpt\u0027, dst_format\u003d\u0027gpt\u0027)"},{"line_number":519,"context_line":"        self.assertEqual(\u0027gpt\u0027, self.img_repo.get.return_value.disk_format)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def _set_image_conversion(self, mock_os_remove, stores\u003d[]):"},{"line_number":522,"context_line":"        mock_os_remove.return_value \u003d None"},{"line_number":523,"context_line":"        wrapper \u003d mock.MagicMock()"},{"line_number":524,"context_line":"        image_convert \u003d image_conversion._ConvertImage(self.context,"}],"source_content_type":"text/x-python","patch_set":16,"id":"f8d8192e_6628c3ec","line":521,"in_reply_to":"910c5963_8483a4b8","updated":"2026-10-23 09:21:15.000000000","message":"Acknowledged","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"a7b814c214d8fa544d84553e6d4e3ab19f839dcd","unresolved":true,"context_lines":[{"line_number":518,"context_line":"            out_format\u003d\u0027gpt\u0027, dst_format\u003d\u0027gpt\u0027)"},{"line_number":519,"context_line":"        self.assertEqual(\u0027gpt\u0027, self.img_repo.get.return_value.disk_format)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def _set_image_conversion(self, mock_os_remove, stores\u003d[]):"},{"line_number":522,"context_line":"        mock_os_remove.return_value \u003d None"},{"line_number":523,"context_line":"        wrapper \u003d mock.MagicMock()"},{"line_number":524,"context_line":"        image_convert \u003d image_conversion._ConvertImage(self.context,"}],"source_content_type":"text/x-python","patch_set":16,"id":"910c5963_8483a4b8","line":521,"in_reply_to":"ea01bdc0_8f0ff439","updated":"2026-10-23 07:35:02.000000000","message":"I think the direct-upload cases are already covered in glance/tests/unit/test_store_image.py. by existing tests:\n\n- test_image_set_data_inspector_valid_gpt: a valid GPT image uploaded as disk_format\u003dgpt\n- test_image_set_data_inspector_format_fails_safety_check: a GPT image that fails the safety check\n- test_image_set_data_inspector_gpt_as_raw_compat: a valid GPT image registered as raw\n\nThe raw, qcow2, and ISO mismatch cases belong to the next patch in this chain, : https://review.opendev.org/c/openstack/glance/+/939727, i\u0027ll add those tests there.","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"}],"glance/tests/unit/test_store_image.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ce11797a487d6bfc6fb99a015e66ce7afc49298b","unresolved":true,"context_lines":[{"line_number":380,"context_line":"        image.set_data(iter((data,)), 1024)"},{"line_number":381,"context_line":"        self.assertEqual(1024, image.size)"},{"line_number":382,"context_line":"        self.assertEqual(\u0027active\u0027, image.status)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def test_image_set_data_inspector_format_unsupported_hiding(self):"},{"line_number":385,"context_line":"        context \u003d glance.context.RequestContext(user_id\u003dUSER1)"},{"line_number":386,"context_line":"        image_stub \u003d ImageStub(UUID2, status\u003d\u0027queued\u0027, locations\u003d[])"}],"source_content_type":"text/x-python","patch_set":17,"id":"8a1bc6d7_dc136c52","line":383,"updated":"2026-10-23 09:21:15.000000000","message":"Please add more coverage for disk_format\u003dgpt. With conversion disabled, staged import should accept valid GPT data and reject raw, qcow2, ISO, and fatal GPT safety-check failures when the image is declared gpt. Please also add one direct-upload test that rejects non-GPT data declared gpt. The broader raw/GPT compatibility cases can stay in 939727.","commit_id":"d88964e166be40e6cbd592ad16e1ea7d0a0a1b1a"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"6e69855cb2f75b650acfaba7780138088f2521d4","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        image.set_data(iter((data,)), 1024)"},{"line_number":381,"context_line":"        self.assertEqual(1024, image.size)"},{"line_number":382,"context_line":"        self.assertEqual(\u0027active\u0027, image.status)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def test_image_set_data_inspector_format_unsupported_hiding(self):"},{"line_number":385,"context_line":"        context \u003d glance.context.RequestContext(user_id\u003dUSER1)"},{"line_number":386,"context_line":"        image_stub \u003d ImageStub(UUID2, status\u003d\u0027queued\u0027, locations\u003d[])"}],"source_content_type":"text/x-python","patch_set":17,"id":"1156ded6_7f3b13c8","line":383,"in_reply_to":"8a1bc6d7_dc136c52","updated":"2026-10-23 12:34:03.000000000","message":"Done","commit_id":"d88964e166be40e6cbd592ad16e1ea7d0a0a1b1a"}],"playbooks/post-check-metadata-injection.yaml":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"15fdb4886a200eb818fffe551118dc5adc5d1507","unresolved":true,"context_lines":[{"line_number":18,"context_line":"              echo \"Checking that the cirros image was decorated with metdata on import...\""},{"line_number":19,"context_line":"              glance image-list --property-filter \u0027glance_devstack_test\u003ddoyouseeme?\u0027 | grep $image"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"              echo \"Checking that the cirros image was converted to raw on import...\""},{"line_number":22,"context_line":"              glance image-show $image | grep \u0027disk_format.*gpt\u0027"},{"line_number":23,"context_line":"          done"},{"line_number":24,"context_line":"      environment: \u0027{{ zuul | zuul_legacy_vars }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"714c7467_8c389919","line":21,"range":{"start_line":21,"start_character":55,"end_line":21,"end_character":71},"updated":"2026-10-22 13:40:36.000000000","message":"This needs to be updated as well as it is still saying raw while we are checking gtp.","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"a7b814c214d8fa544d84553e6d4e3ab19f839dcd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"              echo \"Checking that the cirros image was decorated with metdata on import...\""},{"line_number":19,"context_line":"              glance image-list --property-filter \u0027glance_devstack_test\u003ddoyouseeme?\u0027 | grep $image"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"              echo \"Checking that the cirros image was converted to raw on import...\""},{"line_number":22,"context_line":"              glance image-show $image | grep \u0027disk_format.*gpt\u0027"},{"line_number":23,"context_line":"          done"},{"line_number":24,"context_line":"      environment: \u0027{{ zuul | zuul_legacy_vars }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"db46b843_aea67c7f","line":21,"range":{"start_line":21,"start_character":55,"end_line":21,"end_character":71},"in_reply_to":"714c7467_8c389919","updated":"2026-10-23 07:35:02.000000000","message":"Done","commit_id":"70388fc535dc337935767f7faa9d3f7a76dcbc57"}],"releasenotes/notes/add-gpt-disk-format-4f8c1a2b7e9d.yaml":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ce11797a487d6bfc6fb99a015e66ce7afc49298b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``gpt`` is now a valid ``disk_format``. Image conversion can target"},{"line_number":5,"context_line":"    ``gpt``. Glance passes ``raw`` to ``qemu-img`` for a GPT image, because"},{"line_number":6,"context_line":"    ``qemu-img`` does not know ``gpt``. If the converted image does not"},{"line_number":7,"context_line":"    contain a GPT partition table, Glance stores it as ``raw``."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"e36e574c_b9922d4e","line":5,"range":{"start_line":4,"start_character":44,"end_line":5,"end_character":11},"updated":"2026-10-23 09:21:15.000000000","message":"This is misleading, I think only new image import workflow conversion plugin supports gpt, where as legacy conversion task only allows qcow2/raw/vmdk. I think here it should be mentioned explicitly.","commit_id":"d88964e166be40e6cbd592ad16e1ea7d0a0a1b1a"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"6e69855cb2f75b650acfaba7780138088f2521d4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``gpt`` is now a valid ``disk_format``. Image conversion can target"},{"line_number":5,"context_line":"    ``gpt``. Glance passes ``raw`` to ``qemu-img`` for a GPT image, because"},{"line_number":6,"context_line":"    ``qemu-img`` does not know ``gpt``. If the converted image does not"},{"line_number":7,"context_line":"    contain a GPT partition table, Glance stores it as ``raw``."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"42060ee8_3ef3c089","line":5,"range":{"start_line":4,"start_character":44,"end_line":5,"end_character":11},"in_reply_to":"e36e574c_b9922d4e","updated":"2026-10-23 12:34:03.000000000","message":"Done","commit_id":"d88964e166be40e6cbd592ad16e1ea7d0a0a1b1a"}]}
