)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"499684b5ea6d0ee60f610bca74d2faaac284605f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4afd681d_7c01c425","updated":"2025-01-20 10:49:18.000000000","message":"This series of patch seems related to eventlet, do you mind if we attach it the the eventlet-removal topic?","commit_id":"1c2f9d82316c3ac5008f8f1b340344a331087f86"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"76bba3c6a475951ce383026ca964d2997e78e390","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8d9b196a_1d2b9029","updated":"2025-02-11 16:47:00.000000000","message":"I\u0027m sending another patch to 1) fix this test 2) Not depend on eventlet.","commit_id":"3b82a341a1a632190c613f45f7d22c4a7785e393"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a15afe0f3de4ce6922b74d2daf25c1fc6d059826","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f028cfff_ed4e20f8","updated":"2025-02-07 15:58:08.000000000","message":"Voting -1 for visibility on my question","commit_id":"3b82a341a1a632190c613f45f7d22c4a7785e393"}],"glance/tests/functional/test_sqlite.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"47e974ff728784911d2b9246e34540f74cb55737","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        cmd \u003d \u0027sqlite3 tests.sqlite \".schema\"\u0027"},{"line_number":35,"context_line":"        exitcode, out, err \u003d execute(cmd, raise_error\u003dTrue)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.assertNotIn(\u0027BIGINT\u0027, out)"}],"source_content_type":"text/x-python","patch_set":1,"id":"8eab4a63_00cf8f24","line":37,"updated":"2025-01-09 15:23:10.000000000","message":"Hmm, this too seems kinda weird.. we\u0027re inheriting just to get a database setup for us that we can inspect? Also, asserting BIGINT is not in the output is not a very strong assertion, which makes me question if this is really doing anything useful. I know you didn\u0027t write this test, but...did you confirm it\u0027s actually showing the schema as expected? Could we maybe tighten this a bit, or just remove it if it\u0027s irrelevant now?","commit_id":"1c2f9d82316c3ac5008f8f1b340344a331087f86"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a15afe0f3de4ce6922b74d2daf25c1fc6d059826","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        cmd \u003d \u0027sqlite3 tests.sqlite \".schema\"\u0027"},{"line_number":35,"context_line":"        exitcode, out, err \u003d execute(cmd, raise_error\u003dTrue)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.assertNotIn(\u0027BIGINT\u0027, out)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dbc0418b_6163f04b","line":37,"in_reply_to":"8eab4a63_00cf8f24","updated":"2025-02-07 15:58:08.000000000","message":"Can I get an answer here?","commit_id":"1c2f9d82316c3ac5008f8f1b340344a331087f86"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"76bba3c6a475951ce383026ca964d2997e78e390","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        cmd \u003d \u0027sqlite3 tests.sqlite \".schema\"\u0027"},{"line_number":35,"context_line":"        exitcode, out, err \u003d execute(cmd, raise_error\u003dTrue)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.assertNotIn(\u0027BIGINT\u0027, out)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b2802dc0_47081d1e","line":37,"in_reply_to":"dbc0418b_6163f04b","updated":"2025-02-11 16:47:00.000000000","message":"yes, I missed it! Because the schema is empty, this assertion works every time... This test has not been doing anything for a while :-(\n\nWe are indeed inheriting just to get the database setup.","commit_id":"1c2f9d82316c3ac5008f8f1b340344a331087f86"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"76bba3c6a475951ce383026ca964d2997e78e390","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        \"\"\"Ensure BigInteger not mapped to BIGINT\"\"\""},{"line_number":32,"context_line":"        self.start_server()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        cmd \u003d \u0027sqlite3 tests.sqlite \".schema\"\u0027"},{"line_number":35,"context_line":"        exitcode, out, err \u003d execute(cmd, raise_error\u003dTrue)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.assertNotIn(\u0027BIGINT\u0027, out)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fca3a89c_6964287c","line":34,"range":{"start_line":34,"start_character":44,"end_line":34,"end_character":45},"updated":"2025-02-11 16:47:00.000000000","message":"This path does not exist, it should be os.path.join(self.test_dir, \u0027tests.sqlite\u0027). So sqlite3 returns... an empty string.","commit_id":"3b82a341a1a632190c613f45f7d22c4a7785e393"}]}