)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"30ade4da4ffe93ea94979d84ab764cab01340997","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e45e2065_01ad00cd","updated":"2025-02-20 15:33:41.000000000","message":"Thank you for the explanation!!","commit_id":"efe5441ee0f096e024d3a9d23e6581953d3843ef"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"21acd8c0fbe1e449aaa605fc5546edd3eebc1599","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"569a983c_fad4c52e","updated":"2025-02-25 16:12:14.000000000","message":"Seems reasonable and straight forward. Thanks!","commit_id":"046c738c4e4905eef600d86617d0eeaea6e2dc13"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"bb8a513b7c80ae02eedd7e83f620ad29b33a7704","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c839eed4_8d6d0b39","updated":"2025-02-25 17:18:31.000000000","message":"Thank you, just not sure whether to have a reno for the mention in commit related to ignoring the check by default for 1st release.","commit_id":"046c738c4e4905eef600d86617d0eeaea6e2dc13"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"42bd61c2a7bd022f2409e0037db0048dcb157f9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0e44e960_55222728","updated":"2025-02-25 18:37:34.000000000","message":"approving as this will unblock ironic which is failing due to recent changes which we merged related to format inspector safety checks.","commit_id":"046c738c4e4905eef600d86617d0eeaea6e2dc13"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4025cfce903379396e5c3b42aa01f46f261f9455","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d3ab2828_15e009b9","in_reply_to":"c839eed4_8d6d0b39","updated":"2025-02-25 17:34:39.000000000","message":"Yes, I will put a reno in the second patch once we get a run","commit_id":"046c738c4e4905eef600d86617d0eeaea6e2dc13"}],"glance/tests/unit/test_store_image.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8f065d6908b2735f6afab259922d21e7817e7e48","unresolved":true,"context_lines":[{"line_number":407,"context_line":"        store_api \u003d unit_test_utils.FakeStoreAPIReader(max_size\u003d2048)"},{"line_number":408,"context_line":"        image \u003d glance.location.ImageProxy(image_stub, context,"},{"line_number":409,"context_line":"                                           store_api, self.store_utils)"},{"line_number":410,"context_line":"        image.set_data(iter((data,)), 1024)"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    def test_image_set_data_inspector_no_match_disabled(self):"},{"line_number":413,"context_line":"        self.config(require_image_format_match\u003dFalse, group\u003d\u0027image_format\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"486574f7_084373bc","line":410,"updated":"2025-02-20 15:23:20.000000000","message":"Just failed to understand the purpose of this test, don\u0027t we want to assert anything here?","commit_id":"efe5441ee0f096e024d3a9d23e6581953d3843ef"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"30ade4da4ffe93ea94979d84ab764cab01340997","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        store_api \u003d unit_test_utils.FakeStoreAPIReader(max_size\u003d2048)"},{"line_number":408,"context_line":"        image \u003d glance.location.ImageProxy(image_stub, context,"},{"line_number":409,"context_line":"                                           store_api, self.store_utils)"},{"line_number":410,"context_line":"        image.set_data(iter((data,)), 1024)"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    def test_image_set_data_inspector_no_match_disabled(self):"},{"line_number":413,"context_line":"        self.config(require_image_format_match\u003dFalse, group\u003d\u0027image_format\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f73cddb9_0b18d805","line":410,"in_reply_to":"3147fc88_d6926c19","updated":"2025-02-20 15:33:41.000000000","message":"Ack, I failed to see ignored in the test name!!","commit_id":"efe5441ee0f096e024d3a9d23e6581953d3843ef"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a017c6890baec9d2faa1369140435629e5ddc6a3","unresolved":true,"context_lines":[{"line_number":407,"context_line":"        store_api \u003d unit_test_utils.FakeStoreAPIReader(max_size\u003d2048)"},{"line_number":408,"context_line":"        image \u003d glance.location.ImageProxy(image_stub, context,"},{"line_number":409,"context_line":"                                           store_api, self.store_utils)"},{"line_number":410,"context_line":"        image.set_data(iter((data,)), 1024)"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    def test_image_set_data_inspector_no_match_disabled(self):"},{"line_number":413,"context_line":"        self.config(require_image_format_match\u003dFalse, group\u003d\u0027image_format\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3147fc88_d6926c19","line":410,"in_reply_to":"486574f7_084373bc","updated":"2025-02-20 15:30:43.000000000","message":"This will fail (raise) if a safety check fails, the fact that we don\u0027t `assertRaises` here (and we pass the test) means the safety check failure was ignored per config (unlike the otherwise identical test above). L406 above makes it fail the check. L393 above shows what would happen if it was not ignored.","commit_id":"efe5441ee0f096e024d3a9d23e6581953d3843ef"}]}