)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b73d19c1aeaf8af5c1aa8a58585ff791eebbd407","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b0ce710b_bc3354b4","updated":"2025-02-20 15:28:35.000000000","message":"looks good, just suggestion on config param name, not pressing for it though!!","commit_id":"ce56a2c258bd2b08a6a4efdb31e1e747dfe230be"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"925947964fa8225025815a4efa17a3832859c733","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"721cc98b_0f0e7bd4","updated":"2025-02-24 20:54:41.000000000","message":"recheck","commit_id":"e38ee91371dbbd832608b6225344bdab23f6a285"}],"glance/common/config.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b73d19c1aeaf8af5c1aa8a58585ff791eebbd407","unresolved":true,"context_lines":[{"line_number":136,"context_line":"                       \u0027makes glance relax its definition of what a valid GPT \u0027"},{"line_number":137,"context_line":"                       \u0027disk image looks like and prevents strict adherence \u0027"},{"line_number":138,"context_line":"                       \u0027to the GPT spec.\u0027)),"},{"line_number":139,"context_line":"    cfg.BoolOpt(\u0027gpt_compat_as_raw\u0027,"},{"line_number":140,"context_line":"                default\u003dTrue,"},{"line_number":141,"context_line":"                help\u003d_(\u0027Allow images detected as GPT to be registered as \u0027"},{"line_number":142,"context_line":"                       \u0027disk_format\u003draw (i.e. compatibility with earlier \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5846a2dc_91689961","line":139,"range":{"start_line":139,"start_character":17,"end_line":139,"end_character":34},"updated":"2025-02-20 15:28:35.000000000","message":"allow_gpt_as_raw?","commit_id":"ce56a2c258bd2b08a6a4efdb31e1e747dfe230be"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"bb78d7ae1fc220eff61ed7f779c883cf69cfb5c5","unresolved":true,"context_lines":[{"line_number":136,"context_line":"                       \u0027makes glance relax its definition of what a valid GPT \u0027"},{"line_number":137,"context_line":"                       \u0027disk image looks like and prevents strict adherence \u0027"},{"line_number":138,"context_line":"                       \u0027to the GPT spec.\u0027)),"},{"line_number":139,"context_line":"    cfg.BoolOpt(\u0027gpt_compat_as_raw\u0027,"},{"line_number":140,"context_line":"                default\u003dTrue,"},{"line_number":141,"context_line":"                help\u003d_(\u0027Allow images detected as GPT to be registered as \u0027"},{"line_number":142,"context_line":"                       \u0027disk_format\u003draw (i.e. compatibility with earlier \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"a1893348_8989c235","line":139,"range":{"start_line":139,"start_character":17,"end_line":139,"end_character":34},"in_reply_to":"31aedfea_f35a6cd4","updated":"2025-02-20 15:35:23.000000000","message":"No worries, let\u0027s see if any one else has same thought or good to go!!","commit_id":"ce56a2c258bd2b08a6a4efdb31e1e747dfe230be"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"35546cc17376fbad0e1abddedd013dfe19e011f4","unresolved":true,"context_lines":[{"line_number":136,"context_line":"                       \u0027makes glance relax its definition of what a valid GPT \u0027"},{"line_number":137,"context_line":"                       \u0027disk image looks like and prevents strict adherence \u0027"},{"line_number":138,"context_line":"                       \u0027to the GPT spec.\u0027)),"},{"line_number":139,"context_line":"    cfg.BoolOpt(\u0027gpt_compat_as_raw\u0027,"},{"line_number":140,"context_line":"                default\u003dTrue,"},{"line_number":141,"context_line":"                help\u003d_(\u0027Allow images detected as GPT to be registered as \u0027"},{"line_number":142,"context_line":"                       \u0027disk_format\u003draw (i.e. compatibility with earlier \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"31aedfea_f35a6cd4","line":139,"range":{"start_line":139,"start_character":17,"end_line":139,"end_character":34},"in_reply_to":"5846a2dc_91689961","updated":"2025-02-20 15:31:50.000000000","message":"I was trying to keep all the GPT-related things prefixed with `gpt_` but I can change it if that\u0027s what you\u0027re asking for.","commit_id":"ce56a2c258bd2b08a6a4efdb31e1e747dfe230be"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e6bfd6d84b8b968b58cbe6c168887be4d8356601","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                       \u0027makes glance relax its definition of what a valid GPT \u0027"},{"line_number":137,"context_line":"                       \u0027disk image looks like and prevents strict adherence \u0027"},{"line_number":138,"context_line":"                       \u0027to the GPT spec.\u0027)),"},{"line_number":139,"context_line":"    cfg.BoolOpt(\u0027gpt_compat_as_raw\u0027,"},{"line_number":140,"context_line":"                default\u003dTrue,"},{"line_number":141,"context_line":"                help\u003d_(\u0027Allow images detected as GPT to be registered as \u0027"},{"line_number":142,"context_line":"                       \u0027disk_format\u003draw (i.e. compatibility with earlier \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"6feb1565_7c8df837","line":139,"range":{"start_line":139,"start_character":17,"end_line":139,"end_character":34},"in_reply_to":"a1893348_8989c235","updated":"2025-02-26 06:49:14.000000000","message":"Done","commit_id":"ce56a2c258bd2b08a6a4efdb31e1e747dfe230be"}],"glance/tests/unit/test_store_image.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e6bfd6d84b8b968b58cbe6c168887be4d8356601","unresolved":true,"context_lines":[{"line_number":438,"context_line":"        image_stub.disk_format \u003d \u0027raw\u0027"},{"line_number":439,"context_line":"        image \u003d glance.location.ImageProxy(image_stub, context,"},{"line_number":440,"context_line":"                                           store_api, self.store_utils)"},{"line_number":441,"context_line":"        self.assertRaisesRegex(exception.InvalidImageData,"},{"line_number":442,"context_line":"                               \u0027failed safety\u0027,"},{"line_number":443,"context_line":"                               image.set_data, iter((data,)), 1024)"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"        # Finally, with compat enabled and valid data, we should be allowed"},{"line_number":446,"context_line":"        # to upload GPT data into a raw image"}],"source_content_type":"text/x-python","patch_set":7,"id":"603b9242_6fbd171a","line":443,"range":{"start_line":441,"start_character":8,"end_line":443,"end_character":67},"updated":"2025-02-26 06:49:14.000000000","message":"I think this check should not be required, might be leftover or something missed during rebase/retool of the patches.","commit_id":"202bc1d0faac8dc74aa05fcfd0d3eefaa509aae8"}]}