)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5221fd7d355a255fce20ae869f79e5610f973347","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c1c4dfd2_ab540480","updated":"2025-01-29 13:40:53.000000000","message":"Suggestion inline, but otherwise this LGTM.","commit_id":"abdeba48f61cd2235bb9023877d6f5d9a3531a98"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"db3df9473458c5f4e56a2fba07ea67869c8fdaf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2890dfe2_1e91ab5e","updated":"2025-02-03 19:19:54.000000000","message":"OK, I\u0027ll agree with Cyril on this.  LGTM.","commit_id":"33fa9596ebbd7ed16e2bbdba5fab2f6eeb8eb5c2"}],"glance/common/utils.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5221fd7d355a255fce20ae869f79e5610f973347","unresolved":true,"context_lines":[{"line_number":728,"context_line":"            return 0"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"    sorted_locations \u003d sorted(locations, key\u003dget_store_weight, reverse\u003dTrue)"},{"line_number":731,"context_line":"    LOG.debug((\u0027Sorted locations: %s\u0027), sorted_locations)"},{"line_number":732,"context_line":"    return sorted_locations"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"550edf89_d18fdaac","side":"PARENT","line":731,"updated":"2025-01-29 13:40:53.000000000","message":"Would it be useful to log a scrubbed list to help operators in debugging?  Something like:\n\n```\n# Bug #2095304: log a bare minimum of sorted location info\nscrubbed \u003d [ {\u0027location_id\u0027: loc[\"id\"], \u0027store_name\u0027: loc[\"metadata\"].get(\"store\")} for loc in sorted_loc ]\nLOG.debug((\u0027Sorted locations: %s\u0027), scrubbed)\n```","commit_id":"afaa1900283fb7f09e401b2faff16289aeeb687c"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"50f699575506678e52353a35312e514f0c6d568f","unresolved":true,"context_lines":[{"line_number":728,"context_line":"            return 0"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"    sorted_locations \u003d sorted(locations, key\u003dget_store_weight, reverse\u003dTrue)"},{"line_number":731,"context_line":"    LOG.debug((\u0027Sorted locations: %s\u0027), sorted_locations)"},{"line_number":732,"context_line":"    return sorted_locations"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a3c41e96_9b66a5f1","side":"PARENT","line":731,"in_reply_to":"2fedd8df_4d24d6d4","updated":"2025-02-03 16:20:58.000000000","message":"I think ideally all stores should have a sanitize_location() method in which they implement the removal of secrets/passwords/tokens. When logging from glance, we would not log the value of the variable but we\u0027d log whatever was sanitized by the store.\n\nRight now I\u0027d be in favor of merging this patch though.","commit_id":"afaa1900283fb7f09e401b2faff16289aeeb687c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"7db4dbd5a5753d97cf34efb983acf9ef034b3d3c","unresolved":true,"context_lines":[{"line_number":728,"context_line":"            return 0"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"    sorted_locations \u003d sorted(locations, key\u003dget_store_weight, reverse\u003dTrue)"},{"line_number":731,"context_line":"    LOG.debug((\u0027Sorted locations: %s\u0027), sorted_locations)"},{"line_number":732,"context_line":"    return sorted_locations"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2fedd8df_4d24d6d4","side":"PARENT","line":731,"in_reply_to":"550edf89_d18fdaac","updated":"2025-01-29 14:26:30.000000000","message":"I think only store name is enough, Id is of no use even for developer","commit_id":"afaa1900283fb7f09e401b2faff16289aeeb687c"}]}