)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"90b47b48eadc5903c29bcd5c27aae7dc54663bd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9c6569cd_fd5a4d5e","updated":"2025-04-23 17:52:41.000000000","message":"Nitpicking a bit but it looks great!","commit_id":"5badf74f78d0636a2daf352f651d108051af3cd8"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fcb4808a14b4553a09a4dda8e77b03120fef12e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8953ade7_edcd1d33","updated":"2025-04-24 06:35:59.000000000","message":"Thank you for your inputs, made changes as per suggestions!!","commit_id":"5badf74f78d0636a2daf352f651d108051af3cd8"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"eb7a7f15729738da9401816b5d060f5f5425ffbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8a3c4381_e5a05b6d","updated":"2025-04-24 08:54:37.000000000","message":"recheck","commit_id":"0660696663f26f09eca12d6e18cab29dd9abb699"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"173902a4f033c6288ceaf1f39e3af5db8e3ef105","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d36d13fd_e98aa93a","updated":"2025-05-14 18:54:56.000000000","message":"recheck error while image deletion,looks like related to default hash calculation on snapshot","commit_id":"0660696663f26f09eca12d6e18cab29dd9abb699"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e8f549ac9f20808a66bc8c6f43fe00c4e82ab347","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0c436bdd_452bef61","updated":"2025-05-15 02:14:24.000000000","message":"recheck multiple unrelated failures","commit_id":"0660696663f26f09eca12d6e18cab29dd9abb699"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ffeb4ed9e29902a02d01a70925622eeb4fc8ca63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aa9751e2_a4c0243c","updated":"2025-05-15 08:12:23.000000000","message":"recheck restoring image failed + hash calculation related issues","commit_id":"0660696663f26f09eca12d6e18cab29dd9abb699"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0b6fc10114e0dc44a660d15bc57e62290226980b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dd1b018c_87f4fa19","updated":"2025-05-15 06:03:25.000000000","message":"recheck scrubber fails to shutdown","commit_id":"0660696663f26f09eca12d6e18cab29dd9abb699"}],"glance/cmd/scrubber.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"90b47b48eadc5903c29bcd5c27aae7dc54663bd1","unresolved":true,"context_lines":[{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"Glance Scrub Service"},{"line_number":20,"context_line":"\"\"\""},{"line_number":21,"context_line":"import os"},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import subprocess"}],"source_content_type":"text/x-python","patch_set":3,"id":"bb3a2144_2276403c","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":6},"updated":"2025-04-23 17:52:41.000000000","message":"Let\u0027s not remove empty lines","commit_id":"5badf74f78d0636a2daf352f651d108051af3cd8"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fcb4808a14b4553a09a4dda8e77b03120fef12e3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"Glance Scrub Service"},{"line_number":20,"context_line":"\"\"\""},{"line_number":21,"context_line":"import os"},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import subprocess"}],"source_content_type":"text/x-python","patch_set":3,"id":"47405cb3_1c421618","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":6},"in_reply_to":"bb3a2144_2276403c","updated":"2025-04-24 06:35:59.000000000","message":"Acknowledged","commit_id":"5badf74f78d0636a2daf352f651d108051af3cd8"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"90b47b48eadc5903c29bcd5c27aae7dc54663bd1","unresolved":true,"context_lines":[{"line_number":53,"context_line":"        config.parse_args()"},{"line_number":54,"context_line":"        logging.setup(CONF, \u0027glance\u0027)"},{"line_number":55,"context_line":"        CONF.import_opt(\u0027enabled_backends\u0027, \u0027glance.common.wsgi\u0027)"},{"line_number":56,"context_line":"        if CONF.enabled_backends:"},{"line_number":57,"context_line":"            glance_store.register_store_opts(CONF)"},{"line_number":58,"context_line":"            glance_store.create_multi_stores(CONF)"},{"line_number":59,"context_line":"            glance_store.verify_store()"}],"source_content_type":"text/x-python","patch_set":3,"id":"169e3824_2181c5e4","line":56,"range":{"start_line":56,"start_character":11,"end_line":56,"end_character":15},"updated":"2025-04-23 17:52:41.000000000","message":"Ditto","commit_id":"5badf74f78d0636a2daf352f651d108051af3cd8"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fcb4808a14b4553a09a4dda8e77b03120fef12e3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        config.parse_args()"},{"line_number":54,"context_line":"        logging.setup(CONF, \u0027glance\u0027)"},{"line_number":55,"context_line":"        CONF.import_opt(\u0027enabled_backends\u0027, \u0027glance.common.wsgi\u0027)"},{"line_number":56,"context_line":"        if CONF.enabled_backends:"},{"line_number":57,"context_line":"            glance_store.register_store_opts(CONF)"},{"line_number":58,"context_line":"            glance_store.create_multi_stores(CONF)"},{"line_number":59,"context_line":"            glance_store.verify_store()"}],"source_content_type":"text/x-python","patch_set":3,"id":"e817b7f8_34ee442e","line":56,"range":{"start_line":56,"start_character":11,"end_line":56,"end_character":15},"in_reply_to":"169e3824_2181c5e4","updated":"2025-04-24 06:35:59.000000000","message":"Acknowledged","commit_id":"5badf74f78d0636a2daf352f651d108051af3cd8"}],"glance/scrubber.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"90b47b48eadc5903c29bcd5c27aae7dc54663bd1","unresolved":true,"context_lines":[{"line_number":380,"context_line":"        if delete_jobs:"},{"line_number":381,"context_line":"            list(self.pool.starmap(self._scrub_image, delete_jobs.items()))"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    def _scrub_image(self, image_id, delete_jobs):"},{"line_number":384,"context_line":"        if len(delete_jobs) \u003d\u003d 0:"},{"line_number":385,"context_line":"            return"},{"line_number":386,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"cd0ac251_98b0edf9","side":"PARENT","line":383,"range":{"start_line":383,"start_character":8,"end_line":383,"end_character":20},"updated":"2025-04-23 17:52:41.000000000","message":"OK, I don\u0027t know how the image_id was passed to this method before, but the new version makes more sense :)","commit_id":"7dbb31949e7454c680ec3c1fdad06bd90b48ac9f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fcb4808a14b4553a09a4dda8e77b03120fef12e3","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        if delete_jobs:"},{"line_number":381,"context_line":"            list(self.pool.starmap(self._scrub_image, delete_jobs.items()))"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    def _scrub_image(self, image_id, delete_jobs):"},{"line_number":384,"context_line":"        if len(delete_jobs) \u003d\u003d 0:"},{"line_number":385,"context_line":"            return"},{"line_number":386,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a144171e_d9f7f12d","side":"PARENT","line":383,"range":{"start_line":383,"start_character":8,"end_line":383,"end_character":20},"in_reply_to":"cd0ac251_98b0edf9","updated":"2025-04-24 06:35:59.000000000","message":"starmap method at line 381 was accepting delete_jobs.items() where image_id was key and rest details are it\u0027s values i.e. location information.","commit_id":"7dbb31949e7454c680ec3c1fdad06bd90b48ac9f"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"90b47b48eadc5903c29bcd5c27aae7dc54663bd1","unresolved":true,"context_lines":[{"line_number":318,"context_line":"                     \"threads\u003d%(threads)s\"),"},{"line_number":319,"context_line":"                 {\u0027wakeup_time\u0027: wakeup_time, \u0027threads\u0027: threads})"},{"line_number":320,"context_line":"        self.wakeup_time \u003d wakeup_time"},{"line_number":321,"context_line":"        self.executor \u003d futures.ThreadPoolExecutor(max_workers\u003dthreads)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def start(self, application):"},{"line_number":324,"context_line":"        self._run(application)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5be7d047_e0da34f1","line":321,"range":{"start_line":321,"start_character":22,"end_line":321,"end_character":23},"updated":"2025-04-23 17:52:41.000000000","message":"Do we want to keep the comment about the use of this pool?","commit_id":"5badf74f78d0636a2daf352f651d108051af3cd8"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fcb4808a14b4553a09a4dda8e77b03120fef12e3","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                     \"threads\u003d%(threads)s\"),"},{"line_number":319,"context_line":"                 {\u0027wakeup_time\u0027: wakeup_time, \u0027threads\u0027: threads})"},{"line_number":320,"context_line":"        self.wakeup_time \u003d wakeup_time"},{"line_number":321,"context_line":"        self.executor \u003d futures.ThreadPoolExecutor(max_workers\u003dthreads)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def start(self, application):"},{"line_number":324,"context_line":"        self._run(application)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1d2a6e6c_37d2cdc9","line":321,"range":{"start_line":321,"start_character":22,"end_line":321,"end_character":23},"in_reply_to":"5be7d047_e0da34f1","updated":"2025-04-24 06:35:59.000000000","message":"Done","commit_id":"5badf74f78d0636a2daf352f651d108051af3cd8"}]}