)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f6c8f87cf55696a7742a4ac88e3d75297f904474","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ea4edb7a_9b39e79c","updated":"2025-05-30 13:20:33.000000000","message":"I\u0027ll have to dig into the oslo fixture to see if the passing of {} as the second argument is appropriate, but maybe melwitt knows since she was involved here.","commit_id":"e055873be4079bc9d37165cf75de5495603133b0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5f210211a20aa09027ef7a019028f86346a5ba99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3207a098_b65156c3","updated":"2025-05-30 19:28:21.000000000","message":"Just realized that though I tested this locally with oslo.limit 2.7.0, this patch is using the current upper constraint of oslo.limit\u003d\u003d\u003d2.6.1 ... but you can see the glance tests passing on the u-c patch, which has this patch as a dependency: https://review.opendev.org/c/openstack/glance/+/951351","commit_id":"e055873be4079bc9d37165cf75de5495603133b0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0e099b75f6e9b07a131c59ae2253cf838277706f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"11a32735_122464ed","updated":"2025-06-03 07:59:50.000000000","message":"Looks good!!!","commit_id":"e055873be4079bc9d37165cf75de5495603133b0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"336fcafdb22ba2a9092aaf4a02c5874918481ce7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"09e40842_321d4179","updated":"2025-05-30 18:34:20.000000000","message":"Thanks melwitt!","commit_id":"e055873be4079bc9d37165cf75de5495603133b0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8b836c3f7fb3f284899ce5163bc0e1368571233d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b0706a47_a34ba587","updated":"2025-05-30 13:36:04.000000000","message":"Yes, it would be good to have Melanie\u0027s input.  My theory is that we are only testing resource limits, so only need to populate the reglimits dict and not the projlimits dict, but i\u0027ll be honest and say my theory is based on the fact that the tests pass, not on really understanding what\u0027s going on in oslo.limit.","commit_id":"e055873be4079bc9d37165cf75de5495603133b0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"01dd8d000a3973cc9d9b2f05e2d61b1566e8ee9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7eb1e0fe_83756304","in_reply_to":"1f09a882_07914cc9","updated":"2025-05-30 18:23:36.000000000","message":"Brian is correct, if you are only testing or setting default limits and are not testing or setting any project-scoped limits, then you would have an empty project limits dict in the oslo.limit fixture.","commit_id":"e055873be4079bc9d37165cf75de5495603133b0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1d2d63b5b30d7642724a5578c25da3656e5895c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ed870612_b0932671","in_reply_to":"3207a098_b65156c3","updated":"2025-05-30 19:29:45.000000000","message":"Bad paste on that url ... the u-c patch is https://review.opendev.org/c/openstack/requirements/+/951104","commit_id":"e055873be4079bc9d37165cf75de5495603133b0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0bca5babfca9236773f4c02f6a01f5dde25916b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1f09a882_07914cc9","in_reply_to":"b0706a47_a34ba587","updated":"2025-05-30 13:42:18.000000000","message":"Ack, I didn\u0027t even look close enough to see what it was. I\u0027ll throw a +2 on here so that it\u0027s closer to merge-able, once we get melwitt to have a look (or if I get a chance).","commit_id":"e055873be4079bc9d37165cf75de5495603133b0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"01dd8d000a3973cc9d9b2f05e2d61b1566e8ee9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9b2f4803_0a134459","in_reply_to":"ea4edb7a_9b39e79c","updated":"2025-05-30 18:23:36.000000000","message":"Yes, passing {} as the second arg is appropriate if you are not testing or setting any project-specific limits in your tests. First arg is a dict for default/registered limits and the second arg is a dict for project limits.","commit_id":"e055873be4079bc9d37165cf75de5495603133b0"}]}