)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"322001216618eb8f29fb5557d2c64c5cde16a6b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0f19a234_68f14702","updated":"2025-09-08 14:38:53.000000000","message":"Seems reasonable but this should be quickly discussed during the next PTG.","commit_id":"91c753d2ed57799d7a098af811309e7c96c6d0ad"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8444872488b4bd4465ef02da95bf2ab54745990d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b6ee38ee_72c0a646","updated":"2025-09-17 15:13:46.000000000","message":"Please also update glance/opts.py so that these new options are loaded by oslo-config-generator","commit_id":"0662192a970329dd5d3d054d250abe3019c5f703"},{"author":{"_account_id":38117,"name":"Eimad Zamrik","email":"zamrik.eimad@proton.me","username":"ezamrik"},"change_message_id":"d101706b193cc586de7d12d4ac396e93c7491098","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"73e3d336_23c6aa94","in_reply_to":"b6ee38ee_72c0a646","updated":"2025-09-18 23:16:05.000000000","message":"Ah yes, thanks for the catch! \nI went ahead and added the configs to the opts.py:_image_import_opts list under group None. This will make olso generate the configs under default when utilizing the glance namespace.","commit_id":"0662192a970329dd5d3d054d250abe3019c5f703"},{"author":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"change_message_id":"c4785b8982cd180d9885914fc23c98b9e9603a04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c823ecfd_c3152cac","updated":"2025-09-25 16:29:21.000000000","message":"recheck","commit_id":"d6f7212819c0e4f7df1f75e262f763ddf7657853"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"7a9c49e900ff05a90fe0118a7a86abf34a1bcf95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4dc0fec4_b66ffa6d","updated":"2026-07-06 16:00:09.000000000","message":"OK this is a new feature, so this might have to wait for the next cycle. Still it seems pretty small and does not change any default behaviour, so I\u0027ll discuss it with the team on Thursday.","commit_id":"7658b9c67145f3b564ea08e743bf7b4d2c692787"}],"glance/async_/utils.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"322001216618eb8f29fb5557d2c64c5cde16a6b3","unresolved":true,"context_lines":[{"line_number":30,"context_line":"# when the size of an image exceeds 1GB and the time exceeds 2 seconds. This"},{"line_number":31,"context_line":"# results in a failed import in those cases, and should be configurable"},{"line_number":32,"context_line":"# in the same fashion as Cinder is, captured at #1785340."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"image_opts \u003d ["},{"line_number":35,"context_line":"    cfg.IntOpt("},{"line_number":36,"context_line":"        \u0027image_conversion_cpu_limit\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"303110eb_afaaaf35","line":33,"updated":"2025-09-08 14:38:53.000000000","message":"Please keep hemanthm\u0027s note as is, and add your own.\n\nAlso, I think you want to mention ubg #1705340, not #1785340","commit_id":"91c753d2ed57799d7a098af811309e7c96c6d0ad"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"f5bdcb3c153da3a71fbf63482f4d68de4aa7f777","unresolved":true,"context_lines":[{"line_number":30,"context_line":"# when the size of an image exceeds 1GB and the time exceeds 2 seconds. This"},{"line_number":31,"context_line":"# results in a failed import in those cases, and should be configurable"},{"line_number":32,"context_line":"# in the same fashion as Cinder is, captured at #1785340."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"image_opts \u003d ["},{"line_number":35,"context_line":"    cfg.IntOpt("},{"line_number":36,"context_line":"        \u0027image_conversion_cpu_limit\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"a408a729_411108a1","line":33,"in_reply_to":"303110eb_afaaaf35","updated":"2025-09-08 14:52:39.000000000","message":"Well, maybe not exactly \"as is\" because it mentions the default values, but it\u0027s nice to have context on why we have the prlimits in the first place.","commit_id":"91c753d2ed57799d7a098af811309e7c96c6d0ad"},{"author":{"_account_id":38117,"name":"Eimad Zamrik","email":"zamrik.eimad@proton.me","username":"ezamrik"},"change_message_id":"d101706b193cc586de7d12d4ac396e93c7491098","unresolved":true,"context_lines":[{"line_number":30,"context_line":"# when the size of an image exceeds 1GB and the time exceeds 2 seconds. This"},{"line_number":31,"context_line":"# results in a failed import in those cases, and should be configurable"},{"line_number":32,"context_line":"# in the same fashion as Cinder is, captured at #1785340."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"image_opts \u003d ["},{"line_number":35,"context_line":"    cfg.IntOpt("},{"line_number":36,"context_line":"        \u0027image_conversion_cpu_limit\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3eaef73d_cd61c602","line":33,"in_reply_to":"a408a729_411108a1","updated":"2025-09-18 23:16:05.000000000","message":"That makes sense, i\u0027ve went ahead and tweaked the descriptions describing the story and context a bit more than before","commit_id":"91c753d2ed57799d7a098af811309e7c96c6d0ad"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8444872488b4bd4465ef02da95bf2ab54745990d","unresolved":true,"context_lines":[{"line_number":39,"context_line":"image_opts \u003d ["},{"line_number":40,"context_line":"    cfg.IntOpt("},{"line_number":41,"context_line":"        \u0027image_conversion_cpu_limit\u0027,"},{"line_number":42,"context_line":"        default\u003d2,"},{"line_number":43,"context_line":"        help\u003d\u0027CPU time limit in seconds to convert the image\u0027"},{"line_number":44,"context_line":"    ),"},{"line_number":45,"context_line":"    cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":7,"id":"3c126959_ef71f76f","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":18},"updated":"2025-09-17 15:13:46.000000000","message":"Maybe it makes sense to add min (min\u003d1 ?) to avoid problems caused by 0 or negative values.","commit_id":"0662192a970329dd5d3d054d250abe3019c5f703"},{"author":{"_account_id":38117,"name":"Eimad Zamrik","email":"zamrik.eimad@proton.me","username":"ezamrik"},"change_message_id":"d101706b193cc586de7d12d4ac396e93c7491098","unresolved":true,"context_lines":[{"line_number":39,"context_line":"image_opts \u003d ["},{"line_number":40,"context_line":"    cfg.IntOpt("},{"line_number":41,"context_line":"        \u0027image_conversion_cpu_limit\u0027,"},{"line_number":42,"context_line":"        default\u003d2,"},{"line_number":43,"context_line":"        help\u003d\u0027CPU time limit in seconds to convert the image\u0027"},{"line_number":44,"context_line":"    ),"},{"line_number":45,"context_line":"    cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":7,"id":"642e87ef_3ce93e48","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":18},"in_reply_to":"3c126959_ef71f76f","updated":"2025-09-18 23:16:05.000000000","message":"Agreed, that definitely would be useful. I\u0027ve went ahead and set min 1 to both config options for now. That should be suffice for most use cases","commit_id":"0662192a970329dd5d3d054d250abe3019c5f703"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cfb81f5da353478b84b5e8280b8364791d72a7c5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"image_opts \u003d ["},{"line_number":40,"context_line":"    cfg.IntOpt("},{"line_number":41,"context_line":"        \u0027image_conversion_cpu_limit\u0027,"},{"line_number":42,"context_line":"        default\u003d2,"},{"line_number":43,"context_line":"        help\u003d\u0027CPU time limit in seconds to convert the image\u0027"},{"line_number":44,"context_line":"    ),"},{"line_number":45,"context_line":"    cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":7,"id":"374b1efc_62f19f23","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":18},"in_reply_to":"642e87ef_3ce93e48","updated":"2026-09-03 04:44:04.000000000","message":"Done","commit_id":"0662192a970329dd5d3d054d250abe3019c5f703"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4fb5013c76be89c838df2c00ec4dc8495473e586","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    ),"},{"line_number":45,"context_line":"    cfg.IntOpt("},{"line_number":46,"context_line":"        \u0027image_conversion_address_space_limit\u0027,"},{"line_number":47,"context_line":"        default\u003d1 * units.Gi,"},{"line_number":48,"context_line":"        help\u003d\u0027Address space limit in gigabytes to convert the image\u0027"},{"line_number":49,"context_line":"    ),"},{"line_number":50,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"00d2c65e_ff683589","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":29},"updated":"2025-09-17 15:14:59.000000000","message":"I\u0027m unsure what would be the appropriate min value but at least we can enforce usage of non-zero and non-negative values by min\u003d1.","commit_id":"0662192a970329dd5d3d054d250abe3019c5f703"},{"author":{"_account_id":38117,"name":"Eimad Zamrik","email":"zamrik.eimad@proton.me","username":"ezamrik"},"change_message_id":"d101706b193cc586de7d12d4ac396e93c7491098","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    ),"},{"line_number":45,"context_line":"    cfg.IntOpt("},{"line_number":46,"context_line":"        \u0027image_conversion_address_space_limit\u0027,"},{"line_number":47,"context_line":"        default\u003d1 * units.Gi,"},{"line_number":48,"context_line":"        help\u003d\u0027Address space limit in gigabytes to convert the image\u0027"},{"line_number":49,"context_line":"    ),"},{"line_number":50,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"21a7cc7d_e61942a4","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":29},"in_reply_to":"00d2c65e_ff683589","updated":"2025-09-18 23:16:05.000000000","message":"Acknowledged","commit_id":"0662192a970329dd5d3d054d250abe3019c5f703"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cfb81f5da353478b84b5e8280b8364791d72a7c5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    ),"},{"line_number":45,"context_line":"    cfg.IntOpt("},{"line_number":46,"context_line":"        \u0027image_conversion_address_space_limit\u0027,"},{"line_number":47,"context_line":"        default\u003d1 * units.Gi,"},{"line_number":48,"context_line":"        help\u003d\u0027Address space limit in gigabytes to convert the image\u0027"},{"line_number":49,"context_line":"    ),"},{"line_number":50,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"e7a694df_12598752","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":29},"in_reply_to":"21a7cc7d_e61942a4","updated":"2026-09-03 04:44:04.000000000","message":"Done","commit_id":"0662192a970329dd5d3d054d250abe3019c5f703"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"87b4308f4b11678704825c6cbf7d4bb95570a1f5","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    ),"},{"line_number":46,"context_line":"    cfg.IntOpt("},{"line_number":47,"context_line":"        \u0027image_conversion_address_space_limit\u0027,"},{"line_number":48,"context_line":"        default\u003d1 * units.Gi,"},{"line_number":49,"context_line":"        min\u003d1,"},{"line_number":50,"context_line":"        help\u003d\u0027Address space limit in gigabytes to convert the image\u0027"},{"line_number":51,"context_line":"    ),"}],"source_content_type":"text/x-python","patch_set":12,"id":"5123eeb2_9ccc1642","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":29},"updated":"2026-10-27 07:33:53.000000000","message":"Since the value is multiplied by units.Gi again when QEMU_IMG_PROC_LIMITS is\nbuilt, this default should probably be 1 rather than 1 * units.Gi. Otherwise the\ndefault becomes 1 EiB, not 1 GiB.","commit_id":"63e91a351901b1647ce47c71fb042842e63b1f77"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"87b4308f4b11678704825c6cbf7d4bb95570a1f5","unresolved":true,"context_lines":[{"line_number":54,"context_line":"CONF \u003d cfg.CONF"},{"line_number":55,"context_line":"CONF.register_opts(image_conv_opts)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"QEMU_IMG_PROC_LIMITS \u003d putils.ProcessLimits("},{"line_number":58,"context_line":"    cpu_time\u003dCONF.image_conversion_cpu_limit,"},{"line_number":59,"context_line":"    address_space\u003dCONF.image_conversion_address_space_limit * units.Gi)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class OptionalTask(task.Task):"}],"source_content_type":"text/x-python","patch_set":12,"id":"c9fab3fe_6f4a87e6","line":59,"range":{"start_line":57,"start_character":0,"end_line":59,"end_character":71},"updated":"2026-10-27 07:33:53.000000000","message":"The default is already specified as 1 * units.Gi on the option, but here we\nmultiply the configured value by units.Gi again. That makes the default\neffectively 1 EiB instead of 1 GiB.\n\nIf this option is meant to be a number of GiB, I think the default should be 1,\nand this multiplication can stay here:\n\n    default\u003d1\n\nIt would also be good to update the help text to say \"GiB\" rather than\n\"gigabytes\", since units.Gi is gibibytes.","commit_id":"63e91a351901b1647ce47c71fb042842e63b1f77"}],"releasenotes/notes/add-new-image-conversion-configure-options-fca2e19a5ff6472f.yaml":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"7a9c49e900ff05a90fe0118a7a86abf34a1bcf95","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    When the size of an image exceeds 1GB and the processing time exceeds 2 seconds."},{"line_number":16,"context_line":"    This results in a failed import in those cases. It was not possible to configure"},{"line_number":17,"context_line":"    the qemu img process limit cpu or address space parameters."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"540422a8_d32d08e0","line":17,"range":{"start_line":17,"start_character":52,"end_line":17,"end_character":62},"updated":"2026-07-06 16:00:09.000000000","message":"I think we could remove the \"issues\" part, as I believe it would be about new issues introduced in a release.","commit_id":"7658b9c67145f3b564ea08e743bf7b4d2c692787"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cfb81f5da353478b84b5e8280b8364791d72a7c5","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    When the size of an image exceeds 1GB and the processing time exceeds 2 seconds."},{"line_number":16,"context_line":"    This results in a failed import in those cases. It was not possible to configure"},{"line_number":17,"context_line":"    the qemu img process limit cpu or address space parameters."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bec7d2b9_8afb4fa2","line":17,"range":{"start_line":17,"start_character":52,"end_line":17,"end_character":62},"in_reply_to":"540422a8_d32d08e0","updated":"2026-09-03 04:44:04.000000000","message":"Yeah the issues section is meant to be used to describe known but unfixed issues.\n\nMaybe add it to the fixes section, or shortly explain it in the existing features section is better.","commit_id":"7658b9c67145f3b564ea08e743bf7b4d2c692787"}]}
