)]}'
{"id":"openstack%2Fglance~962445","triplet_id":"openstack%2Fglance~master~I4d24fc267c093e4b8845973b739cd22e686b2312","project":"openstack/glance","branch":"master","topic":"fix-multiattach-handling","attention_set":{},"removed_from_attention_set":{"27615":{"account":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"last_update":"2025-10-08 09:12:11.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I4d24fc267c093e4b8845973b739cd22e686b2312","subject":"Remove legacy update tests","status":"MERGED","created":"2025-09-27 16:10:12.000000000","updated":"2025-10-08 09:13:18.000000000","submitted":"2025-10-08 09:12:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"962445-fix-multiattach-handling","meta_rev_id":"8bd396d952f4016d3b23e155c58c937d1a9f2118","_number":962445,"virtual_id_number":962445,"owner":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-10-08 09:12:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":2,"date":"2025-10-08 08:04:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":2,"date":"2025-09-29 14:04:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":1,"date":"2025-10-08 08:04:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-27 16:26:05.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-09-27 17:04:21.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-09-29 14:04:07.000000000","updated_by":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"reviewer":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"state":"REVIEWER"},{"updated":"2025-10-08 08:04:11.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"}],"messages":[{"id":"5b178a1ea819bc9554dd6b24e98e9259279a594b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2025-09-27 16:10:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c932f89faa322c1f43489cbf57165b500bed24aa","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2025-09-27 16:15:28.000000000","message":"Topic set to fix-multiattach-handling","accounts_in_message":[],"_revision_number":1},{"id":"8ecae94e691e05e83526c40e98822766014117fc","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-27 16:26:05.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b51d3c9260964ce995b016e73216a4ec\n\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/58c5cf904ba24489ae283592dcfc8159 : SUCCESS in 7m 21s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/10416f352a61452282ee9d4fd99bfdc6 : SUCCESS in 9m 54s (non-voting)\n- openstack-tox-py313-arm64 https://zuul.opendev.org/t/openstack/build/1ecba9dad3d04e70a61d343d7e7f58a6 : SUCCESS in 14m 14s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c5b59a830475a889ee0963f5eda799a1fb5657de","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-27 17:04:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/548b5be8e8744acdb6c85c0d807267bc\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/9bcc4c111fc44a39b2f88e4a5eaa465a : SUCCESS in 52m 04s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/ff71a43e3f4d4a98813278a373550925 : SUCCESS in 35m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d4db1379038b4e9089484e9844d2702a : SUCCESS in 3m 24s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/87d335c936be426e9a2ad62d9156bffe : SUCCESS in 4m 21s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/7f8e2f787d3e42f49216669ff8888f7f : SUCCESS in 3m 08s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/348b01861ecb4470af1f5df86bfb8877 : SUCCESS in 7m 17s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f4d81ed47d34482dbf0984c4c4e9df7b : SUCCESS in 3m 43s\n- openstack-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/af3d18be3f6345d2a8b44bde6fed20a3 : SUCCESS in 6m 46s\n- openstack-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/d202809a98894908b2384a51f258c08e : SUCCESS in 9m 19s\n- glance-secure-rbac-protection-functional https://zuul.opendev.org/t/openstack/build/20217bf17a1d49b1ad9898d1d538f659 : SUCCESS in 17m 27s","accounts_in_message":[],"_revision_number":1},{"id":"6fa0ec3cf0b6e4a41e00abad90818c20872252fb","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2025-09-29 14:04:07.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0c2f39f5b01348eee59f58eda734ea7f3e6eff3d","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2025-10-08 08:04:11.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"b531cfd4ca34a72cd72f73d1954a5beb971ea67a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-10-08 08:04:36.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"addb67fe1124fec81c7a24b57354fc2c2455b6f6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-10-08 09:12:11.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6b21cdd1743a4f288564d88787b5c1e1\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/d68a9990de3f4c32950d768b47aa84cf : SUCCESS in 41m 04s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/e21f0784145446dea02a903f26d2efab : SUCCESS in 1h 02m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2637490a4c2149b59e644a18a1642095 : SUCCESS in 4m 07s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/849d72baedd34fc4831314308b683f3f : SUCCESS in 2m 54s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/fce2cd06e8d1434dac29f75e830ba322 : SUCCESS in 5m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7412794a9a2b414e9bd73c552ed29c24 : SUCCESS in 6m 30s\n- openstack-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/931c777b59034e73a170ddedd4e3fb33 : SUCCESS in 8m 28s\n- openstack-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/b3f9662aaed1439ab05ca83805fb184b : SUCCESS in 10m 47s\n- glance-secure-rbac-protection-functional https://zuul.opendev.org/t/openstack/build/b4653f2096824f94908f553d92b5eead : SUCCESS in 24m 22s","accounts_in_message":[],"_revision_number":1},{"id":"a56d28e1aef8bd4a0ca601b289d6f3c68cb4efbe","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-10-08 09:12:11.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"8bd396d952f4016d3b23e155c58c937d1a9f2118","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-10-08 09:13:18.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c0319e51450a42e4bf3ed4ec98e74e6f\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5be9e588928645d38aa799abc80277f2 : SUCCESS in 53s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1678d92a5e094891d06d554338c3901fa4361298","revisions":{"1678d92a5e094891d06d554338c3901fa4361298":{"kind":"REWORK","_number":1,"created":"2025-09-27 16:10:12.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/45/962445/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/45/962445/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/45/962445/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/45/962445/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/45/962445/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/45/962445/1"}}},"commit":{"parents":[{"commit":"bcfd2cac74618f9cf115963488e80cd6d576a5b2","subject":"Merge \"Remove the last reference to OsloDBDeprecationWarning\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/bcfd2cac74618f9cf115963488e80cd6d576a5b2"}]}],"author":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2025-09-27 15:49:20.000000000","tz":0},"committer":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2025-09-27 15:49:20.000000000","tz":0},"subject":"Remove legacy update tests","message":"Remove legacy update tests\n\nThese tests were introduced in Feb, 2021[1] to test upgrade\npath from single store to multistore for glance cinder backend.\nOvertime there have been a series of updates[2][3][4][5][6][7][8]\nto keep the tests compatible with updates done in the glance cinder\nstore, last one being done in Jan, 2023.\nOvetime, we have been enforcing deployments to use multi stores\ninstead of single store and hence we can assume that most, if\nnot all, deployments have moved to multi stores given the\n5 year time period.\nA lot of the methods are mocked in the functional tests, even\ninternal ones, causing failures when updating internal\nmethods in the glance cinder store.\nRecent example of such a failure is visible on change[9].\n\nTypeError: TestLegacyUpdateCinderStore._mock_wait_volume_status() takes 4 positional arguments but 5 were given\n\nOverall, the effort required to keep these tests up to date outweighs the\ncoverage they provide, hence it\u0027s logical to remove them and ease developer\nefforts while making changes in glance cinder backend.\n\n[1] https://github.com/openstack/glance/commit/09b924c9bcdfd4d750f285f60cfd02f5504908fb\n[2] https://github.com/openstack/glance/commit/09b924c9bcdfd4d750f285f60cfd02f5504908fb\n[3] https://github.com/openstack/glance/commit/0e2043d51ebe90acd0e6f284774c5411cb1c886b\n[4] https://github.com/openstack/glance/commit/01b5bf5ece9a6904c1c5df4ad557967c927b8683\n[5] https://github.com/openstack/glance/commit/de8c8502694f1156e2a4240efb44d5c19e04a486\n[6] https://github.com/openstack/glance/commit/acc6f624cdb1b2e4a3900e7d226bbc5156e8fa17\n[7] https://github.com/openstack/glance/commit/f40ac40c2c40d57637312959b680121a9c89949a\n[8] https://github.com/openstack/glance/commit/0e70f66165f47f0f5890d8774a566014a23d9dea\n[9] https://review.opendev.org/c/openstack/glance_store/+/962398\n\nChange-Id: I4d24fc267c093e4b8845973b739cd22e686b2312\nSigned-off-by: Rajat Dhasmana \u003crajatdhasmana@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/1678d92a5e094891d06d554338c3901fa4361298"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/1678d92a5e094891d06d554338c3901fa4361298"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}