)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d68a3b35fbdc7d1bfe202b49f94c445544ce64e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e63f739_c269535c","updated":"2025-10-14 14:29:21.000000000","message":"For reference, here\u0027s the nova ISO+GPT support that merged earlier this year: https://review.opendev.org/c/openstack/nova/+/931833\n\nThis test passes with the iso-bootable-as-block on upload:\n```\ntest_accept_usable_formats[id-a245fcbe-63ce-4dc1-a1d0-c16d76d9e6df](iso-bootable-as-block)\npass\n```\nand logs the proper thing showing the override:\n```\nOct 13 16:51:31.421037 np0dc6f6ef15be4 devstack@g-api.service[88140]: DEBUG glance.location [None req-7895856e-dc19-490e-a25e-57e15e2f2d8b tempest-ImagesFormatTest-962935109 tempest-ImagesFormatTest-962935109-project-member] Detected format as ISO+GPT, allowing as ISO {{(pid\u003d88140) set_data /opt/stack/glance/glance/location.py:613}}\n```\nIt fails the import because this patch doesn\u0027t handle iso+gpt on import (as noted in the commit message). I\u0027m honestly not sure how I want to fix import yet, so I propose we use this run as proof that it\u0027s working and drop the depends-on to the os-test-images that adds the bootable ISO image so we can merge.\n\nThoughts?","commit_id":"70bdb6842f43f716ba6d4029abf3c91d2e9ae1c7"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e84f2bed904ee5b39cde2addf5169dce39ed0fee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ec4ae033_d626ee99","in_reply_to":"5e63f739_c269535c","updated":"2025-10-14 19:01:58.000000000","message":"+1 I think we can drop depends-on and we can merge this.","commit_id":"70bdb6842f43f716ba6d4029abf3c91d2e9ae1c7"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"078eb3c89e004aaa98e2bfacaa48a1fc2fe14d9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5bb87600_2882f23b","updated":"2025-10-22 06:58:59.000000000","message":"thank you, looks good to me!","commit_id":"28d98401b965716b53f719d354f0ecbf5583601c"}],"glance/tests/unit/test_store_image.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"ac575bffddea04a272aa208f3eb81e3ee6b7dd0b","unresolved":true,"context_lines":[{"line_number":420,"context_line":"        mock_result.formats \u003d []"},{"line_number":421,"context_line":"        for format in formats:"},{"line_number":422,"context_line":"            inspector \u003d mock.MagicMock()"},{"line_number":423,"context_line":"            inspector.__str__.return_value \u003d \u0027iso\u0027"},{"line_number":424,"context_line":"            mock_result.formats.append(inspector)"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        if fail_multiple:"}],"source_content_type":"text/x-python","patch_set":1,"id":"83ef4576_fe673562","line":423,"range":{"start_line":423,"start_character":49,"end_line":423,"end_character":50},"updated":"2025-10-16 01:47:54.000000000","message":"Was this supposed to be \"\u003d format\"? On my machine this works with both \"\u003d \u0027iso\u0027\" and \"\u003d format\". Somehow the tests still pass if I remove this line altogether.","commit_id":"70bdb6842f43f716ba6d4029abf3c91d2e9ae1c7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d396acb02ac976186a8d9d2f5fca1a9647eaf7b9","unresolved":true,"context_lines":[{"line_number":420,"context_line":"        mock_result.formats \u003d []"},{"line_number":421,"context_line":"        for format in formats:"},{"line_number":422,"context_line":"            inspector \u003d mock.MagicMock()"},{"line_number":423,"context_line":"            inspector.__str__.return_value \u003d \u0027iso\u0027"},{"line_number":424,"context_line":"            mock_result.formats.append(inspector)"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        if fail_multiple:"}],"source_content_type":"text/x-python","patch_set":1,"id":"a2f7595f_d32e5a8e","line":423,"range":{"start_line":423,"start_character":49,"end_line":423,"end_character":50},"in_reply_to":"83ef4576_fe673562","updated":"2025-10-16 14:05:43.000000000","message":"oh yep.. and I think it still works because we\u0027re failing on the mere presence of two, and if it\u0027s \u003dformat it\u0027s the right one. But will fix, thanks.","commit_id":"70bdb6842f43f716ba6d4029abf3c91d2e9ae1c7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f3dbce0119ba6a3554e7f281afa3e429baeeb788","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        mock_result.formats \u003d []"},{"line_number":421,"context_line":"        for format in formats:"},{"line_number":422,"context_line":"            inspector \u003d mock.MagicMock()"},{"line_number":423,"context_line":"            inspector.__str__.return_value \u003d \u0027iso\u0027"},{"line_number":424,"context_line":"            mock_result.formats.append(inspector)"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        if fail_multiple:"}],"source_content_type":"text/x-python","patch_set":1,"id":"36455086_a70348b7","line":423,"range":{"start_line":423,"start_character":49,"end_line":423,"end_character":50},"in_reply_to":"a2f7595f_d32e5a8e","updated":"2025-10-16 14:31:55.000000000","message":"Done","commit_id":"70bdb6842f43f716ba6d4029abf3c91d2e9ae1c7"}]}