)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"5ac3b49d590f4438504060a6c59bf04b7b606639","unresolved":true,"context_lines":[{"line_number":14,"context_line":"created."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1916052"},{"line_number":17,"context_line":"Depends-on: https://review.opendev.org/c/openstack/keystone/+/929736"},{"line_number":18,"context_line":"Change-Id: Id314d6db168c2eed2e6f2c21728af5c069d59873"},{"line_number":19,"context_line":"Signed-off-by: Arnaud Morin \u003carnaud.morin@ovhcloud.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"cdac7dc5_2084f2f1","line":17,"range":{"start_line":17,"start_character":62,"end_line":17,"end_character":68},"updated":"2026-06-25 15:51:49.000000000","message":"I don\u0027t see the link between this patch and this Depends-On.","commit_id":"5c4157dc4b0b62efdcc8d2c841932880e6777861"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"5c0047c0479a9d74e81f6fbc4dbcac5ded551af8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"created."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1916052"},{"line_number":17,"context_line":"Depends-on: https://review.opendev.org/c/openstack/keystone/+/929736"},{"line_number":18,"context_line":"Change-Id: Id314d6db168c2eed2e6f2c21728af5c069d59873"},{"line_number":19,"context_line":"Signed-off-by: Arnaud Morin \u003carnaud.morin@ovhcloud.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e0a82ec6_fe03e011","line":17,"range":{"start_line":17,"start_character":62,"end_line":17,"end_character":68},"in_reply_to":"cdac7dc5_2084f2f1","updated":"2026-07-16 15:59:14.000000000","message":"Agree, I will remove the depends on.\nActually, this was related because with this glance fix, glance creates a trust on keystone for each image upload.\nWe upload a LOT of images on our side (mostly instance backups), which resulted in the creation of a lot of trusts, then filling the revocation table on keystone side.\n\nThat\u0027s not strictly related, so I will remove this link for now","commit_id":"5c4157dc4b0b62efdcc8d2c841932880e6777861"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"051e1e821f196427d66a83b67f1891c8988db949","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a706ed79_6d5fda84","updated":"2025-11-24 08:26:07.000000000","message":"Note that this could have a significant impact on keystone, since trust are going to actually work and beeing created.\nDepending on the number of glance images you are creating, you may want to have a correct index in revocation event table on keystone side first.\n\nSee: https://bugs.launchpad.net/keystone/+bug/2081082","commit_id":"78f713c35e8bd04fed8f8710c8e60c9d172c0a01"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"7ae78cd27a3488f732093dd2b15ee9c50e414b9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4983b13e_ae52e5f0","updated":"2025-11-24 13:48:51.000000000","message":"recheck glance-multistore-cinder-import","commit_id":"87be6babf358d4c59ea4f018f098a7bd132f61a1"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"5ac3b49d590f4438504060a6c59bf04b7b606639","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c545760a_95fd6712","updated":"2026-06-25 15:51:49.000000000","message":"I think we might want to get someone from Keystone to help with the API, here.","commit_id":"5c4157dc4b0b62efdcc8d2c841932880e6777861"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"6b8cfa351cd553375ca17bff6906e0bfa709298f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ce49e40c_b94b9c73","updated":"2026-04-09 07:51:51.000000000","message":"hey, can we move this forward?","commit_id":"5c4157dc4b0b62efdcc8d2c841932880e6777861"}],"glance/common/trust_auth.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"5ac3b49d590f4438504060a6c59bf04b7b606639","unresolved":true,"context_lines":[{"line_number":21,"context_line":"CONF \u003d cfg.CONF"},{"line_number":22,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027timeout\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":23,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027collect_timing\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":24,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027split_loggers\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"27aec44b_818e1afa","line":24,"range":{"start_line":24,"start_character":54,"end_line":24,"end_character":72},"updated":"2026-06-25 15:51:49.000000000","message":"I see:\n\n    keystoneauth1/loading/session.py:                cfg.BoolOpt(\u0027collect-timing\u0027,\n    keystoneauth1/loading/session.py:                cfg.BoolOpt(\u0027split-loggers\u0027,\n\nSo I\u0027m not sure why these are IntOpt here. I also wonder if it matters that you s/-/_/. \n\nShouldn\u0027t we do something like:\n\n    ka_loading.register_session_conf_options(CONF, \u0027keystone_authtoken\u0027)\n\nOr:\n\n    ka_loading.register_auth_conf_options(CONF, \u0027keystone_authtoken\u0027)\n\nKind of like what they do in https://raw.githubusercontent.com/openstack/zaqar/refs/heads/master/zaqar/common/auth.py ?","commit_id":"5c4157dc4b0b62efdcc8d2c841932880e6777861"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"5c0047c0479a9d74e81f6fbc4dbcac5ded551af8","unresolved":true,"context_lines":[{"line_number":21,"context_line":"CONF \u003d cfg.CONF"},{"line_number":22,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027timeout\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":23,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027collect_timing\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":24,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027split_loggers\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"33e41eea_44cd693d","line":24,"range":{"start_line":24,"start_character":54,"end_line":24,"end_character":72},"in_reply_to":"27aec44b_818e1afa","updated":"2026-07-16 15:59:14.000000000","message":"Agree about the IntOpt to BoolOpt, will do that, that\u0027s my bad because I copy pasted the \"timeout\" option right above.\n\nAbout the - to _, I can switch to -, but I dont believe this will change anything as the oslo.config does the - to _ replacement. I used the _ directly because that was the original name of the option glance is complaining about.\n\nI am not sure that the registration of all options is going to work, that would raise some DuplicateOptError, but I will double check that before.","commit_id":"5c4157dc4b0b62efdcc8d2c841932880e6777861"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"4735fee17cec695a2034c12eac2d491df6b414f3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d cfg.CONF"},{"line_number":22,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027timeout\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":23,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027collect_timing\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":24,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027split_loggers\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7087a536_d1347db6","line":24,"range":{"start_line":24,"start_character":54,"end_line":24,"end_character":72},"in_reply_to":"33e41eea_44cd693d","updated":"2026-07-17 15:09:48.000000000","message":"I choose a different path by getting the real options that are available from get_session_conf_options.\n\nI admit that this looks like a hack and may need to be refactored on keystonemiddleware part. But that sounds much bigger and error prone.\nI suggest we go that way first to solve the glance issue right now and identify the refactoring on keystone side in another pace.","commit_id":"5c4157dc4b0b62efdcc8d2c841932880e6777861"}]}