)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"5ac3b49d590f4438504060a6c59bf04b7b606639","unresolved":true,"context_lines":[{"line_number":14,"context_line":"created."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1916052"},{"line_number":17,"context_line":"Depends-on: https://review.opendev.org/c/openstack/keystone/+/929736"},{"line_number":18,"context_line":"Change-Id: Id314d6db168c2eed2e6f2c21728af5c069d59873"},{"line_number":19,"context_line":"Signed-off-by: Arnaud Morin \u003carnaud.morin@ovhcloud.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"cdac7dc5_2084f2f1","line":17,"range":{"start_line":17,"start_character":62,"end_line":17,"end_character":68},"updated":"2026-06-25 15:51:49.000000000","message":"I don\u0027t see the link between this patch and this Depends-On.","commit_id":"5c4157dc4b0b62efdcc8d2c841932880e6777861"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"5c0047c0479a9d74e81f6fbc4dbcac5ded551af8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"created."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1916052"},{"line_number":17,"context_line":"Depends-on: https://review.opendev.org/c/openstack/keystone/+/929736"},{"line_number":18,"context_line":"Change-Id: Id314d6db168c2eed2e6f2c21728af5c069d59873"},{"line_number":19,"context_line":"Signed-off-by: Arnaud Morin \u003carnaud.morin@ovhcloud.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e0a82ec6_fe03e011","line":17,"range":{"start_line":17,"start_character":62,"end_line":17,"end_character":68},"in_reply_to":"cdac7dc5_2084f2f1","updated":"2026-07-16 15:59:14.000000000","message":"Agree, I will remove the depends on.\nActually, this was related because with this glance fix, glance creates a trust on keystone for each image upload.\nWe upload a LOT of images on our side (mostly instance backups), which resulted in the creation of a lot of trusts, then filling the revocation table on keystone side.\n\nThat\u0027s not strictly related, so I will remove this link for now","commit_id":"5c4157dc4b0b62efdcc8d2c841932880e6777861"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"051e1e821f196427d66a83b67f1891c8988db949","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a706ed79_6d5fda84","updated":"2025-11-24 08:26:07.000000000","message":"Note that this could have a significant impact on keystone, since trust are going to actually work and beeing created.\nDepending on the number of glance images you are creating, you may want to have a correct index in revocation event table on keystone side first.\n\nSee: https://bugs.launchpad.net/keystone/+bug/2081082","commit_id":"78f713c35e8bd04fed8f8710c8e60c9d172c0a01"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"7ae78cd27a3488f732093dd2b15ee9c50e414b9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4983b13e_ae52e5f0","updated":"2025-11-24 13:48:51.000000000","message":"recheck glance-multistore-cinder-import","commit_id":"87be6babf358d4c59ea4f018f098a7bd132f61a1"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"5ac3b49d590f4438504060a6c59bf04b7b606639","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c545760a_95fd6712","updated":"2026-06-25 15:51:49.000000000","message":"I think we might want to get someone from Keystone to help with the API, here.","commit_id":"5c4157dc4b0b62efdcc8d2c841932880e6777861"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"6b8cfa351cd553375ca17bff6906e0bfa709298f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ce49e40c_b94b9c73","updated":"2026-04-09 07:51:51.000000000","message":"hey, can we move this forward?","commit_id":"5c4157dc4b0b62efdcc8d2c841932880e6777861"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f6b5f09260bb82cef56b000085be21b214c35ea1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"451450d8_9a90ec8d","updated":"2026-09-10 07:23:44.000000000","message":"Glance does have sample config generator in etc/oslo-config-generator. Have you tried generating sample config and confirmed that these options are also listed in sample config files? If not then you need to do specific changes to etc/oslo-config-generator as well.","commit_id":"45745a02b764bc09b9ad8b4f685120324ca347c9"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"6d44c202f3af6df3ee410d56099cf5dd232786ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ebf76761_e9757f9d","in_reply_to":"451450d8_9a90ec8d","updated":"2026-09-10 08:29:56.000000000","message":"good point, will do","commit_id":"45745a02b764bc09b9ad8b4f685120324ca347c9"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"7e4761843d9b132ce8166f11be19fb731f7f69d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2ffce91f_c4cf6573","in_reply_to":"ebf76761_e9757f9d","updated":"2026-09-10 09:44:22.000000000","message":"done, they import now and are visible in both config samples and doc.\nThank you for the review","commit_id":"45745a02b764bc09b9ad8b4f685120324ca347c9"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"6d44c202f3af6df3ee410d56099cf5dd232786ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"05e69a3d_a07ba7b3","updated":"2026-09-10 08:29:56.000000000","message":"I added a reproducer in previous commit.\nNow the issue is clearly reproduced and the patch show that the fix is ok now.\nThis would also allow us to eventually see any regression later.","commit_id":"f77bd54740946a5f698493de733012a038695295"},{"author":{"_account_id":37800,"name":"Sebastian Krott","display_name":"Sebastian Krott","email":"sebastian.krott@sap.com","username":"sebkro_sap"},"change_message_id":"d3cfa6380ccf103a9cc3ec4352f262a4f8811c18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8c850afa_958ad736","updated":"2026-09-10 13:22:42.000000000","message":"Just some thoughts","commit_id":"f4120cc6168b182e4ecc788cdb56145a6ab90f64"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"22591c8fb197e716affba2ec0517fe9e635d3485","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"77548b39_444c32a4","updated":"2026-09-10 11:43:06.000000000","message":"Looks good!!","commit_id":"f4120cc6168b182e4ecc788cdb56145a6ab90f64"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9e847461c6f36442eb5d08911c97391de5613f7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"96ba8738_c7e2de75","updated":"2026-09-10 11:54:24.000000000","message":"nee changes in test_opts.py","commit_id":"f4120cc6168b182e4ecc788cdb56145a6ab90f64"}],"glance/common/trust_auth.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"5ac3b49d590f4438504060a6c59bf04b7b606639","unresolved":true,"context_lines":[{"line_number":21,"context_line":"CONF \u003d cfg.CONF"},{"line_number":22,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027timeout\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":23,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027collect_timing\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":24,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027split_loggers\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"27aec44b_818e1afa","line":24,"range":{"start_line":24,"start_character":54,"end_line":24,"end_character":72},"updated":"2026-06-25 15:51:49.000000000","message":"I see:\n\n    keystoneauth1/loading/session.py:                cfg.BoolOpt(\u0027collect-timing\u0027,\n    keystoneauth1/loading/session.py:                cfg.BoolOpt(\u0027split-loggers\u0027,\n\nSo I\u0027m not sure why these are IntOpt here. I also wonder if it matters that you s/-/_/. \n\nShouldn\u0027t we do something like:\n\n    ka_loading.register_session_conf_options(CONF, \u0027keystone_authtoken\u0027)\n\nOr:\n\n    ka_loading.register_auth_conf_options(CONF, \u0027keystone_authtoken\u0027)\n\nKind of like what they do in https://raw.githubusercontent.com/openstack/zaqar/refs/heads/master/zaqar/common/auth.py ?","commit_id":"5c4157dc4b0b62efdcc8d2c841932880e6777861"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"5c0047c0479a9d74e81f6fbc4dbcac5ded551af8","unresolved":true,"context_lines":[{"line_number":21,"context_line":"CONF \u003d cfg.CONF"},{"line_number":22,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027timeout\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":23,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027collect_timing\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":24,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027split_loggers\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"33e41eea_44cd693d","line":24,"range":{"start_line":24,"start_character":54,"end_line":24,"end_character":72},"in_reply_to":"27aec44b_818e1afa","updated":"2026-07-16 15:59:14.000000000","message":"Agree about the IntOpt to BoolOpt, will do that, that\u0027s my bad because I copy pasted the \"timeout\" option right above.\n\nAbout the - to _, I can switch to -, but I dont believe this will change anything as the oslo.config does the - to _ replacement. I used the _ directly because that was the original name of the option glance is complaining about.\n\nI am not sure that the registration of all options is going to work, that would raise some DuplicateOptError, but I will double check that before.","commit_id":"5c4157dc4b0b62efdcc8d2c841932880e6777861"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"4735fee17cec695a2034c12eac2d491df6b414f3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d cfg.CONF"},{"line_number":22,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027timeout\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":23,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027collect_timing\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":24,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027split_loggers\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7087a536_d1347db6","line":24,"range":{"start_line":24,"start_character":54,"end_line":24,"end_character":72},"in_reply_to":"33e41eea_44cd693d","updated":"2026-07-17 15:09:48.000000000","message":"I choose a different path by getting the real options that are available from get_session_conf_options.\n\nI admit that this looks like a hack and may need to be refactored on keystonemiddleware part. But that sounds much bigger and error prone.\nI suggest we go that way first to solve the glance issue right now and identify the refactoring on keystone side in another pace.","commit_id":"5c4157dc4b0b62efdcc8d2c841932880e6777861"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"548eb0ca4467689f6f29b731fb8a676aa3d77877","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d cfg.CONF"},{"line_number":22,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027timeout\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":23,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027collect_timing\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":24,"context_line":"CONF.register_opt(cfg.IntOpt(\u0027split_loggers\u0027), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"24ee1191_011a25c9","line":24,"range":{"start_line":24,"start_character":54,"end_line":24,"end_character":72},"in_reply_to":"7087a536_d1347db6","updated":"2026-09-10 07:03:57.000000000","message":"Can we move this forward?\nThis is a real issue in production today","commit_id":"5c4157dc4b0b62efdcc8d2c841932880e6777861"},{"author":{"_account_id":37800,"name":"Sebastian Krott","display_name":"Sebastian Krott","email":"sebastian.krott@sap.com","username":"sebkro_sap"},"change_message_id":"d3cfa6380ccf103a9cc3ec4352f262a4f8811c18","unresolved":true,"context_lines":[{"line_number":30,"context_line":"             for o in opts}"},{"line_number":31,"context_line":"session_opts \u003d [o for o in ka_loading.get_session_conf_options()"},{"line_number":32,"context_line":"                if o.dest not in _ksm_opts]"},{"line_number":33,"context_line":"CONF.register_opts(session_opts, group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"16bac750_75584bc6","line":33,"updated":"2026-09-10 13:22:42.000000000","message":"This seems to rely on implementation details of keystonemiddleware by assuming that keystonemiddleware will register `list_auth_token_opts` and will not register any other session options. Not sure that\u0027s ideal?","commit_id":"f4120cc6168b182e4ecc788cdb56145a6ab90f64"},{"author":{"_account_id":37800,"name":"Sebastian Krott","display_name":"Sebastian Krott","email":"sebastian.krott@sap.com","username":"sebkro_sap"},"change_message_id":"5ca5410a679870634cb5ddb02aa50a64a0ba5b72","unresolved":true,"context_lines":[{"line_number":30,"context_line":"             for o in opts}"},{"line_number":31,"context_line":"session_opts \u003d [o for o in ka_loading.get_session_conf_options()"},{"line_number":32,"context_line":"                if o.dest not in _ksm_opts]"},{"line_number":33,"context_line":"CONF.register_opts(session_opts, group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3003452a_46992524","line":33,"in_reply_to":"16bac750_75584bc6","updated":"2026-09-10 14:14:54.000000000","message":"This could be an alternative fix: https://review.opendev.org/c/openstack/glance/+/1005016","commit_id":"f4120cc6168b182e4ecc788cdb56145a6ab90f64"},{"author":{"_account_id":37800,"name":"Sebastian Krott","display_name":"Sebastian Krott","email":"sebastian.krott@sap.com","username":"sebkro_sap"},"change_message_id":"b5b5d0aba9ee204a261149aa9795b65dcaf01b02","unresolved":false,"context_lines":[{"line_number":30,"context_line":"             for o in opts}"},{"line_number":31,"context_line":"session_opts \u003d [o for o in ka_loading.get_session_conf_options()"},{"line_number":32,"context_line":"                if o.dest not in _ksm_opts]"},{"line_number":33,"context_line":"CONF.register_opts(session_opts, group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"95732326_1b1e678d","line":33,"in_reply_to":"181b1619_a8850347","updated":"2026-09-10 22:13:41.000000000","message":"Good point, I rebased it.","commit_id":"f4120cc6168b182e4ecc788cdb56145a6ab90f64"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"036ee0966980478b642a7a0e3338fce265261c6e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"             for o in opts}"},{"line_number":31,"context_line":"session_opts \u003d [o for o in ka_loading.get_session_conf_options()"},{"line_number":32,"context_line":"                if o.dest not in _ksm_opts]"},{"line_number":33,"context_line":"CONF.register_opts(session_opts, group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"181b1619_a8850347","line":33,"in_reply_to":"3003452a_46992524","updated":"2026-09-10 15:53:26.000000000","message":"ack, no strong opinion on this, either works for me.\nMaybe you can rebase on top of my reproducer at least, to make sure the result is tested and works the same in your change?","commit_id":"f4120cc6168b182e4ecc788cdb56145a6ab90f64"}],"glance/opts.py":[{"author":{"_account_id":37800,"name":"Sebastian Krott","display_name":"Sebastian Krott","email":"sebastian.krott@sap.com","username":"sebkro_sap"},"change_message_id":"d3cfa6380ccf103a9cc3ec4352f262a4f8811c18","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        glance.async_.taskflow_executor.taskflow_executor_opts,"},{"line_number":59,"context_line":"        glance.async_.flows.convert.convert_task_opts))),"},{"line_number":60,"context_line":"    profiler.list_opts()[0],"},{"line_number":61,"context_line":"    (\u0027keystone_authtoken\u0027, glance.common.trust_auth.session_opts),"},{"line_number":62,"context_line":"    (\u0027paste_deploy\u0027, glance.common.config.paste_deploy_opts),"},{"line_number":63,"context_line":"    (\u0027wsgi\u0027, glance.common.config.wsgi_opts),"},{"line_number":64,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"2c7d5936_77ff6a78","line":61,"updated":"2026-09-10 13:22:42.000000000","message":"AFAIK the `keystone_authtoken` option group is actually dedicated to keystonemiddleware. Glance is reusing it, but not sure if it is recommendable to officially document the usage for glance operators?","commit_id":"f4120cc6168b182e4ecc788cdb56145a6ab90f64"},{"author":{"_account_id":37800,"name":"Sebastian Krott","display_name":"Sebastian Krott","email":"sebastian.krott@sap.com","username":"sebkro_sap"},"change_message_id":"b5b5d0aba9ee204a261149aa9795b65dcaf01b02","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        glance.async_.taskflow_executor.taskflow_executor_opts,"},{"line_number":59,"context_line":"        glance.async_.flows.convert.convert_task_opts))),"},{"line_number":60,"context_line":"    profiler.list_opts()[0],"},{"line_number":61,"context_line":"    (\u0027keystone_authtoken\u0027, glance.common.trust_auth.session_opts),"},{"line_number":62,"context_line":"    (\u0027paste_deploy\u0027, glance.common.config.paste_deploy_opts),"},{"line_number":63,"context_line":"    (\u0027wsgi\u0027, glance.common.config.wsgi_opts),"},{"line_number":64,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"db2a8e90_950b986f","line":61,"in_reply_to":"219e7ac2_a1d8462c","updated":"2026-09-10 22:13:41.000000000","message":"Yes, it is helpful to know. But IMO the bigger picture here is that glance uses config options it doesn\u0027t really own because the namespace (config group) belongs to keystonemiddleware. And documenting those options effectively makes them official. Which seems confusing and if keystonemiddleware ever starts claiming them perhaps even problematic.\n\nAlso, if documenting the options, isn\u0027t all of `ka_loading.get_session_conf_options()` instead of just the additional `glance.common.trust_auth.session_opts` actually more adequate? All of them are in use, they are just not registered by glance itself.\n\nMaybe the cleaner long term option is introducing a dedicated service user and `[service_user]` config group like e.g. [nova\u0027s config](https://docs.openstack.org/nova/latest/configuration/sample-config.html)? But that\u0027s beyond the scope of this fix.\n\nEither way, doesn\u0027t matter much for me personally, just wanted to raise the concern.","commit_id":"f4120cc6168b182e4ecc788cdb56145a6ab90f64"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"036ee0966980478b642a7a0e3338fce265261c6e","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        glance.async_.taskflow_executor.taskflow_executor_opts,"},{"line_number":59,"context_line":"        glance.async_.flows.convert.convert_task_opts))),"},{"line_number":60,"context_line":"    profiler.list_opts()[0],"},{"line_number":61,"context_line":"    (\u0027keystone_authtoken\u0027, glance.common.trust_auth.session_opts),"},{"line_number":62,"context_line":"    (\u0027paste_deploy\u0027, glance.common.config.paste_deploy_opts),"},{"line_number":63,"context_line":"    (\u0027wsgi\u0027, glance.common.config.wsgi_opts),"},{"line_number":64,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"219e7ac2_a1d8462c","line":61,"in_reply_to":"2c7d5936_77ff6a78","updated":"2026-09-10 15:53:26.000000000","message":"Agree, but as an operator, I like to see such kind of options without having to dig in code about it. E.G. the timeout option","commit_id":"f4120cc6168b182e4ecc788cdb56145a6ab90f64"},{"author":{"_account_id":37800,"name":"Sebastian Krott","display_name":"Sebastian Krott","email":"sebastian.krott@sap.com","username":"sebkro_sap"},"change_message_id":"fa904a5dee079dbabef4d5b79b2d2aa139ec08e5","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        glance.async_.taskflow_executor.taskflow_executor_opts,"},{"line_number":59,"context_line":"        glance.async_.flows.convert.convert_task_opts))),"},{"line_number":60,"context_line":"    profiler.list_opts()[0],"},{"line_number":61,"context_line":"    (\u0027keystone_authtoken\u0027, glance.common.trust_auth.session_opts),"},{"line_number":62,"context_line":"    (\u0027paste_deploy\u0027, glance.common.config.paste_deploy_opts),"},{"line_number":63,"context_line":"    (\u0027wsgi\u0027, glance.common.config.wsgi_opts),"},{"line_number":64,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"85e8e722_050ff3d6","line":61,"in_reply_to":"db2a8e90_950b986f","updated":"2026-09-10 22:20:30.000000000","message":"Oh, my bad, it\u0027s getting late. I guess the other session options are already listed anyways, so adding just the additional ones would make sense. Doesn\u0027t change the larger point though.","commit_id":"f4120cc6168b182e4ecc788cdb56145a6ab90f64"}],"glance/tests/functional/v2/test_images_token_expiry.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1f76a5e045588381459c351ef3638da49e50ef76","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def setUp(self):"},{"line_number":49,"context_line":"        super(TestImageUploadTokenExpiry, self).setUp()"},{"line_number":50,"context_line":"        "},{"line_number":51,"context_line":"        # Fake keystone context"},{"line_number":52,"context_line":"        CONF.register_opts(ka_loading.get_auth_plugin_conf_options(\u0027password\u0027),"},{"line_number":53,"context_line":"                           group\u003d\u0027keystone_authtoken\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"88b54beb_92c61d7a","line":50,"updated":"2026-09-10 11:46:42.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"f4120cc6168b182e4ecc788cdb56145a6ab90f64"}]}
