)]}'
{"glance/common/auth.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7437ccab7f7f5fb4268a0f7ba4a665724ccd5d64","unresolved":true,"context_lines":[{"line_number":325,"context_line":"    only one -- successful match in the catalog,"},{"line_number":326,"context_line":"    otherwise we will raise an exception."},{"line_number":327,"context_line":"    \"\"\""},{"line_number":328,"context_line":"    endpoints \u003d keystone_sc.ServiceCatalogV2(service_catalog).get_urls("},{"line_number":329,"context_line":"        service_type\u003dservice_type,"},{"line_number":330,"context_line":"        region_name\u003dendpoint_region,"},{"line_number":331,"context_line":"        interface\u003dendpoint_type)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ecbdba8_eef87ea1","line":328,"updated":"2026-01-13 15:38:07.000000000","message":"I assume the reason there\u0027s no unit test change here is because this is functionally identical to the previous thing so that tempest, etc runs as it did before. Right?\n\nDo all the unit tests mock out at the `get_endpoint()` layer so that this code change is not really run, or are they mocking something below this that means we\u0027re still using this? I just hate merging any functional code without a test to validate that the new behavior is actually working (and/or proving that we do the new thing and not the old thing).","commit_id":"638c769059369233f1c9f27a42585ae05223892b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ab1c36c85f36e8d439fe10f675e079ce51978831","unresolved":true,"context_lines":[{"line_number":325,"context_line":"    only one -- successful match in the catalog,"},{"line_number":326,"context_line":"    otherwise we will raise an exception."},{"line_number":327,"context_line":"    \"\"\""},{"line_number":328,"context_line":"    endpoints \u003d keystone_sc.ServiceCatalogV2(service_catalog).get_urls("},{"line_number":329,"context_line":"        service_type\u003dservice_type,"},{"line_number":330,"context_line":"        region_name\u003dendpoint_region,"},{"line_number":331,"context_line":"        interface\u003dendpoint_type)"}],"source_content_type":"text/x-python","patch_set":4,"id":"c6772006_2d104157","line":328,"in_reply_to":"05ff79f1_dbaed688","updated":"2026-01-13 15:50:56.000000000","message":"Ah okay so it stubs the service catalog and uses the new lib call to parse it.. that makes sense...\n\nUp to you on squashing, but if it makes sense that\u0027s cool.","commit_id":"638c769059369233f1c9f27a42585ae05223892b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"32796112e121ded54e5b2d5296308fc00b337b91","unresolved":true,"context_lines":[{"line_number":325,"context_line":"    only one -- successful match in the catalog,"},{"line_number":326,"context_line":"    otherwise we will raise an exception."},{"line_number":327,"context_line":"    \"\"\""},{"line_number":328,"context_line":"    endpoints \u003d keystone_sc.ServiceCatalogV2(service_catalog).get_urls("},{"line_number":329,"context_line":"        service_type\u003dservice_type,"},{"line_number":330,"context_line":"        region_name\u003dendpoint_region,"},{"line_number":331,"context_line":"        interface\u003dendpoint_type)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ab2ba975_062fbf37","line":328,"in_reply_to":"1ecbdba8_eef87ea1","updated":"2026-01-13 15:44:04.000000000","message":"https://github.com/openstack/glance/blob/master/glance/tests/unit/test_auth.py#L549\n\nTestEndpoints has good test coverage to validate behavior of this method, without patching any internal calls and it allows us to ensure that the behavior is not changed.","commit_id":"638c769059369233f1c9f27a42585ae05223892b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5500fa04d96cef6233787183fc1211f37c9121b6","unresolved":true,"context_lines":[{"line_number":325,"context_line":"    only one -- successful match in the catalog,"},{"line_number":326,"context_line":"    otherwise we will raise an exception."},{"line_number":327,"context_line":"    \"\"\""},{"line_number":328,"context_line":"    endpoints \u003d keystone_sc.ServiceCatalogV2(service_catalog).get_urls("},{"line_number":329,"context_line":"        service_type\u003dservice_type,"},{"line_number":330,"context_line":"        region_name\u003dendpoint_region,"},{"line_number":331,"context_line":"        interface\u003dendpoint_type)"}],"source_content_type":"text/x-python","patch_set":4,"id":"05ff79f1_dbaed688","line":328,"in_reply_to":"ab2ba975_062fbf37","updated":"2026-01-13 15:48:03.000000000","message":"Maybe we should attempt to do https://review.opendev.org/c/openstack/glance/+/973112/ directly instead of modifying get_endpoint for no use. Let me try if I can shuffle the chain.","commit_id":"638c769059369233f1c9f27a42585ae05223892b"}]}