)]}'
{"id":"openstack%2Fglance~981813","triplet_id":"openstack%2Fglance~master~Ic6f4b158459236fb17e61e1725813c74178fa6de","project":"openstack/glance","branch":"master","topic":"upstream-fix-set-acls-master","attention_set":{},"removed_from_attention_set":{"32624":{"account":{"_account_id":32624,"name":"Rajiv Mucheli","email":"rajiv.mucheli@gmail.com","username":"rajivmucheli"},"last_update":"2026-03-23 17:56:35.000000000","reason":"removed on reply"},"5314":{"account":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"last_update":"2026-03-23 18:42:41.000000000","reason":"Change was abandoned"},"9303":{"account":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"last_update":"2026-03-23 18:42:41.000000000","reason":"Change was abandoned"},"8122":{"account":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"last_update":"2026-03-23 18:42:41.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Ic6f4b158459236fb17e61e1725813c74178fa6de","subject":"Fix set_acls when store metadata is missing","status":"ABANDONED","created":"2026-03-23 17:41:50.000000000","updated":"2026-03-23 18:42:41.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f1e8b78acaedcbf3e13fb0ca1e43787adb0ddc1f","_number":981813,"virtual_id_number":981813,"owner":{"_account_id":32624,"name":"Rajiv Mucheli","email":"rajiv.mucheli@gmail.com","username":"rajivmucheli"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}],"REVIEWER":[{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-23 17:55:24.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"CC"},{"updated":"2026-03-23 17:55:24.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2026-03-23 17:55:24.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"state":"REVIEWER"},{"updated":"2026-03-23 17:55:24.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"}],"messages":[{"id":"601bfe0cdcbc17afda7733e2340f70e7bb01851b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32624,"name":"Rajiv Mucheli","email":"rajiv.mucheli@gmail.com","username":"rajivmucheli"},"date":"2026-03-23 17:41:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a134d07603f64a27b9a2ca3e2afaa2d2d911a79e","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2026-03-23 17:55:24.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"01fb1d43bad3fdca97918fa638d80e7c7ed517b7","author":{"_account_id":32624,"name":"Rajiv Mucheli","email":"rajiv.mucheli@gmail.com","username":"rajivmucheli"},"date":"2026-03-23 17:56:35.000000000","message":"Patch Set 1:\n\nLogs showing the issue:\n\n```\n2026-03-23 16:53:20,791 10 DEBUG glance.location [req-ff64c9f4-1d63-4922-9e8b-c2c8ecd32828 ...] Store None is not available on this node, skipping `_set_acls` call. _set_acls /var/lib/openstack/lib/python3.12/site-packages/glance/location.py:75\n\n2026-03-23 16:38:45,608 11 DEBUG glance.location [req-c6860a62-b350-4af3-be1e-5d764190d45f ...] Store None is not available on this node, skipping `_set_acls` call. _set_acls /var/lib/openstack/lib/python3.12/site-packages/glance/location.py:75\n```\n\nFull logs: https://paste.openstack.org/show/bio3nRxx7Ai4E6Gs8iv7/\n\nThis fix adds a fallback to derive the store from the URI when the store metadata is missing, ensuring Swift container ACLs are properly set when images are shared.","accounts_in_message":[],"_revision_number":1},{"id":"f1e8b78acaedcbf3e13fb0ca1e43787adb0ddc1f","tag":"autogenerated:gerrit:abandon","author":{"_account_id":32624,"name":"Rajiv Mucheli","email":"rajiv.mucheli@gmail.com","username":"rajivmucheli"},"date":"2026-03-23 18:42:41.000000000","message":"Abandoned\n\nSuperseded by https://review.opendev.org/c/openstack/glance/+/981823 which includes the SHA1 of the faulty commit and detailed reproducer steps.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2d4b298f21abd96ac5c8779490a6df2a7cde10a9","revisions":{"2d4b298f21abd96ac5c8779490a6df2a7cde10a9":{"kind":"REWORK","_number":1,"created":"2026-03-23 17:41:50.000000000","uploader":{"_account_id":32624,"name":"Rajiv Mucheli","email":"rajiv.mucheli@gmail.com","username":"rajivmucheli"},"ref":"refs/changes/13/981813/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/13/981813/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/13/981813/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/13/981813/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/13/981813/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/13/981813/1"}}},"commit":{"parents":[{"commit":"8c43caaefd8820e3e45b3c95b60bc6e1c668c55b","subject":"Fix SSRF vulnerabilities in image import API","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/8c43caaefd8820e3e45b3c95b60bc6e1c668c55b"}]}],"author":{"name":"rajivmucheli","email":"rajiv.mucheli@gmail.com","date":"2026-03-23 17:04:13.000000000","tz":330},"committer":{"name":"rajivmucheli","email":"rajiv.mucheli@gmail.com","date":"2026-03-23 17:41:23.000000000","tz":330},"subject":"Fix set_acls when store metadata is missing","message":"Fix set_acls when store metadata is missing\n\nWhen multi-store is enabled, the _set_acls() methods in ImageRepoProxy\nand ImageMemberRepoProxy require the \u0027store\u0027 key in location metadata.\nHowever, for images created before multi-store was enabled, or images\nthat haven\u0027t been retrieved via get() since multi-store was enabled,\nthis metadata may be missing (None).\n\nThis causes the ACL setting to be silently skipped with the log message:\n\u0027Store None is not available on this node, skipping _set_acls call.\u0027\n\nThis fix adds a fallback to derive the store identifier from the\nlocation URI using _get_store_id_from_uri() when the metadata is\nmissing, ensuring that Swift container ACLs are properly set when\nimages are shared.\n\nChange-Id: Ic6f4b158459236fb17e61e1725813c74178fa6de\nSigned-off-by: rajivmucheli \u003crajiv.mucheli@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/2d4b298f21abd96ac5c8779490a6df2a7cde10a9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/2d4b298f21abd96ac5c8779490a6df2a7cde10a9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}