)]}'
{"id":"openstack%2Fglance~987273","triplet_id":"openstack%2Fglance~master~I2446791470bac0f91cbb02ae0a6e948e44e6f481","project":"openstack/glance","branch":"master","attention_set":{},"removed_from_attention_set":{"4393":{"account":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"last_update":"2026-08-19 16:35:43.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2446791470bac0f91cbb02ae0a6e948e44e6f481","subject":"MBR safety check is non-fatal for non-disk-image formats","status":"MERGED","created":"2026-05-04 20:19:19.000000000","updated":"2026-08-19 16:38:04.000000000","submitted":"2026-08-19 16:35:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"987273","meta_rev_id":"8e7758f266b09f312dc5395791579b84ecfa5eb4","_number":987273,"virtual_id_number":987273,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-08-19 16:35:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":2,"date":"2026-08-19 13:48:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":2,"date":"2026-05-05 15:20:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":1,"date":"2026-08-19 13:48:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-04 20:32:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-05-04 22:50:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-05-05 15:20:48.000000000","updated_by":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"reviewer":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"state":"REVIEWER"},{"updated":"2026-08-19 13:48:43.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"}],"messages":[{"id":"ed669d972c6465e3cec44e4e0a2fb91192f3ef85","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2026-05-04 20:19:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"42ccd70709af5a8f42d7b542b4f7c8e4f6e887fa","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-04 20:32:42.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/75bffff084854dceb08f7f9b2a40340c\n\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/c9519891a9b343d1aa096d73e3cc7139 : SUCCESS in 7m 40s (non-voting)\n- openstack-tox-py313-arm64 https://zuul.opendev.org/t/openstack/build/8b718eb4a8734099848649f5d69be306 : SUCCESS in 5m 58s (non-voting)\n- openstack-tox-py314-arm64 https://zuul.opendev.org/t/openstack/build/e32cd92b21bb4882bc39f4cb7d0fdb21 : SUCCESS in 11m 40s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4d4017a56be804ea988e04fa10cd957c6a0fc148","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-04 22:50:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4937be844738478982b0d1987fb83e09\n\n- grenade https://zuul.opendev.org/t/openstack/build/b6f17a6297f04bb79ac9b0a3f47400b6 : SUCCESS in 33m 05s\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/71d885ea477b4c9bb65d0cd6e53726f5 : SUCCESS in 33m 13s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/5f6b8dadd58a47f49e1f4df470ce2d21 : SUCCESS in 1h 21m 34s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/9c01100ba52f49bab11db97bd1e275e8 : SUCCESS in 1h 02m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fa7217ff3b0e478485a0eb56631deeed : SUCCESS in 4m 38s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/2605956915914f49949a6bf54c7e58ee : SUCCESS in 5m 40s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/cdff077a13124a799a27ca511467fcca : SUCCESS in 5m 18s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/d12be050909c412f85d905c748346072 : SUCCESS in 7m 48s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f5e79a27c715480f97c0d988319fe52d : SUCCESS in 6m 05s\n- openstack-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/e0291c274e4d4f3da96c98a7268432c0 : SUCCESS in 7m 14s\n- openstack-tox-functional-py313 https://zuul.opendev.org/t/openstack/build/2d19d372958244ec9c3fb291a88d3c83 : SUCCESS in 4m 29s\n- glance-ceph-thin-provisioning https://zuul.opendev.org/t/openstack/build/d203d887229049819d535e0975e58dfd : SUCCESS in 1h 02m 42s (non-voting)\n- tempest-integrated-storage-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/07daa37d9d754f438dd3a2f6a53c7236 : SUCCESS in 2h 09m 42s\n- tempest-integrated-storage-import https://zuul.opendev.org/t/openstack/build/ec8b93bac211451a8b3e9065305b6594 : SUCCESS in 2h 10m 38s\n- glance-multistore-cinder-import https://zuul.opendev.org/t/openstack/build/22d17dc0c6884939b7767c8555db4dda : SUCCESS in 2h 25m 22s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/e6bf5ab3f50e4401868cc38a94c1e36f : SUCCESS in 1h 01m 43s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/252211cbbef448d09d7e3b2093ddb7ce : SUCCESS in 1h 44m 30s\n- glance-grenade-centralized-cache https://zuul.opendev.org/t/openstack/build/1d05ebf5711f4a719df39587465e06b9 : FAILURE in 16m 58s (non-voting)\n- glance-s3-multistore https://zuul.opendev.org/t/openstack/build/6027a9a6ca224a689767001eb3082abe : SUCCESS in 1h 49m 43s (non-voting)\n- glance-secure-rbac-protection-functional https://zuul.opendev.org/t/openstack/build/952e8a1c91b34642b0805f3ba8a12830 : SUCCESS in 35m 43s","accounts_in_message":[],"_revision_number":1},{"id":"6ad136fddc4ba694a74f630fba97f71f153197c4","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2026-05-05 15:20:48.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8e872824a5862b11c6f967f7a88af04be22374be","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2026-08-19 13:48:43.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"164966b8d6a230962bcef36ac5d0571516695a4e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-19 13:49:57.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"82803fe34d81ca540794c15a66208577000dffaf","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-19 16:35:43.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5df44f0a63a24342b1c5d813c1532fef\n\n- grenade https://zuul.opendev.org/t/openstack/build/b9431ea38c8049239585789b7329cd50 : SUCCESS in 55m 18s\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/09848228df984b1aacad35a3f2fd6389 : SUCCESS in 48m 09s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/9c82693971eb43e7b68e727eb1121474 : SUCCESS in 1h 21m 03s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/62b5f31a4e854479ba4617483b7f144b : SUCCESS in 38m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d510a29a72134095a3e3882bbced4095 : SUCCESS in 5m 00s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/fb8528caa0d0429cb4501e0a254ec6fc : SUCCESS in 5m 02s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/6415c2078a5f4c15bcb4360db9e50700 : SUCCESS in 4m 59s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/25f62717814b4fcfa1a5a582db9f1f9f : SUCCESS in 4m 14s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/79d6749825e742bba1e2f1eabe63920c : SUCCESS in 4m 15s\n- openstack-tox-functional-py311 https://zuul.opendev.org/t/openstack/build/9e0275413bc74079b45c3ad2e4c1563c : SUCCESS in 7m 14s\n- openstack-tox-functional-py313 https://zuul.opendev.org/t/openstack/build/2390e0d951a4438b9c7b5e0efc2f68cc : SUCCESS in 6m 33s\n- tempest-integrated-storage-import https://zuul.opendev.org/t/openstack/build/b07038eb325646739a169a34dc745c25 : SUCCESS in 1h 40m 47s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/2d39916f776740cf89af536e039097d4 : SUCCESS in 59m 48s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/359195bb043a460e9d0f7629213a06dd : SUCCESS in 1h 10m 43s\n- glance-secure-rbac-protection-functional https://zuul.opendev.org/t/openstack/build/bb557f844d1a4710a5a034af9997b099 : SUCCESS in 36m 47s","accounts_in_message":[],"_revision_number":1},{"id":"394a7f317e10a01b288dd31fcc5ce7f6aa700a6f","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-19 16:35:43.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"8e7758f266b09f312dc5395791579b84ecfa5eb4","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-19 16:38:04.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/57c5242e1f84461cb577183da1ef945d\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1ab9dbb695074539ab0db54aa5695afb : SUCCESS in 59s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5e5f081a9793394e17a823125346c739dbcfd271","revisions":{"5e5f081a9793394e17a823125346c739dbcfd271":{"kind":"REWORK","_number":1,"created":"2026-05-04 20:19:19.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/73/987273/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/73/987273/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/73/987273/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/73/987273/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/73/987273/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/73/987273/1"}}},"commit":{"parents":[{"commit":"ad10cfd88ea416ffeaea67daf21d03242f9befb5","subject":"Merge \"Remove default to relaxed MBR safety checks\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/ad10cfd88ea416ffeaea67daf21d03242f9befb5"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2026-05-01 20:23:01.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2026-05-01 22:52:15.000000000","tz":-420},"subject":"MBR safety check is non-fatal for non-disk-image formats","message":"MBR safety check is non-fatal for non-disk-image formats\n\nSome kernel images will have intentionally-invalid GPT headers if\nconfigured with EFI stubbing. These will get detected as invalid GPT\nimages (which they are) and rejected by the \u0027mbr\u0027 safety check. If\nthe image claims to be AKI or ARI, we\u0027ll not enforce this specific\nsafety check because we know it to be a false-positive and expected\nfor those image types. For GPT (and GPT-as-raw) that check is still\ncontrolled by the nonfatal check configuration.\n\nNote that ARI is included here because it seems plausible that such\na behavior could also be employed there (i.e. a ramdisk image that is\na GPT disk image, but intentionally not BIOS/EFI-bootable) even though\nI know of no specific reason to do that. An alternative here would be\nto remove ARI from this consideration until/unless someone comes up\nwith a good use-case to include it.\n\nChange-Id: I2446791470bac0f91cbb02ae0a6e948e44e6f481\nSigned-off-by: Dan Smith \u003cdansmith@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/5e5f081a9793394e17a823125346c739dbcfd271"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/5e5f081a9793394e17a823125346c739dbcfd271"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}