)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38762,"name":"Sahil Kumbhar","display_name":"sakumbha","email":"sakumbha@redhat.com","username":"sakumbha"},"change_message_id":"396bae0c52155aea51ba56182a491e5e2c173468","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1712bc31_02e33d72","updated":"2026-06-12 08:39:33.000000000","message":"If `s3_host` contains a trailing slash, \nfor e.g `https://10.0.110.175:8080/`, \nthis could result in an incorrect URL being constructed. \nAfter removing the scheme, the value becomes `10.0.110.175:8080/`, \nwhich would produce:\n\n`s3://access:secret@10.0.110.175:8080//bucket/key`\n\n- extra `/` before the bucket name. This would cause the generated URL different from the expected format and could trigger:\n\n`S3 URL mismatch for image \u003cimage-id\u003e, updating URL`\n\nWe could avoid this by applying `strip(\u0027/\u0027)` to `s3_host` before constructing the URL.","commit_id":"fdfba9d5602fd43f1baf658935883a770b393d78"},{"author":{"_account_id":38762,"name":"Sahil Kumbhar","display_name":"sakumbha","email":"sakumbha@redhat.com","username":"sakumbha"},"change_message_id":"9581f626c244375da5c0585e872b9734009e5e32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cfbfa569_53e5b6c4","updated":"2026-06-12 06:59:41.000000000","message":"Just a small suggestion. Instead of uploading a new change and abandoning the previous one each time, you can update the existing review by uploading a new patchset. You can amend the previous commit and push it again:\n\n`git commit --amend` #use this\n`git review`\n\nThis keeps the review history in a single change and makes it easier for \nreviewers to track updates.","commit_id":"fdfba9d5602fd43f1baf658935883a770b393d78"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"68bf82195c1f9743febc7a8025a8f50f06516063","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c4fb210c_ff52e7e3","updated":"2026-06-12 18:35:19.000000000","message":"Why? Is there an open bug that this patch fixes? Could you include a test?","commit_id":"551eb567786ac3dfc1004653296ba70ce1b50895"},{"author":{"_account_id":39201,"name":"do minh kien","display_name":"dominhkien","email":"minhkien.eb@gmail.com","username":"dominhkien"},"change_message_id":"23e1db75581c4adebb87ec5ed9ce72cce491285d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cf702c63_ca6ee6f3","updated":"2026-06-13 00:06:33.000000000","message":"Yes, this is link to the issue about it\nhttps://bugs.launchpad.net/glance/+bug/2156432","commit_id":"551eb567786ac3dfc1004653296ba70ce1b50895"},{"author":{"_account_id":39201,"name":"do minh kien","display_name":"dominhkien","email":"minhkien.eb@gmail.com","username":"dominhkien"},"change_message_id":"0a3f9c836192477506725f76caaba7be34d0f336","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e929dbf9_5840b9ef","in_reply_to":"c4fb210c_ff52e7e3","updated":"2026-06-16 07:00:19.000000000","message":"Yes, this is link to the issue about it\nhttps://bugs.launchpad.net/glance/+bug/2156432","commit_id":"551eb567786ac3dfc1004653296ba70ce1b50895"}]}
