)]}'
{"id":"openstack%2Fglance~996404","triplet_id":"openstack%2Fglance~master~Ib3881e3beb48cbd2d69fc93ff39e3fb83000e5a4","project":"openstack/glance","branch":"master","hashtags":[],"change_id":"Ib3881e3beb48cbd2d69fc93ff39e3fb83000e5a4","subject":"Make image_conversion revert tolerate queued images","status":"NEW","created":"2026-07-08 06:42:13.000000000","updated":"2026-07-08 12:15:34.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8bf750bb7ae794d3d2e7d3eed8c54ba55890d9db","_number":996404,"virtual_id_number":996404,"owner":{"_account_id":39302,"name":"Mahmoud","email":"abouzeid@momentumx.cloud","username":"abouzeid87"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-07-08 08:59:44.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-08 08:59:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a2a31d9468204f01f6d4bab594d0af1306dc0536","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":39302,"name":"Mahmoud","email":"abouzeid@momentumx.cloud","username":"abouzeid87"},"date":"2026-07-08 06:42:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"95344f569702c5d3b6689eba80d60aab5c934a91","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-08 08:59:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b11652f059a646e6a4aae16dc1007810\n\n- grenade https://zuul.opendev.org/t/openstack/build/c8cdde731c3b44ffa1134bfa2f6d9d27 : SUCCESS in 1h 04m 31s\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/328479655dd646df902f7e158327c571 : SUCCESS in 1h 06m 33s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/c3bb90583d8a412c966ab99191d9ec9a : SUCCESS in 1h 24m 18s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/f4914087cf11432cb1cb255b29fdfe4d : SUCCESS in 1h 19m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1ba37bdbab7d48ac99845b42604c9e6f : SUCCESS in 3m 33s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/258edbcaf9ec44fa9e0b0ea365f62710 : SUCCESS in 3m 01s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/a6c2345b477d4239b6fab29cb501077e : SUCCESS in 4m 58s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/d62d1d7c79b84747bee8a4e1ef51e706 : SUCCESS in 4m 45s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9ffc578f783f4f089858779fdcbb67ca : SUCCESS in 7m 35s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a5ec42f5d1e14300a3ba9757b9500a38 : SUCCESS in 8m 24s\n- openstack-tox-functional-py311 https://zuul.opendev.org/t/openstack/build/d4cd548366384590baf2d6c501f3e570 : SUCCESS in 7m 24s\n- openstack-tox-functional-py313 https://zuul.opendev.org/t/openstack/build/1dcc51c1dbd2439398049be4854ad08f : SUCCESS in 6m 20s\n- glance-ceph-thin-provisioning https://zuul.opendev.org/t/openstack/build/2006070823694964bbfeb230ffb60d97 : SUCCESS in 1h 42m 33s (non-voting)\n- tempest-integrated-storage-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/db5565f373fe413d9b3a5d1e4876e222 : SUCCESS in 1h 55m 28s\n- tempest-integrated-storage-import https://zuul.opendev.org/t/openstack/build/cb6e795fa1ef4c26b327f372756cfb6c : SUCCESS in 2h 05m 05s\n- glance-multistore-cinder-import https://zuul.opendev.org/t/openstack/build/4567e8550a004074a6c620a1942ba5ff : SUCCESS in 2h 01m 07s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/d4e293b9468c47c9b1ed4f543c44c9ba : SUCCESS in 43m 42s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/cc13df112b0e4474b4935d60397560da : SUCCESS in 1h 39m 36s\n- glance-s3-multistore https://zuul.opendev.org/t/openstack/build/e5771abc3af8473889e98aa75434c479 : SUCCESS in 1h 59m 13s (non-voting)\n- glance-secure-rbac-protection-functional https://zuul.opendev.org/t/openstack/build/368615ad21a548c4a573443f7436407c : SUCCESS in 40m 53s\n- glance-rally-task-uwsgi https://zuul.opendev.org/t/openstack/build/a19603ef72264c1f87b2f225bd81160c : SUCCESS in 50m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8bf750bb7ae794d3d2e7d3eed8c54ba55890d9db","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-08 12:15:34.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/13fe1e5f44914d5484d05cad2bd331f2\n\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/2102a10dc41c4522b30265cd724619a2 : SUCCESS in 9m 55s (non-voting)\n- openstack-tox-py313-arm64 https://zuul.opendev.org/t/openstack/build/efefbfd46e5d4cd6ae502c4f17ae8a0f : SUCCESS in 8m 05s (non-voting)\n- openstack-tox-py314-arm64 https://zuul.opendev.org/t/openstack/build/8643813f3e5844ecaf05e183af5522d0 : SUCCESS in 9m 54s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b8164ea7c78ae8089a0fd8ad6598ce81a17566de","revisions":{"b8164ea7c78ae8089a0fd8ad6598ce81a17566de":{"kind":"REWORK","_number":1,"created":"2026-07-08 06:42:13.000000000","uploader":{"_account_id":39302,"name":"Mahmoud","email":"abouzeid@momentumx.cloud","username":"abouzeid87"},"ref":"refs/changes/04/996404/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/04/996404/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/04/996404/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/04/996404/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/04/996404/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/04/996404/1"}}},"commit":{"parents":[{"commit":"e8b1b8453aeae77039a6dab87bf6162ead5530a8","subject":"Merge \"Remove outdated comments\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/e8b1b8453aeae77039a6dab87bf6162ead5530a8"}]}],"author":{"name":"Mahmoud Abouzeid","email":"abouzeid@momentumx.cloud","date":"2026-07-08 06:41:30.000000000","tz":180},"committer":{"name":"Mahmoud Abouzeid","email":"abouzeid@momentumx.cloud","date":"2026-07-08 06:41:30.000000000","tz":180},"subject":"Make image_conversion revert tolerate queued images","message":"Make image_conversion revert tolerate queued images\n\n_ConvertImage.revert() unconditionally sets the image status back to\n\u0027queued\u0027 (introduced for bug 2072483). \u0027queued\u0027 -\u003e \u0027queued\u0027 is not a\nvalid transition, so if revert runs while the image is already queued\n(revert re-entry, or a failure path that reverted the status first) it\nraises InvalidImageStatusTransition. That masks the original conversion\nfailure and aborts the remaining cleanup, leaving importing/failed\nstore lists not updated.\n\nGuard the transition on the current status, the same way the quota\nfailure cleanup in api_image_import already does.\n\nRelated-Bug: #2072483\nCloses-Bug: #2160099\nfails with InvalidImageStatusTransition: queued -\u003e queued\"; no existing\nreport found as of 2026-07-07)\n\nChange-Id: Ib3881e3beb48cbd2d69fc93ff39e3fb83000e5a4\nSigned-off-by: Mahmoud Abouzeid \u003cabouzeid@momentumx.cloud\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/b8164ea7c78ae8089a0fd8ad6598ce81a17566de"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/b8164ea7c78ae8089a0fd8ad6598ce81a17566de"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}