)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"c17db9bb0216395426a40d97c56199933dabfb81","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix Discovery usage schema"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The usage schema is currently presented as an array incorrectly."},{"line_number":10,"context_line":"According to the [doc](https://docs.openstack.org/api-ref/image/v2/index.html#quota-usage), the [keystone quotas](https://opendev.org/openstack/glance/src/commit/d2a95f439c2f31973952ac75531f1924168902b7/glance/quota/keystone.py#L154-L163) and the [discovery code itself](https://opendev.org/openstack/glance/src/branch/master/glance/api/v2/discovery.py#L197-L202) this schema should be nested object."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I63a69e7ca44d8629f73bee85613fdcf5e941bddb"},{"line_number":13,"context_line":"Signed-off-by: Alexandre Engloner \u003calexandre.engloner@ovhcloud.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3dfabf58_237014e1","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":400},"updated":"2026-07-29 15:37:12.000000000","message":"So, there is no markdown rendering in gerrit, nor in my terminal :)\n\nPlease use the following convention:\n\n    Something something doc[1] and code[2]\n    \n    [1] https://...\n    [2] https://...\n\nAlso links to the \"master\" branch will soon be \"deprecated\", try to include links with a specific commit.","commit_id":"ee66f8f3d7f5fad71770a4704fce1c8ef5e6a2f9"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"7082697dd626c171fac9e8741c4dcb88da2b1f75","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix Discovery usage schema"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The usage schema is currently presented as an array incorrectly."},{"line_number":10,"context_line":"According to the [doc](https://docs.openstack.org/api-ref/image/v2/index.html#quota-usage), the [keystone quotas](https://opendev.org/openstack/glance/src/commit/d2a95f439c2f31973952ac75531f1924168902b7/glance/quota/keystone.py#L154-L163) and the [discovery code itself](https://opendev.org/openstack/glance/src/branch/master/glance/api/v2/discovery.py#L197-L202) this schema should be nested object."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I63a69e7ca44d8629f73bee85613fdcf5e941bddb"},{"line_number":13,"context_line":"Signed-off-by: Alexandre Engloner \u003calexandre.engloner@ovhcloud.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"94428a36_5404f63b","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":400},"in_reply_to":"1bb4e0df_9dbe9fdc","updated":"2026-07-31 14:40:00.000000000","message":"OK please fix the commit message and I\u0027ll +2.","commit_id":"ee66f8f3d7f5fad71770a4704fce1c8ef5e6a2f9"},{"author":{"_account_id":39279,"name":"Alexandre Engloner","display_name":"AEngloner","email":"alexandre.engloner@gmail.com","username":"aengloner"},"change_message_id":"dc4deef8887697e9718705870407d02f3a472223","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix Discovery usage schema"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The usage schema is currently presented as an array incorrectly."},{"line_number":10,"context_line":"According to the [doc](https://docs.openstack.org/api-ref/image/v2/index.html#quota-usage), the [keystone quotas](https://opendev.org/openstack/glance/src/commit/d2a95f439c2f31973952ac75531f1924168902b7/glance/quota/keystone.py#L154-L163) and the [discovery code itself](https://opendev.org/openstack/glance/src/branch/master/glance/api/v2/discovery.py#L197-L202) this schema should be nested object."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I63a69e7ca44d8629f73bee85613fdcf5e941bddb"},{"line_number":13,"context_line":"Signed-off-by: Alexandre Engloner \u003calexandre.engloner@ovhcloud.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1bb4e0df_9dbe9fdc","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":400},"in_reply_to":"3dfabf58_237014e1","updated":"2026-07-30 14:04:03.000000000","message":"Yeah, I discovered this the hard way.\nI actually made a more readable commit message in patchset 2, but accidentally overwrote it with the initial version when I amended my commit.\n\nI\u0027ll use both suggestions from now on.","commit_id":"ee66f8f3d7f5fad71770a4704fce1c8ef5e6a2f9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":39279,"name":"Alexandre Engloner","display_name":"AEngloner","email":"alexandre.engloner@gmail.com","username":"aengloner"},"change_message_id":"bd2feab279eae9dc513fa5bfac0ba4811ef982af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"60ce60b8_28643bc7","updated":"2026-07-22 11:37:18.000000000","message":"__OpenAPI 3 Schema before__\n\ncomponents:\n  schemas:\n    InfoUsageGet_UsageResponse:\n      additionalProperties: false\n      properties:\n        usage:\n          items:\n            additionalProperties: true\n            type: object\n            validation_data:\n              additionalProperties: false\n              properties:\n                limit:\n                  type: integer\n                usage:\n                  type: integer\n              type: object\n          type: array\n      type: object\n\n__OpenAPI 3 Schema after__\n\ncomponents:\n  schemas:\n    InfoUsageGet_UsageResponse:\n      additionalProperties: false\n      properties:\n        usage:\n          properties:\n            image_count_total:\n              additionalProperties: false\n              properties:\n                limit:\n                  type: integer\n                usage:\n                  type: integer\n              type: object\n            image_count_uploading:\n              additionalProperties: false\n              properties:\n                limit:\n                  type: integer\n                usage:\n                  type: integer\n              type: object\n            image_size_total:\n              additionalProperties: false\n              properties:\n                limit:\n                  type: integer\n                usage:\n                  type: integer\n              type: object\n            image_stage_total:\n              additionalProperties: false\n              properties:\n                limit:\n                  type: integer\n                usage:\n                  type: integer\n              type: object\n          type: object\n      type: object","commit_id":"c57839a1d6a75ef6a9e89a7b675148430b8b00ee"},{"author":{"_account_id":39279,"name":"Alexandre Engloner","display_name":"AEngloner","email":"alexandre.engloner@gmail.com","username":"aengloner"},"change_message_id":"64a9ca9e83470e351ea6eed2e193b2e14ed2a97a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4528c3ff_7dccd174","in_reply_to":"60ce60b8_28643bc7","updated":"2026-07-22 12:01:31.000000000","message":"Previous comment removed the indent.\n\n**OpenAPI 3 Schema before the change**\n```yaml\ncomponents:\n  schemas:\n    InfoUsageGet_UsageResponse:\n      additionalProperties: false\n      properties:\n        usage:\n          items:\n            additionalProperties: true\n            type: object\n            validation_data:\n              additionalProperties: false\n              properties:\n                limit:\n                  type: integer\n                usage:\n                  type: integer\n              type: object\n          type: array\n      type: object\n```\n\n****\n\n**OpenAPI 3 Schema after the change**\n```yaml\ncomponents:\n  schemas:\n    InfoUsageGet_UsageResponse:\n      additionalProperties: false\n      properties:\n        usage:\n          properties:\n            image_count_total:\n              additionalProperties: false\n              properties:\n                limit:\n                  type: integer\n                usage:\n                  type: integer\n              type: object\n            image_count_uploading:\n              additionalProperties: false\n              properties:\n                limit:\n                  type: integer\n                usage:\n                  type: integer\n              type: object\n            image_size_total:\n              additionalProperties: false\n              properties:\n                limit:\n                  type: integer\n                usage:\n                  type: integer\n              type: object\n            image_stage_total:\n              additionalProperties: false\n              properties:\n                limit:\n                  type: integer\n                usage:\n                  type: integer\n              type: object\n          type: object\n      type: object\n```","commit_id":"c57839a1d6a75ef6a9e89a7b675148430b8b00ee"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"7082697dd626c171fac9e8741c4dcb88da2b1f75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3010f4cc_1357cb42","updated":"2026-07-31 14:40:00.000000000","message":"Let\u0027s just fix the commit message and this looks good to go.","commit_id":"ee66f8f3d7f5fad71770a4704fce1c8ef5e6a2f9"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"c17db9bb0216395426a40d97c56199933dabfb81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6f2a13fa_9dd25b95","updated":"2026-07-29 15:37:12.000000000","message":"Some suggestions inline, I\u0027ll also ping @dms@danplanet.com","commit_id":"ee66f8f3d7f5fad71770a4704fce1c8ef5e6a2f9"}],"glance/api/v2/discovery.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"c17db9bb0216395426a40d97c56199933dabfb81","unresolved":true,"context_lines":[{"line_number":242,"context_line":"                    \u0027limit\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":243,"context_line":"                },"},{"line_number":244,"context_line":"            },"},{"line_number":245,"context_line":"            \u0027image_count_uploading\u0027: {"},{"line_number":246,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":247,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":248,"context_line":"                \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a2c6f0b_1746b841","line":245,"range":{"start_line":245,"start_character":36,"end_line":245,"end_character":37},"updated":"2026-07-29 15:37:12.000000000","message":"We could also apparently do something like:\n\n    _USAGE_SCHEMA \u003d {\n        \u0027usage\u0027: {\n            \u0027type\u0027: \u0027object\u0027,\n            \u0027additionalProperties\u0027: {\n                \u0027type\u0027: \u0027object\u0027,\n                \u0027properties\u0027: {\n                    \u0027usage\u0027: {\u0027type\u0027: \u0027integer\u0027},\n                    \u0027limit\u0027: {\u0027type\u0027: \u0027integer\u0027},\n                },\n            },\n        },\n    }\n\nWhich would not need updating should we add new quotas in the future, but I have no preference, to be honest.","commit_id":"ee66f8f3d7f5fad71770a4704fce1c8ef5e6a2f9"},{"author":{"_account_id":39279,"name":"Alexandre Engloner","display_name":"AEngloner","email":"alexandre.engloner@gmail.com","username":"aengloner"},"change_message_id":"dc4deef8887697e9718705870407d02f3a472223","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                    \u0027limit\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":243,"context_line":"                },"},{"line_number":244,"context_line":"            },"},{"line_number":245,"context_line":"            \u0027image_count_uploading\u0027: {"},{"line_number":246,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":247,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":248,"context_line":"                \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"c724759c_0449492c","line":245,"range":{"start_line":245,"start_character":36,"end_line":245,"end_character":37},"in_reply_to":"9a2c6f0b_1746b841","updated":"2026-07-30 14:04:03.000000000","message":"That\u0027s true, but unless there are plans to add new quotas in a near future or you have a change of heart in your preference, I\u0027d stick with my version.\n\nTo me, the more accurate it is, the better it is for the understanding of the reader. It also sets clear expectations on what the API will return.","commit_id":"ee66f8f3d7f5fad71770a4704fce1c8ef5e6a2f9"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"7082697dd626c171fac9e8741c4dcb88da2b1f75","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                    \u0027limit\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":243,"context_line":"                },"},{"line_number":244,"context_line":"            },"},{"line_number":245,"context_line":"            \u0027image_count_uploading\u0027: {"},{"line_number":246,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":247,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":248,"context_line":"                \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"01f5c4e4_a74e1f93","line":245,"range":{"start_line":245,"start_character":36,"end_line":245,"end_character":37},"in_reply_to":"c724759c_0449492c","updated":"2026-07-31 14:40:00.000000000","message":"That makes sense, let\u0027s keep it as is.","commit_id":"ee66f8f3d7f5fad71770a4704fce1c8ef5e6a2f9"}]}