)]}'
{"gnocchi/indexer/__init__.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"669af37ac602ab4477bbf81e87d2073414334bbb","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @staticmethod"},{"line_number":119,"context_line":"    def get_resource(resource_type, uuid):"},{"line_number":120,"context_line":"        raise gnocchi.NotImplementedError"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @staticmethod"},{"line_number":123,"context_line":"    def list_resources(resource_type\u003d\u0027generic\u0027, started_after\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_7dee6423","line":120,"updated":"2014-09-15 15:07:45.000000000","message":"Am I being dumb here, but doesn\u0027t this raise the gnocchi.NotImplementedError class as opposed to an instance of that class?\n\nWould it be more correct to instantiate?:\n\n  raise gnocchi.NotImplementedError()","commit_id":"03369eaeaaac7173569d76e78a7a3b87941b2b3b"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"1b3d24f901d8520f88e09d3d9696059d93544518","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @staticmethod"},{"line_number":119,"context_line":"    def get_resource(resource_type, uuid):"},{"line_number":120,"context_line":"        raise gnocchi.NotImplementedError"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @staticmethod"},{"line_number":123,"context_line":"    def list_resources(resource_type\u003d\u0027generic\u0027, started_after\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_15bef964","line":120,"in_reply_to":"fa98f980_7dee6423","updated":"2014-09-16 08:45:04.000000000","message":"Doesn\u0027t matter, Python automatically instanciate it :)","commit_id":"03369eaeaaac7173569d76e78a7a3b87941b2b3b"}],"gnocchi/tests/__init__.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"669af37ac602ab4477bbf81e87d2073414334bbb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        try:"},{"line_number":50,"context_line":"            return func(*args, **kwargs)"},{"line_number":51,"context_line":"        except AssertionError:"},{"line_number":52,"context_line":"            raise"},{"line_number":53,"context_line":"        except gnocchi.NotImplementedError as e:"},{"line_number":54,"context_line":"            raise testcase.TestSkipped(six.text_type(e))"},{"line_number":55,"context_line":"    return skip_if_not_implemented"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_fd36d4e5","line":52,"updated":"2014-09-15 15:07:45.000000000","message":"I think the AssertionError clause can be removed here, as it\u0027s only needed if there\u0027s a catch-all clause also.","commit_id":"03369eaeaaac7173569d76e78a7a3b87941b2b3b"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"1b3d24f901d8520f88e09d3d9696059d93544518","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        try:"},{"line_number":50,"context_line":"            return func(*args, **kwargs)"},{"line_number":51,"context_line":"        except AssertionError:"},{"line_number":52,"context_line":"            raise"},{"line_number":53,"context_line":"        except gnocchi.NotImplementedError as e:"},{"line_number":54,"context_line":"            raise testcase.TestSkipped(six.text_type(e))"},{"line_number":55,"context_line":"    return skip_if_not_implemented"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_35c13de4","line":52,"in_reply_to":"fa98f980_fd36d4e5","updated":"2014-09-16 08:45:04.000000000","message":"Done","commit_id":"03369eaeaaac7173569d76e78a7a3b87941b2b3b"}]}
