)]}'
{"gnocchi/rest/__init__.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"8a70b3547ee134a71188904744469ba82699774a","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        except indexer.ArchivePolicyAlreadyExists as e:"},{"line_number":179,"context_line":"            pecan.abort(409, e)"},{"line_number":180,"context_line":"        pecan.response.headers[\u0027Location\u0027] \u003d (\"/v1/archive_policy/\""},{"line_number":181,"context_line":"                                              + str(ap[\u0027name\u0027]))"},{"line_number":182,"context_line":"        pecan.response.status \u003d 201"},{"line_number":183,"context_line":"        return ArchivePolicyItem.archive_policy_to_human_readable(ap)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_07107c4d","line":181,"updated":"2014-10-20 08:17:30.000000000","message":"As said on IRC, that should fail is the archive policy name is UTF-8 encoded. Please add a test to show that, and then fix this fix. ;)","commit_id":"428556244967d725cfe0746e5357e5daf98b7305"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"228ac0202fa3c5c8704141d21f715076d8cceaa5","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            pecan.abort(409, e)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        name \u003d ap[\u0027name\u0027]"},{"line_number":182,"context_line":"        if six.PY2:"},{"line_number":183,"context_line":"            name \u003d ap[\u0027name\u0027].encode(\u0027utf-8\u0027)"},{"line_number":184,"context_line":"        pecan.response.headers[\u0027Location\u0027] \u003d (\"/v1/archive_policy/\" + name)"},{"line_number":185,"context_line":"        pecan.response.status \u003d 201"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_afca1a9f","line":182,"updated":"2014-10-20 15:26:59.000000000","message":"Uh? I don\u0027t see why it has to be different with Py2/Py3.","commit_id":"aec085ed5058c33a6c8c72ba210420bcaf987179"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"692c4245b3fdb8263566a34381964d7cda1aa9a5","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            pecan.abort(409, e)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        name \u003d ap[\u0027name\u0027]"},{"line_number":182,"context_line":"        if six.PY2:"},{"line_number":183,"context_line":"            name \u003d ap[\u0027name\u0027].encode(\u0027utf-8\u0027)"},{"line_number":184,"context_line":"        pecan.response.headers[\u0027Location\u0027] \u003d (\"/v1/archive_policy/\" + name)"},{"line_number":185,"context_line":"        pecan.response.status \u003d 201"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_f78f8221","line":182,"in_reply_to":"9aa7fdbe_afca1a9f","updated":"2014-10-21 09:40:25.000000000","message":"Yes this looks weird to me too, but\n\npecan.response.headers[\u0027Location\u0027] expect to be is str in python 2 AND 3 \u003c-- I guess this is the weird thing, no ? \n\nwsgiref does a assert if a header is not str (in both python version)\nWith apache_mod_wsgi I got only that \u0027TypeError: expected byte string object for header value, value of type unicode found\u0027\n\nThe database return unicode that need to be converted to str in python 2 but not in python3 (str and unicode are same thing).\n\nFor me, the location header should be a quoted url in 7bit ASCII","commit_id":"aec085ed5058c33a6c8c72ba210420bcaf987179"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"2508c69e157aff94a46dce1dfd8fcc5ba87ee190","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def set_resp_location_hdr(location):"},{"line_number":40,"context_line":"    # NOTE(sileht): according the pep-8888 the headers must be"},{"line_number":41,"context_line":"    # str in py2 and py3 even this is not the same thing in both"},{"line_number":42,"context_line":"    # version"},{"line_number":43,"context_line":"    # see: http://legacy.python.org/dev/peps/pep-3333/#unicode-issues"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_b126c114","line":40,"updated":"2014-10-22 09:05:58.000000000","message":"8888? That\u0027s the Google DNS or what? I thint you meant 3333","commit_id":"fae43236b73b8b8b30b6f84f8c3aa0114d991d02"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"98e9f7078b3822e5cf793512d03a99456e24e084","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def set_resp_location_hdr(location):"},{"line_number":40,"context_line":"    # NOTE(sileht): according the pep-8888 the headers must be"},{"line_number":41,"context_line":"    # str in py2 and py3 even this is not the same thing in both"},{"line_number":42,"context_line":"    # version"},{"line_number":43,"context_line":"    # see: http://legacy.python.org/dev/peps/pep-3333/#unicode-issues"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_c7d8e781","line":40,"in_reply_to":"9aa7fdbe_2cdef811","updated":"2014-10-22 09:52:33.000000000","message":"arf, well done.","commit_id":"fae43236b73b8b8b30b6f84f8c3aa0114d991d02"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"59b3737e26ced6505ec317c169d89c35586453cf","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def set_resp_location_hdr(location):"},{"line_number":40,"context_line":"    # NOTE(sileht): according the pep-8888 the headers must be"},{"line_number":41,"context_line":"    # str in py2 and py3 even this is not the same thing in both"},{"line_number":42,"context_line":"    # version"},{"line_number":43,"context_line":"    # see: http://legacy.python.org/dev/peps/pep-3333/#unicode-issues"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_2cdef811","line":40,"in_reply_to":"9aa7fdbe_b126c114","updated":"2014-10-22 09:28:28.000000000","message":"Eagle eyes :)","commit_id":"fae43236b73b8b8b30b6f84f8c3aa0114d991d02"}]}