)]}'
{"gnocchi/rest/__init__.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"bfeb3bf7c6c7a36d14b397dfe6ef12ee4c34d846","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        try:"},{"line_number":227,"context_line":"            entity \u003d pecan.request.indexer.get_resource("},{"line_number":228,"context_line":"                \u0027entity\u0027, self.entity_id)"},{"line_number":229,"context_line":"            if entity is None:"},{"line_number":230,"context_line":"                pecan.abort(404, str(storage.EntityDoesNotExist))"},{"line_number":231,"context_line":"            return entity"},{"line_number":232,"context_line":"        except storage.EntityDoesNotExist as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_f9e402ae","line":229,"updated":"2014-11-09 14:47:08.000000000","message":"That looks weird to me. If the entity is none that\u0027s because it does not exist, so you should have an exception, no?","commit_id":"43edef28ab28c5f03e2f59137a2257f1a885aa25"}],"gnocchi/tests/test_rest.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"f359b8bd52bc6b11c5a7fff259b039b237b160d2","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        result \u003d self.app.post_json(\"/v1/entity\","},{"line_number":340,"context_line":"                                    params\u003d{\"archive_policy\": \"medium\"})"},{"line_number":341,"context_line":"        self.assertEqual(\"application/json\", result.content_type)"},{"line_number":342,"context_line":"        self.assertEqual(201, result.status_code)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        result \u003d self.app.get(result.headers[\u0027Location\u0027])"},{"line_number":345,"context_line":"        self.assertEqual(200, result.status_code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_10636a1b","line":342,"updated":"2014-11-07 19:08:33.000000000","message":"use status\u003d201 in post_json","commit_id":"28cd90bbb004ee3d5268deeba24eccafb4701e8f"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"f359b8bd52bc6b11c5a7fff259b039b237b160d2","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        self.assertEqual(\"application/json\", result.content_type)"},{"line_number":342,"context_line":"        self.assertEqual(201, result.status_code)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        result \u003d self.app.get(result.headers[\u0027Location\u0027])"},{"line_number":345,"context_line":"        self.assertEqual(200, result.status_code)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        entity \u003d json.loads(result.text)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_306866f5","line":344,"updated":"2014-11-07 19:08:33.000000000","message":"same here","commit_id":"28cd90bbb004ee3d5268deeba24eccafb4701e8f"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"f359b8bd52bc6b11c5a7fff259b039b237b160d2","unresolved":false,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        entity \u003d json.loads(result.text)"},{"line_number":348,"context_line":"        self.assertEqual(entity[\u0027archive_policy\u0027], \"medium\")"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def test_post_entity_wrong_archive_policy(self):"},{"line_number":351,"context_line":"        policy \u003d str(uuid.uuid4())"},{"line_number":352,"context_line":"        result \u003d self.app.post_json(\"/v1/entity\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_f0a6de52","line":349,"updated":"2014-11-07 19:08:33.000000000","message":"Could you also add a test case with 404 being returned if the entity does not exist?","commit_id":"28cd90bbb004ee3d5268deeba24eccafb4701e8f"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"bfeb3bf7c6c7a36d14b397dfe6ef12ee4c34d846","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        self.assertEqual(entity[\u0027archive_policy\u0027], \"medium\")"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def test_get_entity_with_wrong_entity_id(self):"},{"line_number":349,"context_line":"        self.app.get(\"/v1/entity/{0}\".format(uuid.uuid4()), status\u003d404)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    def test_post_entity_wrong_archive_policy(self):"},{"line_number":352,"context_line":"        policy \u003d str(uuid.uuid4())"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_39ee8a8c","line":349,"updated":"2014-11-09 14:47:08.000000000","message":"check the error string returned too","commit_id":"43edef28ab28c5f03e2f59137a2257f1a885aa25"}]}